Template favorite button in monobook page actions is incorrectly aligned
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DLynch
	Jul 15 2025, 5:31 PM

Description

In monobook the text inside the tab is slightly too high, which is overlapping with the top border of the tab to some degree. This is because it's an OOUI ButtonElement that's been stuck inside a tab, and there's a lot of styles that don't expect this.

See e.g. https://en.wikipedia.org/wiki/Template:Sandbox?useskin=monobook&safemode=1

Ahchet's screenshot:

Favorite_template_monobook.png (600×800 px, 31 KB)

I see it less severely:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Unset vertical-align in the monobook favorite tab more thoroughly	mediawiki/extensions/TemplateData	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned Here: T397894: Load template page favorite button via SkinTemplateNavigation hook

Event Timeline

DLynch created this task.Jul 15 2025, 5:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2025, 5:31 PM

Change #1169707 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/TemplateData@master] Unset vertical-align in the monobook favorite tab more thoroughly

https://gerrit.wikimedia.org/r/1169707

gerritbot added a project: Patch-For-Review.Jul 15 2025, 5:31 PM

Maintenance_bot added a project: VisualEditor.Jul 15 2025, 6:29 PM

Was fixed as part of T397894 via https://gerrit.wikimedia.org/r/1167996.

Change #1169707 abandoned by DLynch: