Page MenuHomePhabricator
Create Task
Maniphest T399676

Update SVGO to v4.x in various extensions & skins
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Volker_E
Jul 16 2025, 4:40 AM
Tags
Referenced Files
None
Subscribers
Lens0021
Michael
thiemowmde
Volker_E

Description

Goal

Many Wikimedia extensions currently use 'svgo' package in v3.3.2 or v3.2.0 (CodeSearch) as result of formerly successful T339162.
With the new 4.x release there have been minimal changes and numerous bug fixes – as for example disabling both, removeViewBox and removeTitle plugins by default, which was counter-productive for our environment and has been set to disabled in each of the configs. Other changes like removeScriptElement → removeScripts plugin don't apply with the repos listed.

Acceptance criteria

Note that extensions Sanctions and AchievementBadges used by femiwiki also feature the package in v3.x.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
chore: Update svgo and minify svg filesmediawiki/extensions/GrowthExperimentsmaster+1 K -1 K
build: Use SVGO v4, move out of Grunt to be similar to other reposmediawiki/extensions/VisualEditormaster+2 K -1 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT399676 Update SVGO to v4.x in various extensions & skins
 ResolvedVolker_ET399678 Update SVGO to 4.x in Codex

Event Timeline

Volker_E created this task.Jul 16 2025, 4:40 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 16 2025, 4:40 AM
Restricted Application added a subscriber: Lens0021. · View Herald Transcript
Volker_E updated the task description. (Show Details)Jul 16 2025, 4:51 AM
Volker_E updated the task description. (Show Details)Jul 16 2025, 5:00 AM
Volker_E updated the task description. (Show Details)Jul 16 2025, 5:04 AM
gerritbot added a comment.Jul 16 2025, 12:59 PM

Change #1170143 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] build: Use SVGO v4, move out of Grunt to be similar to other repos

https://gerrit.wikimedia.org/r/1170143

gerritbot added a project: Patch-For-Review.Jul 16 2025, 12:59 PM
gerritbot added a comment.Jul 16 2025, 8:27 PM

Change #1170143 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] build: Use SVGO v4, move out of Grunt to be similar to other repos

https://gerrit.wikimedia.org/r/1170143

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2025, 8:31 PM
Volker_E updated the task description. (Show Details)Jul 16 2025, 10:54 PM
Catrope removed a project: Codex.Jul 21 2025, 6:39 PM
Michael subscribed.EditedJul 22 2025, 10:13 AM

So, the general recommended safe approach is to

  1. update to svgo v4
  2. copy over the new config from https://www.mediawiki.org/w/index.php?title=Manual%3ACoding_conventions%2FSVG#Exemplified_safe_configuration_(.svgo.config.js),
  3. run the minify script
  4. commit everything
  5. done

right?

I tried that and noticed that there were a couple issues with the config on mw.org:

  • missing commas
  • typo (fasle)
  • duplicate disabled rule cleanupNumericValues: false
  • a disabled rule that is instead apparently actually a plugin that we should just not use? removeOffCanvasPaths (source)
  • wrong quotes
  • missing semicolon

I've updated that example accordingly: https://www.mediawiki.org/w/index.php?diff=7762345 Please have a look to make sure I did not make any mistakes.

gerritbot added a comment.Jul 22 2025, 10:18 AM

Change #1171556 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] chore: Update svgo and minify svg files

https://gerrit.wikimedia.org/r/1171556

gerritbot added a project: Patch-For-Review.Jul 22 2025, 10:18 AM
Volker_E closed subtask T399678: Update SVGO to 4.x in Codex as Resolved.Jul 23 2025, 1:28 AM
Volker_E updated the task description. (Show Details)
Michael edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Jul 24 2025, 8:00 AM
Michael moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Jul 29 2025, 5:23 PM

Change #1171556 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] chore: Update svgo and minify svg files

https://gerrit.wikimedia.org/r/1171556

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2025, 5:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Jul 29 2025, 6:00 PM
Volker_E added a comment.Jul 30 2025, 5:02 AM

Thanks @Michael for going over the configuration. There are a number of flags/options set in the recent past, that are not important for the client sent SVGs for most of Wikimedia Foundation deployed repositories like in our icons (removeEditorsNSData as most bloating example).
We might end up with two configurations on the SVG coding conventions page, but as is, I would not recommend the config from there over the options in the established .svgo.config.js files in most of our repos.
I might have time end of week to care about the coding guidelines mw.org website, not earlier though.

Michael added a comment.Aug 18 2025, 2:49 PM

Any update here? I think, I'd like to also get this our of the way for the Thanks extension and then remove it from our board.

Michael removed a project: Growth-Team (Current Sprint).Aug 28 2025, 10:23 AM
Jdlrobson-WMF moved this task from Untriaged to Tracking on the MobileFrontend board.Sep 10 2025, 10:40 PM
Jdlrobson-WMF edited projects, added MobileFrontend (Tracking); removed MobileFrontend.
Jdlrobson-WMF moved this task from Backlog to Tech debt on the MonoBook board.Nov 10 2025, 11:10 PM
Jdlrobson-WMF moved this task from Incoming to Technical architecture on the Vector 2022 board.Nov 10 2025, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits