Maniphest T399712

IPReveal: Remove the log endpoint and use the batch mechanism instead
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Summary

After CheckUser patch #1167909, IP reveals in Special:Contributions are using the batch endpoint (i.e. a POST request).
The same mechanism should be used for codepaths currently using the log endpoint, which would allow to remove that endpoint.

Background

Under the scope of T385546: When too many revisions are revealed at once using the IP reveal APIs, the request fails because the URL is too long a change was made to call the batch IP reveal endpoint when the request is for revision IDs, which happens on Special:Contributions and history pages, therefore turning the previous GET request into a POST.
Relevant threads in Gerrit:
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1167909/comment/5f579bc1_e44d7d07/
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1167909/comments/7a4c781f_e02aa989

Acceptance criteria

The log endpoint is removed
Codepaths currently using the log endpoint use the batch endpoint instead

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	IPReveal: Use batch endpoint for log entries	mediawiki/extensions/CheckUser	master	+452 -655

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		hector.arroyo	T386925 Temporary account IP reveal: Display "no longer available" instead of "unavailable" when IP reveal fails due to data having expired
		Resolved		mszwarc	T399712 IPReveal: Remove the log endpoint and use the batch mechanism instead

Event Timeline

hector.arroyo created this task.Jul 16 2025, 11:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2025, 11:43 AM

Tchanders added a project: Trust and Safety Product Sprint.Jul 23 2025, 11:54 AM

Tchanders moved this task from Backlog to Maintenance to triage on the Trust and Safety Product Sprint board.

OKryva-WMF moved this task from Maintenance to triage to Sprint Rum baba (July 28 - August 15) on the Trust and Safety Product Sprint board.Jul 23 2025, 1:08 PM

OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)); removed Trust and Safety Product Sprint.

OKryva-WMF moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Jul 25 2025, 1:51 PM

OKryva-WMF moved this task from Ready to Maintenance Ready on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Jul 25 2025, 3:36 PM

Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Jul 28 2025, 6:36 PM

Tchanders set the point value for this task to 0.5.Jul 29 2025, 6:33 AM

I'm happy to pick up this ticket, but I prefer to do so after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1171567 gets merged so we don't lose time handling merge conflicts in the IP Reveal code (this will require changes in modules/ext.checkUser.tempAccounts/rest.js which is already being modified in that patch, which is currently in review).

hector.arroyo removed hector.arroyo as the assignee of this task.Jul 31 2025, 11:51 AM

mszwarc claimed this task.Aug 1 2025, 9:04 AM

Change #1175083 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CheckUser@master] IPReveal: Use batch endpoint for log entries

https://gerrit.wikimedia.org/r/1175083

gerritbot added a project: Patch-For-Review.Aug 1 2025, 11:54 AM

hector.arroyo moved this task from Maintenance Ready to In Progress on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Aug 1 2025, 12:22 PM

(Note: The log endpoint does not seem to be used by WMF code anymore so it seems safe to drop it altogether instead of depecating it first)

OKryva-WMF triaged this task as High priority.Aug 1 2025, 1:42 PM

I'll not make it today and the next week I'm at Wikimania, so I'm unassigning myself from that. If anyone takes this task, please note that it's less obvious than it seems to be. The performRevealRequest function, if passed with no ids, does not return the last IP, but the list of IPs used by a given temp. account. Especially, the module for Special:Block uses it in a way that expects to receive multiple IPs. This behavior cannot be served by the batch endpoint.

The patch that I submitted partially solves the issue – the callers have to be investigated and untied, so that we have functions serving single purposes.

OKryva-WMF moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Aug 5 2025, 1:09 PM

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 6 2025, 9:14 AM

hector.arroyo mentioned this in T386925: Temporary account IP reveal: Display "no longer available" instead of "unavailable" when IP reveal fails due to data having expired.Aug 6 2025, 3:16 PM

Dreamy_Jazz added a parent task: T386925: Temporary account IP reveal: Display "no longer available" instead of "unavailable" when IP reveal fails due to data having expired.Aug 6 2025, 6:30 PM

mszwarc claimed this task.Aug 11 2025, 7:26 AM

mszwarc moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.

mszwarc moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Aug 11 2025, 9:04 AM

Change #1175083 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IPReveal: Use batch endpoint for log entries

https://gerrit.wikimedia.org/r/1175083

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2025, 12:31 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19).Aug 12 2025, 1:00 PM