Maniphest T399713

IPReveal: Remove the revision endpoint and use the batch mechanism instead
Closed, ResolvedPublic1.5 Estimated Story Points
Actions

Description

Summary

After CheckUser patch #1167909, IP reveals in Special:Contributions are using the batch endpoint (i.e. a POST request).
The same mechanism should be used for codepaths currently using the revision endpoint, which would allow to remove that endpoint.

Background

Under the scope of T385546: When too many revisions are revealed at once using the IP reveal APIs, the request fails because the URL is too long a change was made to call the batch IP reveal endpoint when the request is for revision IDs, which happens on Special:Contributions and history pages, therefore turning the previous GET request into a POST.

Revelant threads in Gerrit:
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1167909/comment/5f579bc1_e44d7d07/
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1167909/comments/7a4c781f_e02aa989

Acceptance criteria

The revision endpoint is removed
Codepaths currently using the revision endpoint use the batch endpoint instead

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ipreveal: Remove the revisions endpoint	mediawiki/extensions/CheckUser	master	+388 -608
	ipreveal. Deprecate the IPReveal revision endpoint	mediawiki/extensions/CheckUser	master	+6 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hector.arroyo	T399713 IPReveal: Remove the revision endpoint and use the batch mechanism instead
Resolved	Dillon	T400901 Replace usages of CheckUser's /revision endpoint with /batch-temporaryaccount
Resolved	hector.arroyo	T413441 IPReveal: Remove usages of the revision endpoint left in CheckUser

Event Timeline

hector.arroyo created this task.Jul 16 2025, 11:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2025, 11:46 AM

Tchanders added a project: Trust and Safety Product Sprint.Jul 23 2025, 11:54 AM

Tchanders moved this task from Backlog to Maintenance to triage on the Trust and Safety Product Sprint board.

OKryva-WMF moved this task from Maintenance to triage to Sprint Rum baba (July 28 - August 15) on the Trust and Safety Product Sprint board.Jul 23 2025, 1:08 PM

OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)); removed Trust and Safety Product Sprint.

OKryva-WMF moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Jul 25 2025, 1:51 PM

OKryva-WMF moved this task from Ready to Maintenance Ready on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Jul 25 2025, 3:36 PM

Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Jul 28 2025, 6:36 PM

Tchanders set the point value for this task to 0.5.Jul 29 2025, 6:32 AM

I'm happy to pick up this ticket, but I prefer to do so after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1171567 gets merged so we don't lose time handling merge conflicts in the IP Reveal code (this will require changes in modules/ext.checkUser.tempAccounts/rest.js which is already being modified in that patch, which is currently in review).

hector.arroyo moved this task from Maintenance Ready to In Progress on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Jul 31 2025, 10:06 AM

hector.arroyo mentioned this in T400901: Replace usages of CheckUser's /revision endpoint with /batch-temporaryaccount.Jul 31 2025, 1:35 PM

Filed T400901: Replace usages of CheckUser's /revision endpoint with /batch-temporaryaccount for replacing usages of the /revision endpoint in PageTriage, which is needed in order to completely drop the endpoint in CheckUser.

Change #1174735 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipreveal. Deprecate the IPReveal revision endpoint

https://gerrit.wikimedia.org/r/1174735

gerritbot added a project: Patch-For-Review.Jul 31 2025, 2:11 PM

hector.arroyo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Aug 1 2025, 9:45 AM

Change #1174735 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipreveal. Deprecate the IPReveal revision endpoint

https://gerrit.wikimedia.org/r/1174735

An initial patch has been merged that tags the TemporaryAccountRevisionHandler as deprecated and removes a code path from the frontend code that was already unreachable.

However, the removal of the endpoint itself cannot happen until T400901: Replace usages of CheckUser's /revision endpoint with /batch-temporaryaccount is handled by PageTriage maintainers, therefore I'm moving this task back to the Backlog.

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Aug 1 2025, 11:00 AM

hector.arroyo added a subtask: T400901: Replace usages of CheckUser's /revision endpoint with /batch-temporaryaccount.Aug 1 2025, 11:03 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2025, 11:30 AM

OKryva-WMF triaged this task as Low priority.Aug 1 2025, 1:42 PM

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 6 2025, 9:14 AM

Dreamy_Jazz added a project: OKR-Work.Aug 14 2025, 9:40 AM

OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)); removed Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)).Aug 19 2025, 10:31 AM

OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)); removed Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)).Sep 4 2025, 3:05 PM

OKryva-WMF edited projects, added Product Safety and Integrity; removed Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)).Sep 29 2025, 9:04 AM

OKryva-WMF moved this task from Inbox to Later sprints on the Product Safety and Integrity board.Sep 29 2025, 3:37 PM

OKryva-WMF removed a project: Trust and Safety Product Team.Oct 10 2025, 10:51 AM

We should be able to hard deprecate this now.

Dreamy_Jazz changed the task status from Stalled to Open.Nov 6 2025, 5:42 PM

hector.arroyo moved this task from Next sprint to Essential Work Sprint (Dec 15th - Jan 9th) on the Product Safety and Integrity board.Nov 19 2025, 12:19 PM

hector.arroyo edited projects, added Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)); removed Product Safety and Integrity.

OKryva-WMF added a project: Essential-Work.Dec 10 2025, 12:24 PM

OKryva-WMF moved this task from Backlog to Ready on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.Dec 15 2025, 2:18 PM

Looks like https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CheckUser/+/refs/heads/master/modules/ext.checkUser.tempAccounts/rest.js#106 still calls /checkuser/v0/temporaryaccount/${target} instead of using the batch endpoint, but we should be able to tackle that as part of this task. My fault, that's not the revisions endpoint. In any case, usages left in CheckUser (i.e. mocks from tests) have been removed under T413441: IPReveal: Remove usages of the revision endpoint left in CheckUser.

Codesearch does not list any other usages of that endpoint besides the one mentioned above: https://codesearch.wmcloud.org/search/?q=%2Fcheckuser%2Fv0%2Ftemporaryaccount%2F&files=&excludeFiles=&repos=

hector.arroyo moved this task from Ready to In progress on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.Dec 23 2025, 1:54 PM

hector.arroyo changed the task status from Open to In Progress.Dec 23 2025, 3:17 PM

hector.arroyo mentioned this in T413441: IPReveal: Remove usages of the revision endpoint left in CheckUser.

hector.arroyo added a subtask: T413441: IPReveal: Remove usages of the revision endpoint left in CheckUser.

Change #1220641 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipreveal: Remove the revisions endpoint

https://gerrit.wikimedia.org/r/1220641

gerritbot added a project: Patch-For-Review.Dec 23 2025, 4:15 PM

Removing references found in wmf-openapi-linter in https://gitlab.wikimedia.org/toolforge-repos/wmf-openapi-linter/-/merge_requests/7

hector.arroyo moved this task from In progress to Needs review on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.Dec 23 2025, 4:35 PM

hector.arroyo closed subtask T413441: IPReveal: Remove usages of the revision endpoint left in CheckUser as Resolved.Jan 5 2026, 9:36 AM

As part of this task, I've updated the tests for BatchTemporaryAccountHandlerTest in order to cover some of the cases previously covered by TemporaryAccountRevisionHandler tests, which are now being dropped along with TemporaryAccountRevisionHandler itself.

Raising the estimation for this task.

hector.arroyo changed the point value for this task from 0.5 to 1.5.Jan 5 2026, 3:38 PM

Change #1220641 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipreveal: Remove the revisions endpoint

https://gerrit.wikimedia.org/r/1220641

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2026, 4:30 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1220641 has been merged, therefore I'm closing this task as there are no functional chnages to test.

hector.arroyo closed this task as Resolved.Jan 7 2026, 4:40 PM

Dreamy_Jazz mentioned this in T414008: CheckUser BatchTemporaryAccountHandlerTest failure breaks extensions that depend on CheckUser.Jan 7 2026, 6:30 PM

IPReveal: Remove the revision endpoint and use the batch mechanism insteadClosed, ResolvedPublic1.5 Estimated Story PointsActions