Page MenuHomePhabricator

appendSpecialPagesLinkIfAbsent is deprecated since 1.44 but in codebase of 1.44
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Use MediaWiki 1.44.

What happens?:

When users visit the site the logs get flooded with errors:
4 [error] 404841#404841: *10633464 FastCGI sent in stderr: "PHP message: PHP Deprecated: Use of MediaWiki\Skin\Skin::appendSpecialPagesLinkIfAbsent was deprecated in MediaWiki 1.44. [Called from MediaWiki\Skin\Skin::buildSidebar in /var/www/wiki/includes/skins/Skin.php at line 1639] in /var/www/wiki/includes/debug/MWDebug.php on line 386" while reading response header from upstream,

What should have happened instead?:

In the software zip files and tar packages Skin.php in the includes contains still references to the deprecated function. I would expect that this would be removed from the code instead as the Master branch contains a properly patched version of the file which doesn't contain any reference to it.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):