Page MenuHomePhabricator
Create Task
Maniphest T399774

Always activate autocompletion when typing page titles
Closed, ResolvedPublic
Actions

Description

Follow up to T95100: Add autocompletion to CodeMirror extension

Reported on enwiki at https://en.wikipedia.org/wiki/Special:Permalink/1300873436#How_to_fully_enable_the_page_title_autocomplete

I believe we made the title autocompletion for the MediaWiki mode opt-in via keystroke because this was the recommendation of the upstream library. However Wikimedians will prefer and expect autocompletion to act like the search bar, with suggestions added for each and every keystroke.

Provided we store the promise for the latest API request in a variable, and abort it before issuing a new request, there should be no performance concerns. There is also mw.util.throttle() if we need it.

It may make sense to still keep the ⇧+⏎ shortcut, say to re-trigger suggestions after accidentally dismissing them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CodeMirrorAutocomplete: retrigger opensearch on typingmediawiki/extensions/CodeMirrormaster+57 -53
Customize query in gerrit

Related Objects

Event Timeline

• MusikAnimal created this task.Jul 16 2025, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2025, 9:44 PM
• MusikAnimal updated the task description. (Show Details)Jul 16 2025, 9:45 PM
Alien333 awarded a token.Jul 16 2025, 9:54 PM
Alien333 subscribed.
Warudo awarded a token.Jul 16 2025, 10:14 PM
Warudo subscribed.
Bhsd subscribed.Jul 16 2025, 11:58 PM

Do you mean that we also want to drop validFor?

• MusikAnimal updated the task description. (Show Details)Jul 17 2025, 4:21 AM
• MusikAnimal added a comment.Jul 17 2025, 4:47 AM
In T399774#11011501, @Bhsd wrote:

Do you mean that we also want to drop validFor?

Yes, I think so! Re-reading the upstream docs, it looks like CodeMirror is trying to offer performance optimizations on behalf of the server. The filter option for example should probably be false. The MediaWiki search backend will know better on what to suggest when it comes to page titles. I don't think we'd want to add other completion sources, either, as that could get confusing. I see CM may also have a means to abort the query. It may be more appropriate to use that over the mw.Api helpers. Same with throttling.

Jack_who_built_the_house awarded a token.Jul 17 2025, 2:55 PM
Jack_who_built_the_house subscribed.
gerritbot added a comment.Sep 29 2025, 4:32 AM

Change #1191871 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorAutocomplete: retrigger opensearch on typing

https://gerrit.wikimedia.org/r/1191871

gerritbot added a project: Patch-For-Review.Sep 29 2025, 4:32 AM
Bhsd claimed this task.Sep 29 2025, 4:42 AM
lihaohong subscribed.Oct 7 2025, 5:30 AM
gerritbot added a comment.Oct 13 2025, 7:03 PM

Change #1191871 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorAutocomplete: retrigger opensearch on typing

https://gerrit.wikimedia.org/r/1191871

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2025, 7:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 13 2025, 8:00 PM
Bhsd closed this task as Resolved.Oct 20 2025, 4:31 AM
Bhsd moved this task from Improvement to Done on the MediaWiki-extensions-CodeMirror board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits