Edit Check: adjust paddings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bmartinezcalvo
	Jul 17 2025, 5:35 PM

Description

Background

As documented in the Figma specifications, we need to use the following paddings in the content (white part) of the Edit Check component (for all types of Checks):

spacing-75 (12px) on top, bottom, and sides
spacing-100 (16px) for vertical padding between the elements in the card: texts, buttons, and supporting text when it's visible

Acceptance criteria (or Done)

Fix the paddings Edit Check component

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Edit check: increase the padding below the decline survey	mediawiki/extensions/VisualEditor	master	+2 -5
	Edit check: adjust paddings	mediawiki/extensions/VisualEditor	master	+5 -3

Customize query in gerrit

Related Objects

Mentioned In: T389443: [Tone Check] Present survey when people choose to "Decline" invitation to revise tone

Event Timeline

bmartinezcalvo created this task.Jul 17 2025, 5:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2025, 5:35 PM

bmartinezcalvo mentioned this in T389443: [Tone Check] Present survey when people choose to "Decline" invitation to revise tone.Jul 17 2025, 5:38 PM

bmartinezcalvo added a project: EditCheckComponent.

ppelberg added a project: Editing-team (Planning).Jul 17 2025, 6:13 PM

ppelberg moved this task from Inbox to Q3 2025-2026 on the Editing-team (Planning) board.

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team (Planning).Jul 21 2025, 5:42 PM

Change #1174585 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: adjust paddings

https://gerrit.wikimedia.org/r/1174585

gerritbot added a project: Patch-For-Review.Jul 31 2025, 2:22 AM

With patch:

CleanShot 2025-07-30 at 21.22.16@2x.png (516×686 px, 43 KB)

CleanShot 2025-07-30 at 21.22.28@2x.png (394×672 px, 39 KB)

DLynch claimed this task.Jul 31 2025, 2:23 AM

DLynch moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Change #1174585 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: adjust paddings

https://gerrit.wikimedia.org/r/1174585

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2025, 3:30 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Jul 31 2025, 4:00 PM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 31 2025, 5:15 PM

DLynch added a project: Editing QA.

Dialogs use .ve-ui-editCheckActionWidget and styling applies across board.

Padding has been readjusted and margin-top set to spacing-100

Screenshot 2025-08-11 at 23.44.09.png (1×1 px, 249 KB)

Screenshot 2025-08-11 at 23.46.32.png (1×1 px, 174 KB)

Leaving for @bmartinezcalvo to close out

The same paddings should be applied in the decline survey, which is another step of Edit Check, which means using spacing-100 (16px) between description text, Radios, and buttons.

Captura de pantalla 2025-08-18 a las 12.33.23.png (560×670 px, 55 KB)

Change #1179694 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: increase the padding below the decline survey

https://gerrit.wikimedia.org/r/1179694

gerritbot added a project: Patch-For-Review.Aug 18 2025, 1:50 PM

CleanShot 2025-08-18 at 08.51.16@2x.png (578×664 px, 50 KB)

El T399883#11094131, @DLynch escribió:

Great, thank you!

bmartinezcalvo moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 18 2025, 3:06 PM

bmartinezcalvo updated the task description. (Show Details)

DLynch moved this task from Ready for Sign Off to Code Review on the Editing-team (Kanban Board) board.Aug 18 2025, 3:06 PM

Change #1179694 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: increase the padding below the decline survey

https://gerrit.wikimedia.org/r/1179694

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.15; 2025-08-19); removed MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Aug 18 2025, 4:00 PM

DLynch closed this task as Resolved.Aug 18 2025, 4:01 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2025, 4:31 PM

VPuffetMichel added a project: OKR-Work.Dec 8 2025, 10:43 PM

	F65778046: CleanShot 2025-08-18 at 08.51.16@2x.png
	Aug 18 2025, 1:51 PM

	F65776697: Captura de pantalla 2025-08-18 a las 12.33.23.png
	Aug 18 2025, 10:34 AM

	F65738702: Screenshot 2025-08-11 at 23.46.32.png
	Aug 11 2025, 10:51 PM

	F65738696: Screenshot 2025-08-11 at 23.44.09.png
	Aug 11 2025, 10:51 PM

	F65695288: CleanShot 2025-07-30 at 21.22.28@2x.png
	Jul 31 2025, 2:23 AM

	F65695283: CleanShot 2025-07-30 at 21.22.16@2x.png
	Jul 31 2025, 2:23 AM

Edit Check: adjust paddingsClosed, ResolvedPublicActions