Page MenuHomePhabricator

Patchdemo's "proxy Wikipedia content" feature doesn't work with Parsoid Read Views
Open, Needs TriagePublic

Description

See patchdemo example at https://defe6ff661.catalyst.wmcloud.org/w/index.php?title=New_York_metropolitan_area

'useParsoid' is set locally, but it is not passed on to the target proxy wiki. This leads to a confused situation, where the HTML isn't parsoid-generated, the "Rendered with Parsoid" footer doesn't appear, etc but "Switch to legacy parser" and "Report Visual Bug" appear in the sidebar as if this were parsoid-generated content.

Probably could be handled by just adding ?useParsoid=0/1 (or ?parsoid=0/1 for the parse API) to the URL used to fetch the target wiki contents.

Event Timeline

Change #1184173 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ApiParse: Add `parser=parsoid|legacy` parameter

https://gerrit.wikimedia.org/r/1184173

Change #1184174 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/MobileFrontendContentProvider@master] Proxy content using Parsoid when Parsoid Read Views is enabled

https://gerrit.wikimedia.org/r/1184174

Change #1184173 merged by jenkins-bot:

[mediawiki/core@master] ApiParse: Add `parser=parsoid|legacy|default` parameter

https://gerrit.wikimedia.org/r/1184173

Change #1184174 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontendContentProvider@master] Proxy content using Parsoid when Parsoid Read Views is enabled

https://gerrit.wikimedia.org/r/1184174

@cscott thanks for this <3

Are there other bits remaining here? Or is this all ready to close?