Page MenuHomePhabricator

Read from cuc_ip_hex, cule_ip_hex, and cupe_ip_hex instead of cuc_ip, cule_ip, and cupe_ip
Closed, ResolvedPublic1 Estimated Story Points

Description

Summary

We should read from the *_ip_hex column instead of the *_ip column when reading rows from any of cu_changes, cu_log_event, or cu_private_event

Background

Acceptance criteria

  • No code reads data from the cuc_ip, cule_ip, or cupe_ip columns (using them in WHERE conditions will be handled separately) - This includes code outside the CheckUser extension

Event Timeline

Dreamy_Jazz set the point value for this task to 0.75.Aug 1 2025, 12:19 PM
Dreamy_Jazz changed the point value for this task from 0.75 to 1.

Change #1218790 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@master] [WIP] Read from *_ip_hex instead of *_ip from CheckUser tables

https://gerrit.wikimedia.org/r/1218790

Looking at the uses of the IP columns:

Change #1219548 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Fix populateCheckUserTable.php to use null for no IP in hex column

https://gerrit.wikimedia.org/r/1219548

Change #1218790 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Read from *_ip_hex instead of *_ip from CheckUser tables

https://gerrit.wikimedia.org/r/1218790

Change #1219548 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix populateCheckUserTable.php to use null for no IP in hex column

https://gerrit.wikimedia.org/r/1219548

The only remaining uses on WMF wikis are in CheckUser (handled by T399956) and MediaWiki-extensions-LoginNotify which does not use the feature on WMF production