Page MenuHomePhabricator

Read from cuc_ip_hex, cule_ip_hex, and cupe_ip_hex instead of cuc_ip, cule_ip, and cupe_ip in CheckUser
Closed, ResolvedPublic

Description

Summary

We should read from the *_ip_hex column instead of the *_ip column when reading rows from any of cu_changes, cu_log_event, or cu_private_event

Background

Acceptance criteria

  • No code reads data from the cuc_ip, cule_ip, or cupe_ip columns in the CheckUser extension (unless it needs to read from it for a write operation)

Event Timeline

Change #1218727 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Read from *_ip_hex instead of *_ip columns from data tables

https://gerrit.wikimedia.org/r/1218727

Change #1219150 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] APIs: Read from *_ip_hex instead of of *_ip columns from database

https://gerrit.wikimedia.org/r/1219150

Change #1219153 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] CheckUser: Read from *_ip_hex instead of of *_ip columns from database

https://gerrit.wikimedia.org/r/1219153

Change #1219160 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Investigate: Read from *_ip_hex instead of *_ip columns from database

https://gerrit.wikimedia.org/r/1219160

Change #1219150 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] APIs: Read from *_ip_hex instead of of *_ip columns from database

https://gerrit.wikimedia.org/r/1219150

Change #1219153 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] CheckUser: Read from *_ip_hex instead of *_ip columns from database

https://gerrit.wikimedia.org/r/1219153

Change #1219160 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Investigate: Read from *_ip_hex instead of *_ip columns from database

https://gerrit.wikimedia.org/r/1219160

Change #1218727 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Read from *_ip_hex instead of *_ip columns from data tables

https://gerrit.wikimedia.org/r/1218727

mszwarc subscribed.

I've checked by grepping [}>_]ip[^_A-Z] in .php files in the current master, and I couldn't find any reads (other than related to writing data).