Page MenuHomePhabricator

Difference in rendering broken file with empty alt text
Closed, ResolvedPublic

Description

From https://parsoid-vs-core.wmflabs.org/diff/dtywiki/%E0%A5%A8%E0%A5%A6%E0%A5%A7%E0%A5%AF-%E0%A5%A8%E0%A5%A6_%E0%A4%95%E0%A5%8B%E0%A4%B0%E0%A5%8B%E0%A4%A8%E0%A4%BE%E0%A4%AD%E0%A4%BE%E0%A4%87%E0%A4%B0%E0%A4%B8_%E0%A4%AE%E0%A4%B9%E0%A4%BE%E0%A4%AE%E0%A4%BE%E0%A4%B0%E0%A5%80

λ (master) echo "[[File:Flag of Honduras (2008 Olympics).svg|23x15px|border |alt=|link=]]" | php maintenance/run.php parse

<p><span class="mw-image-border" typeof="mw:Error mw:File"><a href="/index.php?title=Special:Upload&amp;wpDestFile=Flag_of_Honduras_(2008_Olympics).svg" class="new" title="File:Flag of Honduras (2008 Olympics).svg"><span class="mw-file-element mw-broken-media" data-width="23" data-height="15">File:Flag of Honduras (2008 Olympics).svg</span></a></span>
</p>

λ (master) echo "[[File:Flag of Honduras (2008 Olympics).svg|23x15px|border |alt=|link=]]" | php maintenance/run.php parse --parsoid

<section data-mw-section-id="0" id="mwAQ"><p id="mwAg"><span class="mw-image-border" typeof="mw:Error mw:File" id="mwAw" data-mw="{&quot;attribs&quot;:[[&quot;alt&quot;,{&quot;txt&quot;:&quot;&quot;}],[&quot;link&quot;,{&quot;txt&quot;:&quot;&quot;}]],&quot;errors&quot;:[{&quot;key&quot;:&quot;apierror-filedoesnotexist&quot;,&quot;message&quot;:&quot;This image does not exist.&quot;}]}"><a href="http://ve:8080/wiki/Special:FilePath/Flag_of_Honduras_(2008_Olympics).svg" id="mwBA"><span class="mw-file-element mw-broken-media" resource="./File:Flag_of_Honduras_(2008_Olympics).svg" data-width="23" data-height="15" id="mwBQ"></span></a></span></p>
</section>

Event Timeline

ssastry triaged this task as High priority.Aug 22 2025, 7:22 PM

I am bumping up this priority since this is likely going to be more common and likely show up on other wikis. So, worth fixing this sooner than later.

Change #1181187 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Don't drop span content for $alt = ""

https://gerrit.wikimedia.org/r/1181187

Change #1181187 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Missing Images: Don't drop span content for "empty" alts

https://gerrit.wikimedia.org/r/1181187

Change #1181757 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a18

https://gerrit.wikimedia.org/r/1181757

Change #1181757 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a18

https://gerrit.wikimedia.org/r/1181757