Page MenuHomePhabricator

VisualEditor deletes list-defined references if there's a reference containing an ISBN and magic linking is enabled
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • On a wiki with $wgEnableMagicLinks['ISBN'] = true; (e.g. dewiki or frwiki)
  • Create a page using list-defined references and a valid ISBN, e.g. the following wikitext:
Test.<ref name="A1" />

== Test ==
Test.<ref name="A2" />

== Einzelnachweise ==
<references>
<ref name="A1">
ISBN 978383160698
</ref>
<ref name="A2">
abc
</ref>
</references>
  • Open this page in VisualEditor
  • Make any minor change and save the page

What happens?:

What should have happened instead?:

Other information:

Notes:

Related but slightly different version of this bug T400038: VisualEditor deletes list-defined references when editing one of them also fixed with 1170800

Event Timeline

Change #1170800 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Revert "VE: Enforce referenceslist reserialization when MW changed"

https://gerrit.wikimedia.org/r/1170800

Change #1171031 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@wmf/1.45.0-wmf.10] Revert "VE: Enforce referenceslist reserialization when MW changed"

https://gerrit.wikimedia.org/r/1171031

Change #1170800 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Revert "VE: Enforce referenceslist reserialization when MW changed"

https://gerrit.wikimedia.org/r/1170800

Change #1171031 merged by jenkins-bot:

[mediawiki/extensions/Cite@wmf/1.45.0-wmf.10] Revert "VE: Enforce referenceslist reserialization when MW changed"

https://gerrit.wikimedia.org/r/1171031

Mentioned in SAL (#wikimedia-operations) [2025-07-21T07:30:34Z] <awight@deploy1003> Started scap sync-world: Backport for [[gerrit:1171031|Revert "VE: Enforce referenceslist reserialization when MW changed" (T400013 T396017)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-21T07:51:25Z] <awight@deploy1003> wmde-fisch, awight: Backport for [[gerrit:1171031|Revert "VE: Enforce referenceslist reserialization when MW changed" (T400013 T396017)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-21T08:07:47Z] <awight@deploy1003> Finished scap sync-world: Backport for [[gerrit:1171031|Revert "VE: Enforce referenceslist reserialization when MW changed" (T400013 T396017)]] (duration: 37m 13s)