Page MenuHomePhabricator
Create Task
Maniphest T400043

CheckUser IP reveal: Support IP reveal on Special:AbuseLog (frontend)
Closed, ResolvedPublic1.5 Estimated Story Points
Actions

Description

Currently, AbuseFilter extension provides a custom log page at Special:AbuseLog which does not currently display "Show IP" links for temporary accounts that caused a log entry.

To address that, T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog aims to re-enable the "Show IP" button after fixing it to show the IP associated with the specific AbuseFilter log.

This task is to implement the frontend changes for that task, that is, use the new endpoint introduced by T400042: CheckUser IP reveal: Support IP reveal on Special:AbuseLog (backend) from the AbuseFilter log page.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ipreveal: Frontend changes supporting IPReveal in Special:AbuseLogmediawiki/extensions/CheckUsermaster+352 -50
AbuseLogPager: Include the AbuseFilter Log ID as a data attributemediawiki/extensions/AbuseFiltermaster+136 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

hector.arroyo created this task.Jul 21 2025, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2025, 9:44 AM
hector.arroyo mentioned this in T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog.Jul 21 2025, 9:46 AM
hector.arroyo added a parent task: T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog.Jul 21 2025, 9:49 AM
Dreamy_Jazz added a subtask: T400042: CheckUser IP reveal: Support IP reveal on Special:AbuseLog (backend).Jul 21 2025, 10:30 AM
Dreamy_Jazz mentioned this in T400049: Update AbuseFilter to add the abuse_filter_log afl_id to each log line.Jul 21 2025, 10:34 AM
Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.Jul 21 2025, 11:48 AM
gerritbot added a comment.Jul 21 2025, 3:08 PM

Change #1171229 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/AbuseFilter@master] AbuseLogPager: Include the AbuseFilter Log ID as a data attribute

https://gerrit.wikimedia.org/r/1171229

gerritbot added a project: Patch-For-Review.Jul 21 2025, 3:08 PM
Dreamy_Jazz assigned this task to hector.arroyo.Jul 21 2025, 6:40 PM
gerritbot added a comment.Jul 21 2025, 7:02 PM

Change #1171229 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] AbuseLogPager: Include the AbuseFilter Log ID as a data attribute

https://gerrit.wikimedia.org/r/1171229

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2025, 7:30 PM
Dreamy_Jazz closed subtask T400049: Update AbuseFilter to add the abuse_filter_log afl_id to each log line as Resolved.Jul 21 2025, 7:53 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.11; 2025-07-22).Jul 21 2025, 8:00 PM
kostajh moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)) board.Jul 22 2025, 7:10 AM
Niharika moved this task from To triage to In progress on the Temporary accounts (Global wiki rollout) board.Jul 22 2025, 10:38 AM
gerritbot added a comment.Jul 22 2025, 12:27 PM

Change #1171567 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipreveal: Frontend changes supporting IPReveal in Special:AbuseLog

https://gerrit.wikimedia.org/r/1171567

gerritbot added a project: Patch-For-Review.Jul 22 2025, 12:27 PM
hector.arroyo added a comment.Jul 22 2025, 4:22 PM

I have a working implementation for the frontend changes ready, pending tests: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1171567

Dreamy_Jazz closed subtask T400042: CheckUser IP reveal: Support IP reveal on Special:AbuseLog (backend) as Resolved.Jul 23 2025, 9:48 AM
hector.arroyo added a comment.Jul 23 2025, 3:32 PM

I'm reworking the previous patch to use a different approach, tests are still pending.

OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)); removed Trust and Safety Product Sprint (Sprint Cannoli (July 7 - July 25)).Jul 25 2025, 3:17 PM
OKryva-WMF moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.
hector.arroyo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.Jul 28 2025, 1:59 PM
hector.arroyo added a comment.Jul 28 2025, 2:11 PM

I've updated the patch to make the existing addIpRevealButtons() handle log entries from the Abuse Filter log page appropriately, made the dispatcher run a small stub that extracts the log IDs using a custom CSS selector targeting AF log IDs, and updated tests, so the patch can be reviewed now.

Tchanders set the point value for this task to 0.5.Jul 29 2025, 6:43 AM
hector.arroyo changed the point value for this task from 0.5 to 1.5.Jul 30 2025, 1:16 PM
hector.arroyo closed this task as Resolved.Jul 30 2025, 3:23 PM
hector.arroyo moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.

The patch for this ticket got upvoted and is being merged right now, so I'm closing this ticket and moving the parent to QA.

gerritbot added a comment.Jul 30 2025, 4:43 PM

Change #1171567 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipreveal: Frontend changes supporting IPReveal in Special:AbuseLog

https://gerrit.wikimedia.org/r/1171567

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.13; 2025-08-05); removed MW-1.45-notes (1.45.0-wmf.11; 2025-07-22).Jul 30 2025, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2025, 5:31 PM
OKryva-WMF added a project: OKR-Work.Oct 3 2025, 3:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits