Page MenuHomePhabricator

Write Cite test to catch the vanishing reflist items bug
Closed, ResolvedPublic

Description

Context:

We had some assumptions on what HTML VE actually needs to emit for Parsoid to convert safely back to Wikitext. The issues documented in T400013: VisualEditor deletes list-defined references if there's a reference containing an ISBN and magic linking is enabled and T400038: VisualEditor deletes list-defined references when editing one of them showed us that some of these assumptions were not true and furthermore that there's a certain amount of test coverage missing that would covered issues like the once produced. The issues were along the lines of:

Agenda:
  • Add a Converter test first with the original Wikitext using the TOOL
  • (Maybe) Add a VE->Parsoid one directional test to visualEditorHtml2WtTests.txt with the output of fromData body
  • Add a variation of the Converter test that includes modifications we want to test using the TOOL
  • Add a VE->Parsoid one directional test to visualEditorHtml2WtTests.txt with the output of fromData body
  • Ideally the test names in the Converter match test names in the Parsoid tests
Planed test
  • Converter tests covering the usage of stored original HTML
  • Without reflist
  • With list defined refs
  • With changes on list defined refs
  • One-directional Parsoid tests dealing with minimal VE HTML output to convert to Wikitext
  • With list defined refs
  • With main+details
  • With edits
  • A test with list defined references that include a template
  • With an edit changing a template parameter

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
WMDE-Fischmediawiki/extensions/Citemaster+151 -82
Thiemo Kreuz (WMDE)mediawiki/extensions/Citemaster+2 -0
WMDE-Fischmediawiki/extensions/Citemaster+505 -302
WMDE-Fischmediawiki/extensions/Citemaster+32 -8
WMDE-Fischmediawiki/extensions/Citemaster+167 -30
WMDE-Fischmediawiki/extensions/Citemaster+306 -279
WMDE-Fischmediawiki/extensions/Citemaster+20 -25
WMDE-Fischmediawiki/extensions/Citemaster+332 -0
WMDE-Fischmediawiki/extensions/Citemaster+244 -347
WMDE-Fischmediawiki/extensions/Citemaster+1 K -1 K
WMDE-Fischmediawiki/extensions/Citemaster+31 -0
WMDE-Fischmediawiki/extensions/Citemaster+167 -1
WMDE-Fischmediawiki/extensions/Citemaster+257 -0
WMDE-Fischmediawiki/extensions/Citemaster+28 -0
WMDE-Fischmediawiki/extensions/Citemaster+114 -0
Show related patches Customize query in gerrit

Event Timeline

WMDE-Fisch renamed this task from Write Cite test to catch the vanishing reflist items but to Write Cite test to catch the vanishing reflist items bug.Jul 21 2025, 10:47 AM
WMDE-Fisch claimed this task.

Change #1171218 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [WIP] Adding a test to make sure not losing list defined refs

https://gerrit.wikimedia.org/r/1171218

Change #1172507 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add Converter test including stored originalDomElements

https://gerrit.wikimedia.org/r/1172507

Change #1172613 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Parsoid: Add test to cover the minimal VE reflist output

https://gerrit.wikimedia.org/r/1172613

Change #1172507 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Add Converter test including stored originalDomElements

https://gerrit.wikimedia.org/r/1172507

Change #1172613 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid: Add test to cover the minimal VE reflist output

https://gerrit.wikimedia.org/r/1172613

Change #1173443 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add Converter test with list defined refs and stored originalDomElements

https://gerrit.wikimedia.org/r/1173443

Change #1171218 abandoned by WMDE-Fisch:

[mediawiki/extensions/Cite@master] [WIP] Adding a test to make sure not losing list defined refs

Reason:

I3d7fc2b0f7bd12d03ae41afb23000c56911e1027

https://gerrit.wikimedia.org/r/1171218

Change #1173884 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Adding Converter and fitting Parsoid tests for details

https://gerrit.wikimedia.org/r/1173884

Change #1173898 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add Converter test with list defined refs and fresh reflist

https://gerrit.wikimedia.org/r/1173898

Change #1173898 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Add Converter test with list defined refs and fresh reflist

https://gerrit.wikimedia.org/r/1173898

Change #1174323 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Parsoid: Proove in parser tests that VE reflist output is flexible

https://gerrit.wikimedia.org/r/1174323

Change #1174448 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [Refactor] Move VE Converter test to dedicated files

https://gerrit.wikimedia.org/r/1174448

Change #1173943 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Parsoid: Add Parser tests that match VE output

https://gerrit.wikimedia.org/r/1173943

Change #1173943 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid: Add Parser tests that match VE output

https://gerrit.wikimedia.org/r/1173943

Change #1174448 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Refactor] Move VE Converter test to dedicated files

https://gerrit.wikimedia.org/r/1174448

Change #1174601 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [Refactor] Extract method to prepare Converter cases

https://gerrit.wikimedia.org/r/1174601

Change #1174602 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Putting Converter tests using the store in its own test

https://gerrit.wikimedia.org/r/1174602

Change #1174610 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Converter: Add tests for references that include a template

https://gerrit.wikimedia.org/r/1174610

Change #1173884 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Converter: Improve simple main+details and add fitting Parsoid tests

https://gerrit.wikimedia.org/r/1173884

Change #1174610 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Converter: Add tests for references that include a template

https://gerrit.wikimedia.org/r/1174610

Change #1174601 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Refactor] Extract method to prepare Converter cases

https://gerrit.wikimedia.org/r/1174601

Change #1174602 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Putting Converter tests using the store in its own test

https://gerrit.wikimedia.org/r/1174602

Change #1173443 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Add Converter test with list defined refs and stored content

https://gerrit.wikimedia.org/r/1173443

Change #1174776 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Converter: Adjust LDR store test to include details

https://gerrit.wikimedia.org/r/1174776

Change #1174323 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid: Proove in parser tests that VE reflist output is flexible

https://gerrit.wikimedia.org/r/1174323

Change #1175084 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix broken parser test syntax

https://gerrit.wikimedia.org/r/1175084

Change #1174776 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Converter: Adjust LDR store test to include details

https://gerrit.wikimedia.org/r/1174776

Change #1175084 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix broken parser test syntax

https://gerrit.wikimedia.org/r/1175084

Change #1175163 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Converter tests: Rebuild the reference reuse usecase

https://gerrit.wikimedia.org/r/1175163

WMDE-Fisch updated the task description. (Show Details)

Change #1175163 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Converter tests: Rebuild the reference reuse usecase

https://gerrit.wikimedia.org/r/1175163