Page MenuHomePhabricator

Clean up LPL-owned settings on ex-wikipedia special wikis
Closed, ResolvedPublic2 Estimated Story Points

Description

Clean up <> settings on ex-wikipedia special wikis

Context: for historical reasons, a number of special wikis used to be categorized as Wikipedia wikis in wikimedia-config. These wikis are: arbcom_cswiki, arbcom_dewiki, arbcom_enwiki, arbcom_fiwiki, arbcom_nlwiki, arbcom_ruwiki, sysop_itwiki, wg_enwiki. This meant that if you used 'wikipedia' => $value for a config setting, that setting was applied not only to actual Wikipedia wikis, but also to the special wikis above. In T183549, those wikis have been moved out of the 'wikipedia' group and into the 'special' group. We also added explicit overrides to preserve the previous configuration, but this now needs to be cleaned up.

Request: the following config settings for components owned by the LPL team are affected by the above changes (full commented list in T183549#11020415):

  • wgSpecialContributeSkinsEnabled
  • wmgULSPosition

Please take a moment to determine whether it was intentional to set these values on special wikis. If so, or if you still think it would make sense to leave them enabled, we only need to remove TODO comments requesting further review (and reordering settings a bit). Otherwise, they should be unset. Please let me know if you have any questions or need help!

Event Timeline

Nikerabbit set the point value for this task to 1.
Nikerabbit subscribed.

I think these overrides can be removed.

Change #1199751 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[operations/mediawiki-config@master] Remove wmgULSPosition for special wikis

https://gerrit.wikimedia.org/r/1199751

abi_ moved this task from Ready for dev to In Progress on the LPL Essential (2025 Jul-Oct) board.
abi_ subscribed.

I don't see wgSpecialContributeSkinsEnabled overridden specifically for these wikis. My assumption is it has been removed already.

It changed it, but it looks like the special wikis are still currently part of the new dblist. (So, judging by @Nikerabbit's comment in T400067#11023613, maybe they should be removed from there?)

Yes we should remove those entries to disable the contribute link there.

Change #1199751 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wmgULSPosition for special wikis

https://gerrit.wikimedia.org/r/1199751

Mentioned in SAL (#wikimedia-operations) [2025-11-04T14:32:05Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1198390|azwiktionary: use new wordmark and tagline (T408147)]], [[gerrit:1199751|Remove wmgULSPosition for special wikis (T400067)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-04T14:34:21Z] <lucaswerkmeister-wmde@deploy2002> ekrem, lucaswerkmeister-wmde, abi: Backport for [[gerrit:1198390|azwiktionary: use new wordmark and tagline (T408147)]], [[gerrit:1199751|Remove wmgULSPosition for special wikis (T400067)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-11-04T14:41:38Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1198390|azwiktionary: use new wordmark and tagline (T408147)]], [[gerrit:1199751|Remove wmgULSPosition for special wikis (T400067)]] (duration: 09m 33s)

Testing on https://wg-en.wikipedia.org/wiki/Main_Page after deployment:

Before change:

image.png (905×1 px, 222 KB)

After change:

image.png (898×1 px, 236 KB)

abi_ changed the point value for this task from 1 to 2.Nov 5 2025, 1:47 PM

Change #1202144 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[operations/mediawiki-config@master] Remove SpecialContributeSkinsEnabled for special wikis

https://gerrit.wikimedia.org/r/1202144

abi_ changed the task status from Open to In Progress.Nov 6 2025, 7:52 AM
abi_ moved this task from Need QA to In Progress on the LPL Essential (FY2025-26 Q2) board.

It changed it, but it looks like the special wikis are still currently part of the new dblist. (So, judging by @Nikerabbit's comment in T400067#11023613, maybe they should be removed from there?)

The dblist-index.php and the dblists/specialcontribute.dblist are automatically generated via composer manage-dblist which generates the list of wikis using https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/dd5e22173a59cb541d6ed0ba7a879c5f197a6026/src/WmfConfig.php.

It changed it, but it looks like the special wikis are still currently part of the new dblist. (So, judging by @Nikerabbit's comment in T400067#11023613, maybe they should be removed from there?)

The dblist-index.php and the dblists/specialcontribute.dblist are automatically generated via composer manage-dblist which generates the list of wikis using https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/dd5e22173a59cb541d6ed0ba7a879c5f197a6026/src/WmfConfig.php.

Thanks @A_smart_kitten , this is addressed.

Change #1202144 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove SpecialContributeSkinsEnabled for special wikis

https://gerrit.wikimedia.org/r/1202144

Mentioned in SAL (#wikimedia-operations) [2025-11-11T14:14:47Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1202144|Remove SpecialContributeSkinsEnabled for special wikis (T400067)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-11T14:17:16Z] <kharlan@deploy2002> kharlan, abi: Backport for [[gerrit:1202144|Remove SpecialContributeSkinsEnabled for special wikis (T400067)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-11-11T14:25:31Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1202144|Remove SpecialContributeSkinsEnabled for special wikis (T400067)]] (duration: 10m 43s)

abi_ moved this task from Need QA to Done on the LPL Essential (FY2025-26 Q2) board.

No issues noticed. Marking this as done.