Page MenuHomePhabricator

Clean up Echo setting on ex-wikipedia special wikis
Closed, ResolvedPublic

Description

Context: for historical reasons, a number of special wikis used to be categorized as Wikipedia wikis in wikimedia-config. These wikis are: arbcom_cswiki, arbcom_dewiki, arbcom_enwiki, arbcom_fiwiki, arbcom_nlwiki, arbcom_ruwiki, sysop_itwiki, wg_enwiki. This meant that if you used 'wikipedia' => $value for a config setting, that setting was applied not only to actual Wikipedia wikis, but also to the special wikis above. In T183549, those wikis have been moved out of the 'wikipedia' group and into the 'special' group. We also added explicit overrides to preserve the previous configuration, but this now needs to be cleaned up.

Request: the following config setting for Echo is affected by the above changes (full commented list in T183549#11020415):

  • wmgEchoSiteNotificationIconUrl

Please take a moment to determine whether it was intentional to set these values on special wikis. If so, or if you still think it would make sense to leave them enabled, we only need to remove TODO comments requesting further review (and reordering settings a bit). Otherwise, they should be unset. Please let me know if you have any questions or need help!

Event Timeline

Restricted Application added subscribers: ZhaoFJx, Aklapper. · View Herald Transcript

This is about that icon:

image.png (173×546 px, 13 KB)

and without that icon, it looks like:

image.png (110×541 px, 7 KB)

The wikipedia icon is probably nicer than the exclamation mark, and so I would be inclined to just adjust the comment. But if there are dedicated logos for these special wikis or anyone has any other strong feelings about this, then I'm happy to take that into account, too.

Change #1171548 had a related patch set uploaded (by Michael Große; author: Michael Große):

[operations/mediawiki-config@master] Echo: be explicit about special wikis using Wikipedia logo

https://gerrit.wikimedia.org/r/1171548

Change #1171548 merged by jenkins-bot:

[operations/mediawiki-config@master] Echo: be explicit about special wikis using Wikipedia logo

https://gerrit.wikimedia.org/r/1171548

Mentioned in SAL (#wikimedia-operations) [2025-07-28T13:27:24Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1164287|Growth: enable new way of refreshing LinkRecommendations for more wikis (T386250 T392944)]], [[gerrit:1171548|Echo: be explicit about special wikis using Wikipedia logo (T400070)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-28T13:29:21Z] <lucaswerkmeister-wmde@deploy1003> lucaswerkmeister-wmde, migr: Backport for [[gerrit:1164287|Growth: enable new way of refreshing LinkRecommendations for more wikis (T386250 T392944)]], [[gerrit:1171548|Echo: be explicit about special wikis using Wikipedia logo (T400070)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-28T13:35:31Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1164287|Growth: enable new way of refreshing LinkRecommendations for more wikis (T386250 T392944)]], [[gerrit:1171548|Echo: be explicit about special wikis using Wikipedia logo (T400070)]] (duration: 08m 06s)

Michael claimed this task.

I think this can now be closed, right? The comment was changed to clearly state that the status quo is good enough for now, and I don't think there is more to do here. Let me know if I missed anything!

I think this can now be closed, right? The comment was changed to clearly state that the status quo is good enough for now, and I don't think there is more to do here. Let me know if I missed anything!

Yup, thank you!