Page MenuHomePhabricator
Create Task
Maniphest T400108

Wikidata import: incorrectly instantiating some zero values
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce (step by step instructions, with links, commands and necessary data to reproduce the error)

See the July 20 Comment in Wikifunctions project chat.

I've already identified the code that needs changing; planning to change during Fix-it week.

Observed behavior

  • Wikidata import code, in transform.js, generates the wrong value for Z16683K1/sign, for some cases where the value is zero.

Expected behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • Z16661 should be generated instead of Z16660, in these cases.

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2025-07-29-155618 to 2025-08-01-154925Genoveva Galarzaoperations/deployment-chartsmaster+1 -1
Customize query in gerrit

Event Timeline

DMartin-WMF created this task.Jul 21 2025, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2025, 9:47 PM
DMartin-WMF triaged this task as Medium priority.Jul 21 2025, 9:48 PM
DMartin-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
CodeReviewBot added a project: Patch-For-Review.Jul 30 2025, 4:38 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/423

transform: Fix handling of zero-value integers & rationals

CodeReviewBot added a comment.Jul 30 2025, 2:40 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/423

transform: Fix handling of zero-value integers & rationals

Jdforrester-WMF changed the task status from Open to In Progress.Jul 30 2025, 2:40 PM
Jdforrester-WMF assigned this task to DMartin-WMF.
Jdforrester-WMF moved this task from Ready to Ready to deploy on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2025, 3:31 PM
gerritbot added a comment.Aug 6 2025, 1:09 PM

Change #1176230 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-07-29-155618 to 2025-08-01-154925

https://gerrit.wikimedia.org/r/1176230

gerritbot added a project: Patch-For-Review.Aug 6 2025, 1:09 PM
gerritbot added a comment.Aug 6 2025, 2:03 PM

Change #1176230 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-07-29-155618 to 2025-08-01-154925

https://gerrit.wikimedia.org/r/1176230

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2025, 2:31 PM
DMartin-WMF closed this task as Resolved.Aug 11 2025, 4:57 AM
DMartin-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
DSantamaria added a project: Essential-Work.Aug 26 2025, 9:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits