Page MenuHomePhabricator
Create Task
Maniphest T400116

In Safari a broken image icon covers invisible template placeholders
Closed, ResolvedPublicBUG REPORT
Actions

Description

This seems to be because ve.ce.minImgDataUri contains a too-aggressively minimized transparent GIF, which Safari has sometime-recently decided it cannot parse.

ve.ce.minImgDataUri = 'data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==';

This applies to Safari on desktop and mobile. Chrome and Firefox both cope with this image fine.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (7fba6a44c)mediawiki/extensions/VisualEditormaster+6 -6
Use a less aggressively minimized minImgDataUriVisualEditor/VisualEditormaster+4 -3
Customize query in gerrit

Event Timeline

DLynch created this task.Jul 22 2025, 2:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2025, 2:08 AM
gerritbot added a comment.Jul 22 2025, 2:14 AM

Change #1171313 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] Use a less aggressively minimized minImgDataUri

https://gerrit.wikimedia.org/r/1171313

gerritbot added a project: Patch-For-Review.Jul 22 2025, 2:14 AM
DLynch claimed this task.Jul 22 2025, 2:15 AM
DLynch added a project: Editing-team (Kanban Board).
DLynch moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
A_smart_kitten added a project: Browser-Support-Apple-Safari.Jul 22 2025, 5:46 AM
gerritbot added a comment.Jul 30 2025, 5:42 PM

Change #1171313 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Use a less aggressively minimized minImgDataUri

https://gerrit.wikimedia.org/r/1171313

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2025, 6:30 PM
gerritbot added a comment.Jul 31 2025, 12:00 PM

Change #1174697 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d631c551e)

https://gerrit.wikimedia.org/r/1174697

gerritbot added a project: Patch-For-Review.Jul 31 2025, 12:00 PM
gerritbot added a comment.Jul 31 2025, 7:11 PM

Change #1174697 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7fba6a44c)

https://gerrit.wikimedia.org/r/1174697

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2025, 7:35 PM
DLynch added a project: Editing QA.Jul 31 2025, 7:35 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
DLynch added a comment.Jul 31 2025, 7:40 PM

Entertainingly, this turned out to also be something I did in one of my earliest patches back in 2016. Back then we grew an earlier tiny-image because of Safari getting stricter, and 9 years later Safari's strictness has continued to march on.

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Jul 31 2025, 8:00 PM
EAkinloose closed this task as Resolved.Aug 7 2025, 11:08 AM
EAkinloose edited projects, added Verified; removed Editing QA.
VPuffetMichel added a project: Essential-Work.Mon, Dec 8, 10:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits