[MEX] Align uses of snak value HTML vs snak HTML in Vue / PHP code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ArthurTaylor
	Jul 22 2025, 8:31 AM

Description

Per T396098#11020947 , we use "snakHtml" to mean two different things in the Vue / PHP code, which results in Javascript console warnings:

Inconsistent server-rendered HTML for snak with hash 3f38564928b806427a6b5654a9008e93cb73f39a:
<div class="wikibase-snakview wikibase-snakview-3f38564928b806427a6b5654a9008e93cb73f39a">
<div class="wikibase-snakview-property-container">
<div class="wikibase-snakview-property" dir="auto"><a title="Property:P280" href="/wiki1/index.php/Property:P280">lexeme property</a></div>
</div>
<div class="wikibase-snakview-value-container" dir="auto">
<div class="wikibase-snakview-typeselector"></div>
<div class="wikibase-snakview-body">
<div class="wikibase-snakview-value wikibase-snakview-variation-valuesnak"><a href="/wiki1/index.php/Lexeme:L1" title="L1: English, noun"><span lang="en">Lucas</span><span>/</span><span lang="de">Lucas</span><span>/</span><span lang="pt">Lucas</span><span>/</span><span lang="rm-puter">Lucas</span></a></div>
<div class="wikibase-snakview-indicators"></div>
</div>
</div>
</div> != <a href="/wiki1/index.php/Lexeme:L1" title="L1: English, noun"><span lang="en">Lucas</span><span>/</span><span lang="de">Lucas</span><span>/</span><span lang="pt">Lucas</span><span>/</span><span lang="rm-puter">Lucas</span></a>

We need to ensure that the snakHtml pinia store is consistently filled with the same data so that server- and client-side renderings remain consistent.

Acceptance Criteria

Javascript Console warnings are no longer emitted when rendering items that contain the same snak value in the main snak vs. in references / qualifiers (but the consistency check and console.log warning remain in place
Items render as they have been rendering

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Make propertyName component contain only non-block elements	mediawiki/extensions/Wikibase	master	+7 -11
Align uses of snak / data value HTML	mediawiki/extensions/Wikibase	master	+155 -132
Clarify SnakFormatter output	mediawiki/extensions/Wikibase	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T396098: [MEX] Format simple references
Mentioned Here: T400245: api.php on several Beta cluster wikis returns Service Temporarily Unavailable
T396098: [MEX] Format simple references

Event Timeline

ArthurTaylor created this task.Jul 22 2025, 8:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2025, 8:31 AM

ArthurTaylor moved this task from Incoming to Ready for Task Time (Story Writing) on the Wikidata-Omega board.Jul 22 2025, 8:32 AM

Lucas_Werkmeister_WMDE mentioned this in T396098: [MEX] Format simple references.Jul 22 2025, 10:20 AM

Another argument for putting data value HTML, not snak HTML, in the Pinia store: that’s the only HTML we can easily get out of the API (I think). Once we add editing support, we can get HTML for a data value using wbformatvalue (after potentially parsing it with wbparsevalue), but there’s no API module that returns HTML for a full snak AFAIK.

In principle, data values also have a hash, but I’m not sure we make that available outside of Wikibase PHP code. So I think the best way forward might still be to use data value HTML, indexed by the hash of the containing snak, just with better naming to make it less confusing.

karapayneWMDE moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Jul 22 2025, 12:11 PM

Lucas_Werkmeister_WMDE claimed this task.Jul 23 2025, 8:47 AM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

Lucas_Werkmeister_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

Hm, I might have misremembered something… Use Pinia store to stash server-rendered HTML already uses a SnakFormatter, not a ValueFormatter, to generate the main snak HTML. There’s still some mismatch, because this is different from the SnakHtmlGenerator introduced in Add Vue template for displaying references, but I don’t understand why one half of the HTML then just looks like a data value…

Could it be the second argument to getSnakHtml? I set $showPropertyLink to true...

I also don’t understand why this item doesn’t show the error. I’ll need to look more into this now that I’m hopefully done being sidetracked by T400245 ^^

In T400123#11027313, @Lucas_Werkmeister_WMDE wrote:

I also don’t understand why this item doesn’t show the error.

Ah, it needs to be in a different statement. I edited the item and now it reproduces the console warning.

In T400123#11027103, @Lucas_Werkmeister_WMDE wrote:

Hm, I might have misremembered something… Use Pinia store to stash server-rendered HTML already uses a SnakFormatter, not a ValueFormatter, to generate the main snak HTML. There’s still some mismatch, because this is different from the SnakHtmlGenerator introduced in Add Vue template for displaying references, but I don’t understand why one half of the HTML then just looks like a data value…

This is just more confusing terminology in Wikibase. The SnakFormatter interface is responsible for formatting the non-property parts of a snak, i.e. most of the time, the value (though this is also the part that formats “unknown value” and “no value” using interface messages). Then SnakHtmlGenerator wraps that to add the rest of the snak HTML, including the property link. I believe we want the SnakFormatter part.

Also, just to write it down, here’s what the SnakFormatter looks like at runtime:

An ErrorHandlingSnakFormatter wrapping a DispatchingSnakFormatter whose formattersByDataType are an HtmlExternalIdentifierFormatter for PT:external-id, and a PropertyValueSnakFormatter wrapping a DispatchingValueFormatter for everything else; the DispatchingSnakFormatter’s formattersBySnakType are two MessageSnakFormatters for novalue and somevalue; the ErrorHandlingSnakFormatter’s fallbackFormatter is a DispatchingValueFormatter

So the only special cases compared to a normal ValueFormatter are: two MessageSnakFormatters, for somevalue/novalue; and an HtmlExternalIdentifierFormatter, for formatting external identifiers whose properties have a formatter URL as hyperlinks (this can’t happen at the ValueFormatter level because the property isn’t available there).

Change #1172068 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Clarify SnakFormatter output

https://gerrit.wikimedia.org/r/1172068

Change #1172069 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Align uses of snak / data value HTML

https://gerrit.wikimedia.org/r/1172069

Change #1172068 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Clarify SnakFormatter output

https://gerrit.wikimedia.org/r/1172068

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Jul 24 2025, 8:00 AM

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Jul 25 2025, 2:09 PM

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

HasanAkgun_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.Jul 28 2025, 12:55 PM

Sorry, this isn’t ready for peer review yet – I’m still working on the first patch in the chain.

Alright, now I think it should be ready for peer review. (Might need a few more patch sets to make linters happy, we’ll see.)

HasanAkgun_WMDE claimed this task.Jul 30 2025, 9:11 AM

HasanAkgun_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

HasanAkgun_WMDE removed HasanAkgun_WMDE as the assignee of this task.Jul 30 2025, 2:01 PM

HasanAkgun_WMDE moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.

HasanAkgun_WMDE subscribed.

Lucas_Werkmeister_WMDE claimed this task.Jul 30 2025, 2:08 PM

Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to In Development on the Wikidata-Omega (The Board) board.

Change #1174478 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Make propertyName component contain only non-block elements

https://gerrit.wikimedia.org/r/1174478

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Jul 30 2025, 2:50 PM

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

Change #1172069 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Align uses of snak / data value HTML

https://gerrit.wikimedia.org/r/1172069

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.13; 2025-08-05); removed MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Jul 30 2025, 4:00 PM

ArthurTaylor claimed this task.Aug 6 2025, 11:40 AM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Aug 6 2025, 12:04 PM

ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.

Change #1174478 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make propertyName component contain only non-block elements

https://gerrit.wikimedia.org/r/1174478

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2025, 12:31 PM

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.14; 2025-08-12); removed MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Aug 6 2025, 1:00 PM

Change #1176229 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Add phpunit test for wbui2025 statement sections

https://gerrit.wikimedia.org/r/1176229

gerritbot added a project: Patch-For-Review.Aug 6 2025, 1:05 PM

karapayneWMDE closed this task as Resolved.Aug 12 2025, 7:44 AM

karapayneWMDE claimed this task.

karapayneWMDE moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).

karapayneWMDE moved this task from Newly completed tasks to 2025 Q3 on the Wikidata-Omega (Completed Tasks) board.Aug 22 2025, 7:25 AM

	F65662088: image.png
	Jul 23 2025, 2:57 PM

[MEX] Align uses of snak value HTML vs snak HTML in Vue / PHP codeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[MEX] Align uses of snak value HTML vs snak HTML in Vue / PHP code
Closed, ResolvedPublic
Actions