Timebox : 16 hrs total (~4 hr per dev, to be distributed as desired)
Suggestions include:
For Milestone 2
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T394621 [MEX] Mobile Editing Experience of Items Project | |||
| Resolved | karapayneWMDE | T394886 [MEX] M2 - Iteration 2 - Basic UI elements | |||
| Resolved | karapayneWMDE | T400178 [MEX] Code cleanup of basic UI implementation | |||
| Resolved | karapayneWMDE | T398034 [MEX] Cleanup - Replace MEX with wbui2025 | |||
| Resolved | karapayneWMDE | T399286 [MEX] Remove debug elements |
Change #1174482 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove unused show-references prop
(I’m not properly picking up this task yet, the above change is just something I noticed and thought I might as well attach to this task.)
Change #1174736 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Rename confusing variables in qualifiers and references
Change #1174737 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove outdated comment
After the above changes are reviewed, the task can go back into ready for development if anyone else has some cleanups they’d like to add… I’d say I used up 2-3 hours of the timebox so far.
Change #1174736 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename confusing variables in qualifiers and references
Change #1174737 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove outdated comment
Change #1175545 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Disable vue/no-useless-mustaches differently
Change #1175545 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Disable vue/no-useless-mustaches differently
Reviewed and merged the patches that were there. Sticking this back in Ready for Development because the timebox is not yet exhausted, but if there's nothing else to clean up we can also close this.
Change #1174482 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove unused show-references prop
FWIW I wouldn’t mind including T399286: [MEX] Remove debug elements in this (especially the statement_data_debug part), but I don’t know how you were planning to keep those elements for.
ah yeah. I guess that's pretty much outlived its usefulness at this point. I think we're on a good track without debug elements and console logs.
Change #1176712 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove unused mockConfig from wbui2025 tests
Change #1176712 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove unused mockConfig from wbui2025 tests
Change #1177962 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):
[mediawiki/extensions/Wikibase@master] Reorganize .less files and move CSS rules to respective components
Reassigning to @hoo as I think he’s done the majority of the code review on the latest patch. (Currently CI is failing with some stylelint errors, by the way.)
I think we’ve probably exhausted the timebox at this point, so let’s move this towards the “done” direction now.
Change #1177962 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reorganize .less files and move CSS rules to respective components
@HasanAkgun_WMDE I think something isn’t right with that change – the edit links are no longer blue on my local wiki (and it works again if I check out the parent commit of that change).
Change #1183087 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix edit link appearance
Change #1183087 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix edit link appearance