Page MenuHomePhabricator
Create Task
Maniphest T400280

Drop `afl_ip` as the last step of the migration to `afl_ip_hex`
Closed, ResolvedPublic
Actions

Description

From T395612: AbuseFilter abuse_filter_log table: Store IP addresses as hex values.

Pre-reqs:

Acceptance Criteria:

  • The afl_ip column is removed once the pre-reqs are completed
  • Onwiki documentation for the table is updated to reflect the removal of the column
  • A Schema-change-in-production ticket is filed to apply the schema change to WMF production - T407997

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop afl_ip from the abuse_filter_log tablemediawiki/extensions/AbuseFiltermaster+399 -28
Update PopulateAbuseFilterLogIPHex to support afl_ip being missingmediawiki/extensions/AbuseFiltermaster+67 -0
Fix abuse_filter_log index in TempUserIPLookupmediawiki/extensions/IPInfomaster+1 -1
Fix abuse_filter_log index in TempUserIPLookupmediawiki/extensions/IPInfowmf/1.45.0-wmf.23+1 -1
Fix abuse_filter_log index in TempUserIPLookupmediawiki/extensions/IPInfowmf/1.45.0-wmf.24+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

STran created this task.Jul 23 2025, 3:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2025, 3:53 PM
STran added a parent task: T395612: AbuseFilter abuse_filter_log table: Store IP addresses as hex values.Jul 23 2025, 3:54 PM
STran mentioned this in T395612: AbuseFilter abuse_filter_log table: Store IP addresses as hex values.
STran updated the task description. (Show Details)Jul 23 2025, 4:36 PM
Dreamy_Jazz added a project: Trust and Safety Product Team.Jul 23 2025, 5:00 PM
Dreamy_Jazz updated the task description. (Show Details)Jul 23 2025, 5:02 PM
Dreamy_Jazz renamed this task from Deprecate `afl_ip` as the last step of the migration to `afl_ip_hex` to Drop `afl_ip` as the last step of the migration to `afl_ip_hex`.Jul 23 2025, 5:09 PM
Dreamy_Jazz added a subtask: T400284: Stop writing to `afl_ip`.Jul 28 2025, 12:53 PM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 6 2025, 9:06 AM
Dreamy_Jazz updated the task description. (Show Details)Aug 13 2025, 8:36 AM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz added a project: OKR-Work.Aug 14 2025, 10:14 AM
Dreamy_Jazz added a project: Trust and Safety Product Sprint.
Dreamy_Jazz moved this task from Backlog to Maintenance to triage on the Trust and Safety Product Sprint board.Aug 14 2025, 10:40 AM
OKryva-WMF edited projects, added Product Safety and Integrity; removed Trust and Safety Product Sprint.Sep 26 2025, 12:55 PM
OKryva-WMF moved this task from Inbox to Next sprint on the Product Safety and Integrity board.Sep 26 2025, 12:57 PM
OKryva-WMF added a project: Essential-Work.Oct 3 2025, 2:20 PM
Dreamy_Jazz closed subtask T400284: Stop writing to `afl_ip` as Resolved.Oct 8 2025, 1:45 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz edited projects, added Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)); removed Product Safety and Integrity.Oct 8 2025, 2:27 PM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)); removed Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Trust and Safety Product Team.Oct 8 2025, 2:31 PM
Dreamy_Jazz moved this task from Backlog to Maintenance ready on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 8 2025, 2:34 PM
Dreamy_Jazz subscribed.

This can be worked on from October 20th, assuming that bd5c141add5a6e734b77fd1b0311dbbed83ca8a6 does not get reverted

OKryva-WMF moved this task from Maintenance ready to Ready on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 20 2025, 2:30 PM
Dreamy_Jazz claimed this task.Oct 21 2025, 8:38 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.
gerritbot added a comment.Oct 21 2025, 9:04 PM

Change #1197716 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/AbuseFilter@master] Drop afl_ip from the abuse_filter_log table

https://gerrit.wikimedia.org/r/1197716

gerritbot added a project: Patch-For-Review.Oct 21 2025, 9:04 PM
Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.Oct 21 2025, 9:05 PM

The two other acceptance criteria can only be done once the gerrit patch is merged

gerritbot added a comment.Oct 21 2025, 9:23 PM

Change #1197721 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/AbuseFilter@master] Update PopulateAbuseFilterLogIPHex to support afl_ip being missing

https://gerrit.wikimedia.org/r/1197721

gerritbot added a comment.Oct 22 2025, 8:53 AM

Change #1197998 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@master] Fix abuse_filter_log index in TempUserIPLookup

https://gerrit.wikimedia.org/r/1197998

gerritbot added a comment.Oct 22 2025, 10:35 AM

Change #1198017 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@wmf/1.45.0-wmf.24] Fix abuse_filter_log index in TempUserIPLookup

https://gerrit.wikimedia.org/r/1198017

gerritbot added a comment.Oct 22 2025, 10:35 AM

Change #1198018 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@wmf/1.45.0-wmf.23] Fix abuse_filter_log index in TempUserIPLookup

https://gerrit.wikimedia.org/r/1198018

gerritbot added a comment.Oct 22 2025, 10:50 AM

Change #1198017 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@wmf/1.45.0-wmf.24] Fix abuse_filter_log index in TempUserIPLookup

https://gerrit.wikimedia.org/r/1198017

gerritbot added a comment.Oct 22 2025, 10:57 AM

Change #1198018 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@wmf/1.45.0-wmf.23] Fix abuse_filter_log index in TempUserIPLookup

https://gerrit.wikimedia.org/r/1198018

Stashbot added a comment.Oct 22 2025, 10:58 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-22T10:58:32Z] <dreamyjazz@deploy2002> Started scap sync-world: Backport for [[gerrit:1198017|Fix abuse_filter_log index in TempUserIPLookup (T400280)]], [[gerrit:1198018|Fix abuse_filter_log index in TempUserIPLookup (T400280)]]

gerritbot added a comment.Oct 22 2025, 11:00 AM

Change #1197998 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fix abuse_filter_log index in TempUserIPLookup

https://gerrit.wikimedia.org/r/1197998

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 22 2025, 11:00 AM
Stashbot added a comment.Oct 22 2025, 11:03 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-22T11:03:01Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1198017|Fix abuse_filter_log index in TempUserIPLookup (T400280)]], [[gerrit:1198018|Fix abuse_filter_log index in TempUserIPLookup (T400280)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Oct 22 2025, 11:08 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-22T11:08:34Z] <dreamyjazz@deploy2002> Finished scap sync-world: Backport for [[gerrit:1198017|Fix abuse_filter_log index in TempUserIPLookup (T400280)]], [[gerrit:1198018|Fix abuse_filter_log index in TempUserIPLookup (T400280)]] (duration: 10m 01s)

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.25; 2025-10-28); removed MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 22 2025, 12:00 PM
gerritbot added a comment.Oct 22 2025, 12:01 PM

Change #1197721 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Update PopulateAbuseFilterLogIPHex to support afl_ip being missing

https://gerrit.wikimedia.org/r/1197721

gerritbot added a comment.Oct 22 2025, 12:50 PM

Change #1197716 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Drop afl_ip from the abuse_filter_log table

https://gerrit.wikimedia.org/r/1197716

Dreamy_Jazz updated the task description. (Show Details)Oct 22 2025, 1:29 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 22 2025, 1:30 PM
Dreamy_Jazz updated the task description. (Show Details)Oct 22 2025, 3:54 PM
Dreamy_Jazz closed this task as Resolved.Oct 22 2025, 4:00 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Mint Choc Chip Ice Cream (Oct 20 - Nov 7)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits