Page MenuHomePhabricator
Create Task
Maniphest T400284

Stop writing to `afl_ip`
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

As of T397941: Update code to read from afl_ip_hex, no code should reading from afl_ip therefore we should also stop writing to it.

Pre-reqs:

Acceptance Critera:

  • afl_ip is no longer updated

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove afl_ip in tests referring to AbuseFiltermediawiki/extensions/IPInfomaster+0 -8
Remove afl_ip in tests referring to AbuseFiltermediawiki/extensions/CheckUsermaster+0 -4
Stop writing afl_ipmediawiki/extensions/AbuseFiltermaster+18 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

STran created this task.Jul 23 2025, 4:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2025, 4:34 PM
STran mentioned this in T400280: Drop `afl_ip` as the last step of the migration to `afl_ip_hex`.Jul 23 2025, 4:36 PM
STran added a parent task: T395612: AbuseFilter abuse_filter_log table: Store IP addresses as hex values.
Dreamy_Jazz updated the task description. (Show Details)Jul 23 2025, 5:00 PM
Dreamy_Jazz added a project: Trust and Safety Product Team.
Dreamy_Jazz added a subtask: T397941: Update code to read from afl_ip_hex.Jul 28 2025, 12:53 PM
Dreamy_Jazz added a parent task: T400280: Drop `afl_ip` as the last step of the migration to `afl_ip_hex`.
Dreamy_Jazz added a project: Trust and Safety Product Sprint.Aug 6 2025, 8:54 AM
Dreamy_Jazz moved this task from Backlog to Maintenance to triage on the Trust and Safety Product Sprint board.
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 6 2025, 9:06 AM
Dreamy_Jazz set the point value for this task to 0.5.Aug 11 2025, 2:16 PM
OKryva-WMF edited projects, added Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)); removed Trust and Safety Product Sprint.Aug 12 2025, 4:51 PM
OKryva-WMF moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)) board.
OKryva-WMF triaged this task as High priority.Aug 12 2025, 5:01 PM
OKryva-WMF lowered the priority of this task from High to Medium.
OKryva-WMF raised the priority of this task from Medium to High.
Dreamy_Jazz claimed this task.Aug 13 2025, 8:29 AM
Dreamy_Jazz mentioned this in T401793: Add a default value for afl_ip.Aug 13 2025, 8:44 AM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)Aug 13 2025, 8:46 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint; removed Trust and Safety Product Sprint (Sprint Rum baba (July 28 - August 15)).Aug 13 2025, 9:58 AM
Dreamy_Jazz added a project: OKR-Work.Aug 14 2025, 10:14 AM
Dreamy_Jazz closed subtask T401793: Add a default value for afl_ip as Resolved.Aug 14 2025, 11:47 AM
Dreamy_Jazz updated the task description. (Show Details)Aug 18 2025, 3:11 PM
OKryva-WMF edited projects, added Product Safety and Integrity; removed Trust and Safety Product Sprint.Sep 26 2025, 12:56 PM
OKryva-WMF moved this task from Inbox to Next sprint on the Product Safety and Integrity board.Sep 26 2025, 12:57 PM
Dreamy_Jazz updated the task description. (Show Details)Sep 30 2025, 12:07 PM
OKryva-WMF added a project: Essential-Work.Oct 3 2025, 2:21 PM
Dreamy_Jazz updated the task description. (Show Details)Oct 7 2025, 1:51 PM
Dreamy_Jazz added a comment.Oct 7 2025, 2:05 PM

This is now ready to proceed

gerritbot added a comment.Oct 8 2025, 11:40 AM

Change #1194600 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/AbuseFilter@master] Stop writing afl_ip

https://gerrit.wikimedia.org/r/1194600

gerritbot added a project: Patch-For-Review.Oct 8 2025, 11:40 AM
Dreamy_Jazz reassigned this task from Dreamy_Jazz to STran.Oct 8 2025, 11:49 AM
Dreamy_Jazz edited projects, added Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)); removed Product Safety and Integrity.
Dreamy_Jazz moved this task from Priority backlog to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
Dreamy_Jazz subscribed.
gerritbot added a comment.Oct 8 2025, 12:25 PM

Change #1194614 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Remove afl_ip in tests referring to AbuseFilter

https://gerrit.wikimedia.org/r/1194614

gerritbot added a comment.Oct 8 2025, 12:26 PM

Change #1194615 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Remove afl_ip in tests referring to AbuseFilter

https://gerrit.wikimedia.org/r/1194615

gerritbot added a comment.Oct 8 2025, 1:33 PM

Change #1194600 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Stop writing afl_ip

https://gerrit.wikimedia.org/r/1194600

gerritbot added a comment.Oct 8 2025, 1:33 PM

Change #1194615 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove afl_ip in tests referring to AbuseFilter

https://gerrit.wikimedia.org/r/1194615

gerritbot added a comment.Oct 8 2025, 1:37 PM

Change #1194614 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Remove afl_ip in tests referring to AbuseFilter

https://gerrit.wikimedia.org/r/1194614

Dreamy_Jazz updated the task description. (Show Details)Oct 8 2025, 1:44 PM

The last remaining code that writes and reads to it is the PopulateAbuseFilterLogIPHex.php script which needs to still exist to allow wikis to update to the newest version

Dreamy_Jazz closed this task as Resolved.Oct 8 2025, 1:45 PM
Dreamy_Jazz moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 8 2025, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 8 2025, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits