Not adding trailing / to autoload patches breaks Parsoid CI
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Jul 23 2025, 9:22 PM

Project Tags

Referenced Files

None

Subscribers

Description

A recent change in core (autoload: Remove extra slash from autoload path when using PSR-4) stopped adding a trailing slash to the path portion of an Autoloader spec, expecting to enforce this via schema validation on extension.json instead. However, Parsoid uses a local lookaside for local development (https://www.mediawiki.org/w/index.php?title=Parsoid&diff=7766538&oldid=7732253) and in quibble in order to run integrated tests against "the latest mediawiki-core" with "the patched version of parsoid".

Quibble needs to be patched (Use trailing slash for Parsoid autoload directory) and released to CI, and apparently patchdemo needs the same fix, in order to ensure that "patched Parsoid" is used for CI. Otherwise CI tests will merrily run with the latest composer-released version of Parsoid, not the actual patch in gerrit, and we'll get false positives from CI. This is demonstrated by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1172088.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
extension.json: Add trailing slash to TestAutoloadNamespaces	mediawiki/extensions/OATHAuth	master	+1 -1
Revert^2 "autoload: Remove extra slash from autoload path when using PSR-4"	mediawiki/core	master	+24 -9
Revert "autoload: Remove extra slash from autoload path when using PSR-4"	mediawiki/core	master	+9 -24
Use trailing slash for Parsoid autoload directory	integration/quibble	master	+1 -1

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Parsoid: Add trailing slash; ensures patched Parsoid is used	repos/test-platform/catalyst/ci-charts!88	thcipriani	main-Icd9d06bc89d394e082c85afab4b600120700ba83	main
	Add trailing slash to ensure patched version of Parsoid is used	repos/test-platform/catalyst/patchdemo!184	cscott	fix-parsoid	main

Customize query in GitLab

Event Timeline

cscott created this task.Jul 23 2025, 9:22 PM

Change #1172089 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[integration/quibble@master] Use trailing slash for Parsoid autoload directory

https://gerrit.wikimedia.org/r/1172089

gerritbot added a project: Patch-For-Review.Jul 23 2025, 9:23 PM

cscott opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/184

Add trailing slash to ensure patched version of Parsoid is used

Change #1172123 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Revert "autoload: Remove extra slash from autoload path when using PSR-4"

https://gerrit.wikimedia.org/r/1172123

Change #1172123 merged by jenkins-bot:

[mediawiki/core@master] Revert "autoload: Remove extra slash from autoload path when using PSR-4"

https://gerrit.wikimedia.org/r/1172123

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Jul 24 2025, 2:00 AM

Change #1172089 merged by jenkins-bot:

[integration/quibble@master] Use trailing slash for Parsoid autoload directory

https://gerrit.wikimedia.org/r/1172089

ssastry edited projects, added: Content-Transform-Team (Work In Progress), Essential-Work; removed: Content-Transform-Team.Jul 24 2025, 2:07 PM

ssastry moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.

jhuneidi merged https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/184

Add trailing slash to ensure patched version of Parsoid is used

thcipriani updated https://gitlab.wikimedia.org/repos/test-platform/catalyst/ci-charts/-/merge_requests/88

Parsoid: Add trailing slash; ensures patched Parsoid is used

jhuneidi merged https://gitlab.wikimedia.org/repos/test-platform/catalyst/ci-charts/-/merge_requests/88

Parsoid: Add trailing slash; ensures patched Parsoid is used

thcipriani moved this task from triage to done on the Catalyst (PatchDemo) board.Jul 25 2025, 7:10 PM

MSantos moved this task from In Progress to Blocked on the Content-Transform-Team (Work In Progress) board.Aug 18 2025, 3:27 PM

MSantos edited projects, added: Release-Engineering-Team, Content-Transform-Team; removed: Content-Transform-Team (Work In Progress).Aug 18 2025, 3:30 PM

MSantos moved this task from Backlog to Tracking on the Content-Transform-Team board.

I believe all the patches have been merged, and the new version of quibble just needs to be tagged and deployed to CI now.

@cscott CI should be all set now :)

Your patch Gerrit 1172089 - Use trailing slash for Parsoid autoload directory has been released with Quibble 1.14.2 and the jobs have been switched to it on July 25th (https://gerrit.wikimedia.org/r/c/integration/config/+/1172633/).

Change #1181007 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Revert^2 "autoload: Remove extra slash from autoload path when using PSR-4"

https://gerrit.wikimedia.org/r/1181007

Ok, then it should be safe to re-apply the original patch. ^

Change #1181007 merged by jenkins-bot:

[mediawiki/core@master] Revert^2 "autoload: Remove extra slash from autoload path when using PSR-4"

https://gerrit.wikimedia.org/r/1181007

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26); removed: MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Aug 22 2025, 6:00 AM

Change #1181028 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/OATHAuth@master] extension.json: Add trailing slash to TestAutoloadNamespaces

https://gerrit.wikimedia.org/r/1181028

Tacsipacsi subscribed.Aug 22 2025, 6:46 AM

thiemowmde subscribed.Aug 22 2025, 7:10 AM

Change #1181028 merged by jenkins-bot: