Page MenuHomePhabricator

Do not mention mentors while they are away
Closed, ResolvedPublicFeature

Description

Recently, the growthexperiments-homepage-mentorship-question-disclaimer-mentor-away message has been added.
It prepends a default text to the mentorship requests redirected to another mentor while the current user's mentor is marked as away. (example: https://it.wikipedia.org/w/index.php?diff=145961742)
The default text contains a wikilink to the mentor's user page, resulting in a sent notification.

On itwiki we don't like this feature, and had to override the message. It probably would be better to either have an opt-out for the ping in the community configuration, or better, a single preference for each mentor. Thank you!

Event Timeline

In the meanwhile, it probably would be nice sending a message trough the technical newsletter, informing communities that they can override the message locally by editing MediaWiki:growthexperiments-homepage-mentorship-question-disclaimer-mentor-away and removing the links to the user page.

KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
KStoller-WMF subscribed.

Thanks for reporting this, @valcio. The intention was to link to the mentor's user page without the ping. We'll look into this ASAP.

Change #1172337 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix: avoid using wikitext that triggers ping notifications

https://gerrit.wikimedia.org/r/1172337

While the fix will be live soon, it won't be deployed on the wikis where a translation is available before next Thursday.

As a consequence, I'm editing the matching message locally. The manual fix will be using a link to the initial mentor's talk page: [[User talk:$1|$1]]'s mentor [[User talk:$2|$2]] is away.

This will be overridden when the new translation is available.

Change #1172337 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix: avoid using wikitext that triggers ping notifications

https://gerrit.wikimedia.org/r/1172337

Change #1173220 had a related patch set uploaded (by Michael Große; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.45.0-wmf.11] fix: avoid using wikitext that triggers ping notifications

https://gerrit.wikimedia.org/r/1173220

Change #1173220 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.45.0-wmf.11] fix: avoid using wikitext that triggers ping notifications

https://gerrit.wikimedia.org/r/1173220

Mentioned in SAL (#wikimedia-operations) [2025-07-28T13:40:11Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1173220|fix: avoid using wikitext that triggers ping notifications (T400369)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-28T14:04:18Z] <lucaswerkmeister-wmde@deploy1003> lucaswerkmeister-wmde, migr: Backport for [[gerrit:1173220|fix: avoid using wikitext that triggers ping notifications (T400369)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-28T14:20:04Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1173220|fix: avoid using wikitext that triggers ping notifications (T400369)]] (duration: 39m 52s)

Etonkovidova claimed this task.
Etonkovidova subscribed.

Checked on enwiki beta - works as expected, i.e. mentors with the Away status do not receive notifications.
Previously, as in the example from the task description - https://it.wikipedia.org/w/index.php?diff=145961742, the message was:

''[[User:9Aaron3|9Aaron3]], il tutor di [[User:Prozzo.parrox|Prozzo.parrox]], è assente.''

After the fix,

''Note: [[User:ET5|ET5]]'s mentor <span class="plainlinks">[{{fullurl:User:ET13}} ET13]</span> is away.''