Page MenuHomePhabricator
Create Task
Maniphest T400401

TypeError in MobileFrontend RemovableClassesTransform (PHP 8.4)
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Caused by T255586

Steps to Reproduce

  1. Navigate to the wiki’s main page, or create any page that contains HTML content, for example:
<div class="testing-task-phab-400401">
</div>
  1. Access the mobile view by visiting /w/index.php?title=Main_Page&mobileaction=toggle_view_mobile
  2. The error occurs during page rendering

Actual Results

A TypeError is thrown with the following message:

TypeError: MobileFrontend\Transforms\RemovableClassesTransform::apply(): Argument #1 ($node) must be of type DOMElement, Dom\HTMLElement given, called in extensions/MobileFrontend/includes/MobileFormatter.php on line 32

Full stack trace:

from extensions/MobileFrontend/includes/Transforms/RemovableClassesTransform.php(23) 
#0 extensions/MobileFrontend/includes/MobileFormatter.php(32): MobileFrontend\Transforms\RemovableClassesTransform->apply() 
#1 extensions/MobileFrontend/includes/ExtMobileFrontend.php(173): MobileFormatter->applyTransforms() 
#2 extensions/MobileFrontend/includes/ExtMobileFrontend.php(75): ExtMobileFrontend::domParseMobile() 
#3 extensions/MobileFrontend/includes/MobileFrontendHooks.php(357): ExtMobileFrontend::domParseWithContentProvider() 
#4 includes/HookContainer/HookContainer.php(155): MobileFrontendHooks->onOutputPageBeforeHTML() 
#5 includes/HookContainer/HookRunner.php(2783): MediaWiki\HookContainer\HookContainer->run() 
#6 includes/Output/OutputPage.php(2633): MediaWiki\HookContainer\HookRunner->onOutputPageBeforeHTML() 
#7 includes/Output/OutputPage.php(2661): MediaWiki\Output\OutputPage->addParserOutputText() 
#8 includes/page/Article.php(931): MediaWiki\Output\OutputPage->addParserOutput() 
#9 includes/page/Article.php(739): MediaWiki\Page\Article->doOutputFromParserCache() 
#10 includes/page/Article.php(551): MediaWiki\Page\Article->generateContentOutput() 
#11 includes/actions/ViewAction.php(84): MediaWiki\Page\Article->view() 
#12 includes/actions/ActionEntryPoint.php(728): MediaWiki\Actions\ViewAction->show() 
#13 includes/actions/ActionEntryPoint.php(505): MediaWiki\Actions\ActionEntryPoint->performAction() 
#14 includes/actions/ActionEntryPoint.php(143): MediaWiki\Actions\ActionEntryPoint->performRequest() 
#15 includes/MediaWikiEntryPoint.php(198): MediaWiki\Actions\ActionEntryPoint->execute() 
#16 index.php(58): MediaWiki\MediaWikiEntryPoint->run() 
#17 {main}

Expected Results

The mobile view should load normally without any TypeError, displaying the main page in mobile format.

Environment

Analysis

The error occurs because RemovableClassesTransform::apply() expects a DOMElement but receives a Dom\HTMLElement instead. This suggests a type compatibility issue, possibly related to recent changes in MediaWiki's DOM handling or PHP 8.4 compatibility.

The issue appears to be in the type of declaration mismatch between what's being passed from MobileFormatter and what RemovableClassesTransform expects to receive.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Verify DOM types against IDLeDOMmediawiki/extensions/MobileFrontendmaster+22 -2
Replace use of DOMXPath in MoveLeadParagraphTransformmediawiki/extensions/MobileFrontendmaster+38 -50
Replace use of DOMXPath in MakeSectionsTransformmediawiki/extensions/MobileFrontendmaster+5 -9
Use Parsoid DOM types to support PHP >= 8.4mediawiki/extensions/MobileFrontendmaster+114 -114
Bump wikimedia/parsoid to 0.22.0-a21mediawiki/vendormaster+26 K -23 K
Ensure that Parsoid DOM aliases are loaded before parsingmediawiki/services/parsoidmaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Danielyepezgarces created this task.Jul 24 2025, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2025, 6:19 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.4 support board.Jul 24 2025, 8:52 PM
Reedy renamed this task from TypeError in MobileFrontend RemovableClassesTransform [PHP 8.4] to TypeError in MobileFrontend RemovableClassesTransform.Jul 24 2025, 8:58 PM
Jdlrobson-WMF added a project: Reader Growth Team.Aug 20 2025, 10:58 PM
Jdlrobson-WMF subscribed.

Is this a production error at time of writing?

Danielyepezgarces added a comment.Aug 23 2025, 5:20 AM
El T400401#11104723, @Jdlrobson-WMF escribió:

Is this a production error at time of writing?

Nope, it’s only corrupted in PHP 8.4+ versions, and I already researched thoroughly that when HTML is used and the toggle to mobile is applied, or when accessing from a mobile device, as I mentioned in the description, it doesn’t work

Danielyepezgarces updated the task description. (Show Details)Aug 23 2025, 5:31 AM
Danielyepezgarces mentioned this in T402723: Allow Support for Multiple PHP Versions - Patch Demo for Testing Failures.Aug 23 2025, 5:51 PM
Jdlrobson-WMF added a subscriber: egardner.Aug 25 2025, 10:37 PM

Thanks! @egardner this sounds like this is low priority for now but will become UBN at some point in the future when we bump our PHP version so please prioritize accordingly.

bvibber merged a task: T401433: [SPIKE] Regression in MobileFrontend on new Dom\HtmlElement interfaces.Aug 26 2025, 8:11 PM
bvibber subscribed.
bvibber added a comment.Aug 26 2025, 8:14 PM

Note that in Readers Growth we've had two engineers (me and @egardner) running into this developing on Macs with PHP installed from Homebrew.

We can work around it for now by either downgrading to php-8.2, or by locally reverting ee1b1eec6c6a2439df09cc4dfc19008d00d01229 on MobileFrontend.

bvibber added subscribers: Esanders, cscott.Aug 26 2025, 9:30 PM

tagging @Esanders and @cscott as author and +2er of the breaking patch:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1156787

Jdlrobson-WMF triaged this task as High priority.Aug 27 2025, 4:18 PM
Jdlrobson-WMF moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.Aug 27 2025, 8:34 PM
Jdlrobson-WMF updated the task description. (Show Details)Aug 28 2025, 4:31 PM
gerritbot added a comment.Aug 28 2025, 5:22 PM

Change #1182901 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/MobileFrontend@master] WIP: Use Parsoid DOM types to support PHP >= 8.4

https://gerrit.wikimedia.org/r/1182901

gerritbot added a project: Patch-For-Review.Aug 28 2025, 5:22 PM
gerritbot added a comment.Aug 28 2025, 6:26 PM

Change #1182910 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/MobileFrontend@master] Replace use of DOMXPath in MakeSectionsTransform

https://gerrit.wikimedia.org/r/1182910

gerritbot added a comment.Aug 28 2025, 6:26 PM

Change #1182911 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/MobileFrontend@master] Replace DOMXPath in MoveLeadParagraphTransform

https://gerrit.wikimedia.org/r/1182911

gerritbot added a comment.Aug 28 2025, 8:19 PM

Change #1182920 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/MobileFrontend@master] Verify DOM types against IDLeDOM

https://gerrit.wikimedia.org/r/1182920

gerritbot added a comment.Aug 29 2025, 12:04 AM

Change #1182962 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Ensure that Parsoid DOM aliases are loaded before parsing

https://gerrit.wikimedia.org/r/1182962

Edtadros subscribed.Sep 2 2025, 1:25 PM

Other than the page appearing normally after load, on the client side are there any other cues that can be used to validate this once it is fixed?

Jdlrobson-WMF added a project: Content-Transform-Team.Sep 2 2025, 8:08 PM
Jdlrobson-WMF added a project: Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views).Sep 2 2025, 9:05 PM
MSantos edited projects, added MediaWiki-Engineering; removed Content-Transform-Team.Sep 4 2025, 2:12 PM
MSantos moved this task from Inbox, needs triage to MW Release Working Group on the MediaWiki-Engineering board.
Jdlrobson-WMF moved this task from Backlog to Blockers on the Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views) board.Sep 5 2025, 4:47 PM
HSwan-WMF set the point value for this task to 3.Sep 10 2025, 4:44 PM
Jdlrobson-WMF moved this task from Needs Refinement to Ready on the Reader Growth Team board.Sep 10 2025, 4:44 PM
Esanders renamed this task from TypeError in MobileFrontend RemovableClassesTransform to TypeError in MobileFrontend RemovableClassesTransform (PHP 8.4).Sep 10 2025, 5:11 PM
Jdlrobson-WMF moved this task from Untriaged to MobileFormatter on the MobileFrontend board.Sep 10 2025, 10:35 PM
Jdlrobson-WMF edited projects, added MobileFrontend (MobileFormatter); removed MobileFrontend.
gerritbot added a comment.Sep 12 2025, 1:42 AM

Change #1182962 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Ensure that Parsoid DOM aliases are loaded before parsing

https://gerrit.wikimedia.org/r/1182962

gerritbot added a comment.Sep 12 2025, 3:00 PM

Change #1187841 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a21

https://gerrit.wikimedia.org/r/1187841

gerritbot added a comment.Sep 12 2025, 3:44 PM

Change #1187841 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a21

https://gerrit.wikimedia.org/r/1187841

Danielyepezgarces added a comment.Sep 16 2025, 3:25 PM

Tested on PHP 8.4.12, works fine, anyone want to comment?

bvibber added a comment.EditedOct 2 2025, 6:29 PM

PHP 8.4.13 via homebrew still fails:

Internal error
[e8bd351877e5afbfd8425413] /w/index.php?title=Main_Page&mobileaction=toggle_view_mobile TypeError: MobileFrontend\Transforms\RemovableClassesTransform::apply(): Argument #1 ($node) must be of type DOMElement, Dom\HTMLElement given, called in /opt/homebrew/var/www/w/extensions/MobileFrontend/includes/MobileFormatter.php on line 32

Backtrace:

from /opt/homebrew/var/www/w/extensions/MobileFrontend/includes/Transforms/RemovableClassesTransform.php(23)
#0 /opt/homebrew/var/www/w/extensions/MobileFrontend/includes/MobileFormatter.php(32): MobileFrontend\Transforms\RemovableClassesTransform->apply(Dom\HTMLElement)
#1 /opt/homebrew/var/www/w/extensions/MobileFrontend/includes/ExtMobileFrontend.php(173): MobileFormatter->applyTransforms(array)
#2 /opt/homebrew/var/www/w/extensions/MobileFrontend/includes/ExtMobileFrontend.php(75): ExtMobileFrontend::domParseMobile(MediaWiki\Output\OutputPage, string)
#3 /opt/homebrew/var/www/w/extensions/MobileFrontend/includes/MobileFrontendHooks.php(356): ExtMobileFrontend::domParseWithContentProvider(MobileFrontend\ContentProviders\DefaultContentProvider, MediaWiki\Output\OutputPage, bool)
#4 /opt/homebrew/var/www/w/includes/HookContainer/HookContainer.php(155): MobileFrontendHooks->onOutputPageBeforeHTML(MediaWiki\Output\OutputPage, string)
#5 /opt/homebrew/var/www/w/includes/HookContainer/HookRunner.php(3083): MediaWiki\HookContainer\HookContainer->run(string, array)
#6 /opt/homebrew/var/www/w/includes/Output/OutputPage.php(2633): MediaWiki\HookContainer\HookRunner->onOutputPageBeforeHTML(MediaWiki\Output\OutputPage, string)
#7 /opt/homebrew/var/www/w/includes/Output/OutputPage.php(2661): MediaWiki\Output\OutputPage->addParserOutputText(string, array)
#8 /opt/homebrew/var/www/w/includes/page/Article.php(931): MediaWiki\Output\OutputPage->addParserOutput(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#9 /opt/homebrew/var/www/w/includes/page/Article.php(739): MediaWiki\Page\Article->doOutputFromParserCache(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, MediaWiki\Output\OutputPage, array)
#10 /opt/homebrew/var/www/w/includes/page/Article.php(551): MediaWiki\Page\Article->generateContentOutput(MediaWiki\User\User, MediaWiki\Parser\ParserOptions, int, MediaWiki\Output\OutputPage, array)
#11 /opt/homebrew/var/www/w/includes/actions/ViewAction.php(84): MediaWiki\Page\Article->view()
#12 /opt/homebrew/var/www/w/includes/actions/ActionEntryPoint.php(734): MediaWiki\Actions\ViewAction->show()
#13 /opt/homebrew/var/www/w/includes/actions/ActionEntryPoint.php(505): MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\Article, MediaWiki\Title\Title)
#14 /opt/homebrew/var/www/w/includes/actions/ActionEntryPoint.php(143): MediaWiki\Actions\ActionEntryPoint->performRequest()
#15 /opt/homebrew/var/www/w/includes/MediaWikiEntryPoint.php(198): MediaWiki\Actions\ActionEntryPoint->execute()
#16 /opt/homebrew/var/www/w/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#17 {main}

Main Page contains:

<strong>MediaWiki has been installed.</strong>

Consult the [https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Contents User's Guide] for information on using the wiki software.

== Getting started ==
* [https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Configuration_settings Configuration settings list]
* [https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:FAQ MediaWiki FAQ]
* [https://lists.wikimedia.org/postorius/lists/mediawiki-announce.lists.wikimedia.org/ MediaWiki release mailing list]
* [https://www.mediawiki.org/wiki/Special:MyLanguage/Localisation#Translation_resources Localise MediaWiki for your language]
* [https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Combating_spam Learn how to combat spam on your wiki]
egardner lowered the priority of this task from High to Medium.Oct 9 2025, 5:15 PM
gerritbot added a comment.Oct 15 2025, 2:19 AM

Change #1182901 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use Parsoid DOM types to support PHP >= 8.4

https://gerrit.wikimedia.org/r/1182901

gerritbot added a comment.Oct 15 2025, 2:23 AM

Change #1182910 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace use of DOMXPath in MakeSectionsTransform

https://gerrit.wikimedia.org/r/1182910

gerritbot added a comment.Oct 15 2025, 2:23 AM

Change #1182911 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Replace use of DOMXPath in MoveLeadParagraphTransform

https://gerrit.wikimedia.org/r/1182911

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).Oct 15 2025, 3:00 AM
gerritbot added a comment.Oct 17 2025, 8:12 PM

Change #1182920 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Verify DOM types against IDLeDOM

https://gerrit.wikimedia.org/r/1182920

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2025, 8:30 PM
Jdlrobson edited projects, added Content-Transform-Team; removed Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), Reader Growth Team.Oct 17 2025, 8:42 PM
Jdlrobson subscribed.

Content transform team are working on this.

cscott edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team.Oct 23 2025, 2:54 PM
cscott added a comment.Oct 23 2025, 2:57 PM

@bvibber Patches were merged, should work now?

bvibber added a comment.Oct 24 2025, 6:54 PM
In T400401#11303270, @cscott wrote:

@bvibber Patches were merged, should work now?

testing... woohoo! CONFIRMED mobile pages with offending sections now working on my Mac running macOS 15 and homebrew with PHP 8.4.14 (apache2handler)

Thanks everybody for making this fix happen; this simplifies my dev setup a lot by not having to keep a second version of PHP hacked into my web server. :D

I think we're good to resolve this task now!

cscott closed this task as Resolved.Oct 27 2025, 3:34 PM
cscott claimed this task.
cscott added a project: Essential-Work.
alistair3149 subscribed.Dec 5 2025, 11:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits