ESI test string is still shipped by CentralNotice
Closed, ResolvedPublic
Actions

Description

A string was added in T320734 for T308799: Test ESI feasibility with current Varnish installation but it has never been removed from the extension or Wikimedia's MW config even as the test has been completed and there does not seem to be any plan to carry out further tests in the near future. It should be removed to avoid shipping unnecessary bytes.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove $wgCentralNoticeESITestString	operations/mediawiki-config	master	+0 -3
	Remove $wgCentralNoticeESITestString	mediawiki/extensions/CentralNotice	master	+1 -13

Customize query in gerrit

Related Objects

Mentioned Here: T308799: Test ESI feasibility with current Varnish installation
T320734: CentralNotice: Add ESI test string to base HTML

Event Timeline

Redmin created this task.Jul 25 2025, 12:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2025, 12:48 PM

Can SRE please confirm if it can be removed?

Thanks for reporting. At least on the Traffic/CDN side, the changes were removed in T308799#9752983 where we set it to false and disabled it. I am unsure though, and can't comment on the MW-side of things though. I will leave the Traffic tag intact in case there are some lingering changes on our end.

Change #1173360 had a related patch set uploaded (by R4356thwiki; author: R4356thwiki):

[operations/mediawiki-config@master] Remove $wgCentralNoticeESITestString

https://gerrit.wikimedia.org/r/1173360

gerritbot added a project: Patch-For-Review.Jul 28 2025, 11:14 AM

Change #1173362 had a related patch set uploaded (by R4356thwiki; author: R4356thwiki):

[mediawiki/extensions/CentralNotice@master] Remove $wgCentralNoticeESITestString

https://gerrit.wikimedia.org/r/1173362

In T400472#11034815, @ssingh wrote:

Thanks for reporting. At least on the Traffic/CDN side, the changes were removed in T308799#9752983 where we set it to false and disabled it. I am unsure though, and can't comment on the MW-side of things though. I will leave the Traffic tag intact in case there are some lingering changes on our end.

Thank you. I have added patches to remove it on the MW side.

Also tagging Wikimedia-Site-requests for visibility regarding the config patch.

Redmin claimed this task.Jul 28 2025, 12:43 PM

AKanji-WMF moved this task from Triage to Blocked or not fr-tech on the Fundraising-Backlog board.Jul 28 2025, 7:52 PM

Hi @AKanji-WMF, just to be clear, this is not blocked on anything on SRE's side per @ssingh's comment above. The patch to CentralNotice can be merged when Fundraising Tech wants to. Thanks.