Page MenuHomePhabricator

Enable volunteers to configure what namespaces Edit Checks have the potential to show within
Open, Needs TriagePublic

Description

This task involves the work of introducing the ability for volunteers, on a per project basis, to configure the namespace(s) Edit Checks have the potential to show within.

Requirements

  • Enable volunteers, on a per project basis, to configure what namespace(s) Edit Checks are available within
  • Configurations can be applied to all checks via the * config group
    • AND volunteers can create exceptions,. if they choose, on a per Check basis

Acceptance Criteria

Event Timeline

Change #1172669 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: make namespaces configurable

https://gerrit.wikimedia.org/r/1172669

Change #1172670 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: allow setting of default config for all checks

https://gerrit.wikimedia.org/r/1172670

Two patches:

  • 1172669 adds namespaces to our existing config system
  • 1172670 creates a way to apply config to all checks without needing to duplicate it

Combined, we'd wind up with a MediaWiki:Editcheck-config.json that could be set up like this:

{
    "*": {
        "account": "loggedout",
        "namespaces": [ 0, 118 ]
    },
    "tone": {
        "account": "loggedin",
        "ignoreSections": ["Exaggerated claims", "Baseless speculation"],
        "maximumEditcount": 10000000
    },
}

Which says that all checks should only be shown to logged out users in the Main and Drafts namespaces, but that tone check specifically should only be shown to logged in users, raises the tone check editcount threshold so that most people will see it, and tells tone checks to be ignored in the "exaggerated claims" and "baseless speculation" sections.

Per offline discussion, we're going to hold off on merging this until the team comes to a point of view on where this configuration should live? E.g. within a centralized config file or in config files that are editable on a per project basis.

(Also, whether we want this to be configurable per-check via the config file, or just less-granularly for the entirety of edit check.)

Change #1172670 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: allow setting of default config for all checks

https://gerrit.wikimedia.org/r/1172670

Per T399973#11198496, this is out of scope for Paste Check A/B test launch. We need to revisit this as a team.

New feedback about this request, from Vietnamese Community.

Newcomers can use their user namespace to draft (not the case of T387897, which is specific). If the checks are not active in this space, moving (by renaming or copying) the draft as an article won't show the checks. The benefit of the checks for a newcomer would be lost.

Per offline discussion, we're going to hold off on merging this until the team comes to a point of view on where this configuration should live? E.g. within a centralized config file or in config files that are editable on a per project basis.

All configurations are now being local for features like these (through Community Configuration); the per-project option should be a no-brainer, right?

The connection team has used community configuration for exactly this. https://phabricator.wikimedia.org/T387966