| Sdkb | |
| Jul 26 2025, 10:02 PM |
| F71968765: Screenshot 2026-02-12 at 6.13.48 PM.png | |
| Thu, Feb 12, 11:18 PM |
| F71585390: Screenshot 2026-01-21 at 9.39.26 AM.png | |
| Wed, Jan 21, 6:04 PM |
| F71585389: Screenshot 2026-01-21 at 12.15.31 PM.png | |
| Wed, Jan 21, 6:04 PM |
| F71585387: Screenshot 2026-01-21 at 12.58.19 PM.png | |
| Wed, Jan 21, 6:04 PM |
| F65698630: Editing-Zinnia-Flower-Wikipedia-07-31-2025_05_34_PM.png | |
| Jul 31 2025, 9:35 PM |
| F37125045: Screen Shot 2023-06-30 at 3.43.06 PM.png | |
| Jul 31 2025, 6:57 AM |
Steps to replicate the issue (include links if applicable):
What happens?:
The following confirmation message appears:
"You've published an edit. Thanks and keep going"
What should have happened instead?:
Because an edit was not made in this instance, the message in this instance should be changed:
You've reviewed a suggestion. Thanks and keep going!
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix post-edit toast for declined suggestions | mediawiki/extensions/GrowthExperiments | master | +20 -19 |
Thanks for noticing and logging this task, @Sdkb!
I agree that copy is awkward.
@AAlhazwani-WMF - Any thoughts on final copy for the confirmation message when a user rejects all link suggestions?
Or something else entirely?
Has that first one been resolved? I saw "Done" rather than "Publish changes":
Oh you're right the screenshot I linked was outdated, the publish button now says "Done". But "Save your changes" and "By publishing changes..." are still going in the same direction...
@KStoller-WMF option 5. would be my pick:
as it follow the same structure of the original copy:
Has that first one been resolved? I saw "Done" rather than "Publish changes":
Oh you're right the screenshot I linked was outdated, the publish button now says "Done". But "Save your changes" and "By publishing changes..." are still going in the same direction...
agreed! we should probably file a separate task because any change to "By publishing changes..." might require a legal review. for instance, if the person is not making any change maybe it's even okay to remove that disclaimer (and the 'Review your changes' button too).
Originally the issue was reported on simple wiki desktop.
The issue seems to be present now only on mobile. Checked and confirmed the issue on the following wikis:
| simple wiki wmf.11 desktop | simple wiki wmf.11 mobile |
|---|---|
 |  |
enwiki beta
@Etonkovidova, I’m not sure if it’s just me, but the attached images aren’t displaying on my end. I also tested this on enwiki beta, and the desktop message still says “Thanks for reviewing suggestions. Keep going!” which doesn’t match the A/C for the task: “You’ve reviewed a suggestion. Thanks and keep going!” On mobile, the message is “You’ve published an edit. Thanks and keep going.” I think both views need updates?
Change #1230279 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):
[mediawiki/extensions/GrowthExperiments@master] Fix post-edit toast for declined suggestions
@Cyndymediawiksim there might be also an opportunity to standardize our workings across, may i ask you to list down the confirmation messages that we display across the growth extension?
Attached the files, sorry missed that.
Is something like that you're looking for? All Homepage messages:
https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/97c049b5d168a3129b06ce1c6c2b6c39f8cf1819/i18n/homepage/en.json#282
The message
"growthexperiments-help-panel-postedit-success-message-notsaved": "Thanks for reviewing suggestions. Keep going!"
is here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GrowthExperiments/+/97c049b5d168a3129b06ce1c6c2b6c39f8cf1819/i18n/help/en.json
thanks @Etonkovidova! looking at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GrowthExperiments/+/97c049b5d168a3129b06ce1c6c2b6c39f8cf1819/i18n/help/en.json i see we have
"growthexperiments-help-panel-postedit-success-message-published": "{{GENDER:|You've}} published an edit. Thanks and keep going!",
"growthexperiments-help-panel-postedit-success-message-saved": "{{GENDER:|You've}} saved an edit. Thanks and keep going!",
"growthexperiments-help-panel-postedit-success-message-notsaved": "Thanks for reviewing suggestions. Keep going!",hence i suggest to use the same wording as growthexperiments-help-panel-postedit-success-message-notsaved instead of what's specified in the task description
You've reviewed a suggestion. Thanks and keep going!
just checked https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1230279, and realized we're actually updating growthexperiments-help-panel-postedit-success-message-notsaved to also be aligned with the other messages. ignore my message above @Cyndymediawiksim, thank you!
@AAlhazwani-WMF , just a quick clarification: for declined suggestions, what’s the intended behavior on both mobile and desktop? Should it display a success toast message, or a notice toast message? cc: @Michael
@Cyndymediawiksim i'd say success message, because the newcomer has nonetheless - successfully - completed a review.
Change #1230279 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix post-edit toast for declined suggestions
Checked on testwiki wmf.15 - a correct message is displayed after rejecting all add link suggestions "You've reviewed a suggestion. Thanks and keep going!"
