Page MenuHomePhabricator

Keyboard shortcut for subscript same in macOS Safari for opening Safari settings
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open English Wikipedia, VisualEditor in macOS Safari
  • Press Command + [,]
  • Expect changing text to subscript per the label in the toolbar

What happens?:
Safari Settings window opens. Clash/same keyboard shortcut.

Other information (browser name/version, screenshots, etc.):
macOS Safari Version 18.5 (20621.2.5.11.8), on macOS 15.5
Documentation: Apple Safari user guide – keyboard shortcuts

When fixed, please update documentation on MediaWiki: https://www.mediawiki.org/wiki/VisualEditor/Portal/Keyboard_shortcuts.

Event Timeline

Kind of interesting that Chrome-on-macOS doesn't suffer from the same issue (I checked).

Sorry if this is not a place to discuss more about shortcuts. (I just created my account here to discover shortcut issues of VisualEditor)

On VisualEditor, I have another issue on my macbook with the shortcuts, CTRL + [0-9] because these conflict with my MacOS's shortcuts for Workspace Switch.

I was wondering if it could be possible to have an option to customize any shortcuts of VisualEditor as a preference for end-users or as a global option for administrators.

I think this custom-shortcut-setting option could provide a DIY-solution to users/administrators without involving a development process.

(If this approach makes sense, I am open to contribution to its implementing)

Kind of interesting that Chrome-on-macOS doesn't suffer from the same issue (I checked).

No, it doesn't. In fact, the shortcut COMMAND + [,] still opens Settings in Google Chrome on macOS, but smartly not when the cursor is active in an edit window.

Waddie96 renamed this task from Keyboard shortcut for subscript same in macOS Safari for opening Safari settings to VisualEdtiro: Keyboard shortcut for subscript same in macOS Safari for opening Safari settings.Aug 2 2025, 8:31 AM
Waddie96 renamed this task from VisualEdtiro: Keyboard shortcut for subscript same in macOS Safari for opening Safari settings to Keyboard shortcut for subscript same in macOS Safari for opening Safari settings.Aug 2 2025, 8:58 AM

There's so many variations with the three editors, but I also tested at https://en.wikipedia.beta.wmcloud.org/w/index.php?title=Template:Div_col_end.

Sometimes in different editors: Command + , works for subscript, Command + Shift + , works for settings, and now Command + Shift + fn + , also. But when I have the energy I'll go through them all.

Change #1175212 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/WikiEditor@master] In Safari, don't allow hotkeys to fail-to-cover system shortcuts

https://gerrit.wikimedia.org/r/1175212

This comment was removed by Nardog.

Change #1175212 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] In Safari, don't allow hotkeys to fail-to-cover system shortcuts

https://gerrit.wikimedia.org/r/1175212

Change #1175391 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorMediaWikiKeymap: Avoid `Cmd-,` in Safari

https://gerrit.wikimedia.org/r/1175391

How do I know when it's live on Beta Cluster?

As soon as a patch is merged it should be on the beta cluster.

Update documentation with changes to keyboard shortcuts:

(See Ace default keybindings: [https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts#line-operations])

  • etc.

(Do see https://en.wikipedia.org/wiki/Keyboard_shortcut#Reserved_Keyboard_Shortcuts)

  • Use ⌘ Cmd or ⌘ Command and not just Cmd or Command.

Change #1175391 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorMediaWikiKeymap: Avoid `Cmd-,` in Safari

https://gerrit.wikimedia.org/r/1175391

MusikAnimal claimed this task.