Steps to replicate the issue (include links if applicable):
What happens?:
The paragraph that your cursor was initially within is also edit checked, despite you not having made a meaningful edit to it.
What should have happened instead?:
Only the new paragraph should be checked.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T265163 Create a system to encode best practices into editing experiences | |||
| Open | None | T365300 Introduce Edit Checks that encourage behavior aligned with Manual of Style consensus | |||
| Open | None | T365301 Tone Check: Prompt people to revise promotional language | |||
| Open | None | T416406 [MILESTONE] Offer Tone Check as default-on feature (all wikis) | |||
| Open | None | T413026 [MILESTONE] Offer Tone Check as default-on feature at partner wikis | |||
| Open | ppelberg | T392954 [FY25-26] WE 1.1: Increase constructive edits | |||
| Open | MNeisler | T387918 [MILESTONE] Run an A/B test to evaluate impact of Tone Check | |||
| Resolved | BUG REPORT | DLynch | T400573 Tone check runs on adjacent paragraphs |
Change #1172879 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/VisualEditor@master] Edit check: skip collapsed ranges when computing modified content branch nodes
Patch stops splitting a paragraph from being considered a modification to both paragraphs. Arguably splitting a paragraph in the middle should perhaps count, but "splitting" a paragraph by starting a new paragraph from the beginning / end of the paragraph really shouldn't.
We'd need to reconsider this approach if we want pure deletions to count as modifications, since they'd inherently produce a collapsed range representing the place the deletion occurred.
Change #1172879 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Edit check: skip collapsed ranges when computing modified content branch nodes
Change #1173471 had a related patch set uploaded (by DLynch; author: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.11] Edit check: skip collapsed ranges when computing modified content branch nodes
Change #1173471 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.11] Edit check: skip collapsed ranges when computing modified content branch nodes
Mentioned in SAL (#wikimedia-operations) [2025-07-28T22:42:57Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1173470|Tone check: don't cause an error when the model fails]], [[gerrit:1173471|Edit check: skip collapsed ranges when computing modified content branch nodes (T400573)]]
Mentioned in SAL (#wikimedia-operations) [2025-07-28T22:45:13Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1173470|Tone check: don't cause an error when the model fails]], [[gerrit:1173471|Edit check: skip collapsed ranges when computing modified content branch nodes (T400573)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2025-07-28T22:52:32Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1173470|Tone check: don't cause an error when the model fails]], [[gerrit:1173471|Edit check: skip collapsed ranges when computing modified content branch nodes (T400573)]] (duration: 09m 31s)