Page MenuHomePhabricator

WikiEditor toolbar items don't expose their keyboard shortcuts
Closed, ResolvedPublic

Description

The toolbar items in WikiEditor have keyboard shortcuts associated with them. However, they don't include them in their title attribute so they're not particularly discoverable. For bold/italic this is fine, as those are incredibly standard in all editors ever, but most of the other shortcuts are less well known

Event Timeline

Change #1172907 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/WikiEditor@master] Allow hotkeys to be strings for e.key as well as deprecated codes

https://gerrit.wikimedia.org/r/1172907

Change #1172908 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/WikiEditor@master] Display hotkeys in the titles of toolbar elements

https://gerrit.wikimedia.org/r/1172908

Change #1172907 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Allow hotkeys to be strings for e.key as well as deprecated codes

https://gerrit.wikimedia.org/r/1172907

Change #1172908 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Display hotkeys in the titles of toolbar elements

https://gerrit.wikimedia.org/r/1172908

Draft suggestion: "The WikiEditor toolbar will now include its keyboard shortcuts in the tooltips for its items in order to improve discoverability"

I created https://www.mediawiki.org/wiki/Extension:WikiEditor/Keyboard_shortcuts which I could not find any equivalent of, which may want to be linked to.

Draft suggestion: "The WikiEditor toolbar will now include its keyboard shortcuts in the tooltips for its items in order to improve discoverability"

I created https://www.mediawiki.org/wiki/Extension:WikiEditor/Keyboard_shortcuts which I could not find any equivalent of, which may want to be linked to.

I've put them on https://www.mediawiki.org/wiki/Help:Extension:WikiEditor#Keyboard_shortcuts and then transcluded them on https://www.mediawiki.org/wiki/Extension:WikiEditor/Keyboard_shortcuts. Hope it's okay.

@Quiddity moved this task from To Triage to Announce in next Tech/News on the User-notice board.

Will this be in Tech/News for the CodeEditor with VisualEditor-MediaWiki-2017WikitextEditor only, or regarding MediaWiki-extensions-CodeMirror too? Maybe pause this until they've fixed clash of COMMAND + [,] or maybe just made a decision about it: T400569, T399295 and T400569 ? Or whichever I'm just giving my two cents.

Don't see any reason to delay it -- the general exposure of the hints is a separate matter from whether the hotkeys were wisely chosen.

(I was surprised to discover that they were only added to WikiEditor back in 2024, I'll admit.)