Page MenuHomePhabricator

VE: List defined refs in named groups are not shown when group is missing
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue

  • Create a page with this Wikitext:
<ref name="a" /> <ref name="a" group="g" />
<references>
<ref name="a">Default group content</ref>
</references>
<references group="g">
<ref name="a">Custom group content</ref>
</references>
  • Edit the page in VisualEditor

What happens?:

  • The content reference that's defined in custom group is neither visible nor editable

image.png (181×972 px, 16 KB)

What should have happened instead?:

  • The content reference that's defined in custom group is should be visible and editable
Notes

It seems that VE relies on the group attribute being present for all refs. If it's not their there will be some confusion if the content was already stored in the InternalList.

See https://gerrit.wikimedia.org/g/mediawiki/extensions/Cite/+/0981f4a0deae9f1cc4177b2144a6bc611a99c317/modules/ve-cite/ve.dm.MWReferenceNode.js#102

I did dig for a MediaWiki version where this works. So far it's not working for versions till 1.39.8 from Oktober 2022

Event Timeline

Change #1184050 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Better support LDRs that don't copy the group name

https://gerrit.wikimedia.org/r/1184050

Change #1184050 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Better support LDRs that don't copy the group name

https://gerrit.wikimedia.org/r/1184050

Change #1184782 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE Converter: Extend tests for custom list defined refs

https://gerrit.wikimedia.org/r/1184782

Change #1184782 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE Converter: Extend tests for custom list defined refs

https://gerrit.wikimedia.org/r/1184782