Refactor get_best_claim function
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Strainu
	Jul 28 2025, 12:39 PM

Description

Move get_best_claim to ItemPage and keep a wrapper in Page, per the discussion in the comments.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	get_best_claim: Move implementation to ItemPage	pywikibot/core	master	+52 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Goal	Strainu	T400608 Add high-level API for Wikidata in Pywikibot
		Resolved		Strainu	T400610 Refactor get_best_claim function

Event Timeline

Strainu created this task.Jul 28 2025, 12:39 PM

Strainu renamed this task from Add getBestValueForClaim API to Create get_best_value_for_claim function.

Strainu renamed this task from Create get_best_value_for_claim function to Create get_best_value function.

Strainu triaged this task as Low priority.

Function already existing in class Page

@Xqt , why did you choose to implement this directly in Page instead of ItemPage with a wrapper on top in Page? Is it OK if I move it?

In T400610#11040675, @Strainu wrote:

@Xqt , why did you choose to implement this directly in Page instead of ItemPage with a wrapper on top in Page? Is it OK if I move it?

Hi @Strainu, this was implemented 8 years ago for T175207 and I don’t remember the reasons why it was done on that way. Possibly you find some hints in the code reviews. Anyway any improvements are welcome and you can change the implementation in such way you proposed above.

Strainu renamed this task from Create get_best_value function to Refactor get_best_claim function.Jul 28 2025, 8:15 PM

Strainu reopened this task as Open.

Strainu updated the task description. (Show Details)

Change #1173478 had a related patch set uploaded (by Strainu; author: Strainu):

[pywikibot/core@master] get_best_claim: Move implementation to ItemPage

https://gerrit.wikimedia.org/r/1173478

gerritbot added a project: Patch-For-Review.Jul 28 2025, 9:05 PM

Strainu moved this task from Backlog to Needs Review on the Pywikibot board.Jul 31 2025, 4:24 PM

Change #1173478 merged by jenkins-bot:

[pywikibot/core@master] get_best_claim: Move implementation to ItemPage

https://gerrit.wikimedia.org/r/1173478

Xqt closed this task as Resolved.Aug 3 2025, 2:00 PM