Page MenuHomePhabricator
Create Task
Maniphest T400657

Consider not awaiting the secondary memcached population Promise
Closed, InvalidPublic
Actions

Description

Description

See the relevant TODO tagged with this task's ID in src/fetchObject.js.

Notionally, it's unnecesary to await this Promise, but not awaiting it makes things hard to test and is possibly causing memory issues by delaying garbage collection (unawaited Promises can hang around in a deprioritized part of the garbage collector).

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • don't await the Promise, but DO thoroughly test it and ensure it doesn't cause memory leaks

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Related Objects

Event Timeline

cmassaro created this task.Jul 28 2025, 9:28 PM
Jdforrester-WMF triaged this task as High priority.Jul 30 2025, 3:43 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

Risk of memory leak, but also speed concerns.

Jdforrester-WMF lowered the priority of this task from High to Medium.May 13 2026, 8:15 PM

Re-prioritising to Medium during an Engineering Backlog triage. The work is concrete and well-bounded: drop the await on the secondary memcached population Promise in src/fetchObject.js (there's an in-code TODO tagged with this task ID), verify it doesn't introduce a memory leak via unreaped Promises, verify it doesn't degrade test observability past acceptable. But 9 months without movement says High wasn't driving action; Medium is the honest signal. Cross-reference: T395064 ("Improve the memcached concurrency treatment", still High in this triage pass) is in the same neighbourhood — whoever picks up this card should look at that one too, since the await-vs-fire-and-forget decision interacts with the concurrency model.

cmassaro added a comment.Jul 29 2026, 10:30 PM

We are now using setDefinitionForSync, so there is no longer a Promise to await (or not await, as it were). Recommending that this be closed.

cmassaro edited projects, added: Abstract Wikipedia team (27Q1 (Jul–Sep)); removed: Abstract Wikipedia team.Jul 29 2026, 10:30 PM
cmassaro moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.
Jdforrester-WMF closed this task as Invalid.Jul 30 2026, 8:50 AM

Agreed!

DSantamaria added a project: Essential-Work.Aug 3 2026, 4:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits