Page MenuHomePhabricator

Consider not awaiting the secondary memcached population Promise
Open, HighPublic

Description

Description

See the relevant TODO tagged with this task's ID in src/fetchObject.js.

Notionally, it's unnecesary to await this Promise, but not awaiting it makes things hard to test and is possibly causing memory issues by delaying garbage collection (unawaited Promises can hang around in a deprioritized part of the garbage collector).

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • don't await the Promise, but DO thoroughly test it and ensure it doesn't cause memory leaks

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task


Completion checklist

Event Timeline

Jdforrester-WMF subscribed.

Risk of memory leak, but also speed concerns.