Page MenuHomePhabricator

set AutoModeratorMultiLingualRevertRisk with available wikis
Closed, ResolvedPublic3 Estimated Story Points

Description

In the parent task, we did all of the plumbing for enabling the multilingual model, but we never flipped the switch to make it available. Lets do that.

Acceptance Criteria

This can be done either by setting the default in extension.json or by setting the value in the mediawiki-config repository

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Scardenasmolinar moved this task from In Progress to Ready on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar subscribed.

It appears that there are non-trivial errors in the configuration that require further investigation. I am unassigning myself and moving this back to Ready.

Change #1188447 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1188447

The size of the patch looks larger than it is, but unfortunately it's still a rather large patch so very thorough testing is much appreciated.
I tried to shrink it down as much as I could, but the nature of this the change requires touching a lot of files.

I have tested this with the following flows locally:

  • A wiki that is in the AutoModeratorMultiLingualRevertRisk config value,
    • I enabled Multilingual model for both ORES and Liftwing flows; I ensured the url was correct in the Liftwing flow and that the ORES model is correct for ORES flow.
    • I enabled Language Agnostic model for both ORES and Liftwing flows; I ensured the url was correct in the Liftwing flow and that the ORES model is correct for ORES flow. (I also ensured it was using the caution levels from the multilingual config page).
    • I disabled the check on multilingual config; I ensured the job did not run.
    • I updated various combinations of multilingual configuration and ensured that the appropriate values were being used.
    • I validated that the correct configuration form is linked from the Special:CommunityConfiguration screen.
  • A wiki that is not in the AutoModeratorMultiLingualRevertRisk config value
    • I validated that the correct configuration form is linked from the Special:CommunityConfiguration screen.
    • I validated that multilingual config page is not available.
    • I smoke tested AutoModerator flows using the original configuration form/json.

Note: The way I have currently refactored this is that it's using ALL of the configuration on the multilingual config page if the wiki is a multilingual wiki regardless of the status of the language agnostic setting or not. I made the assumption given how the configuration was being loaded that was how we originally intended it to be, but please correct me if I'm wrong.

Adding this question here in addition to the code review: should we work on and merge T404360: Adjust Automoderator's multilingual model acceptable threshold range from minimum 0.95 to 0.85 before we merge this?

I have reviewed the patch and QAed it with different scenarios, and everything looks to be working as intended.

The way I have currently refactored this is that it's using ALL of the configuration on the multilingual config page if the wiki is a multilingual wiki regardless of the status of the language agnostic setting or not. I made the assumption given how the configuration was being loaded that was how we originally intended it to be, but please correct me if I'm wrong.

I think this is the correct approach. I missed changing some of the configurations to reflect that. Thanks for catching that error.

A couple of quick questions to remind me how this works:

  • For multilingual wikis, do they have the option of which model to use, or do we just show them the multilingual form?
  • What will happen on wikis currently using language-agnostic when this rolls out? Will their implementation still work, and then they can switch?

A couple of quick questions to remind me how this works:

  • For multilingual wikis, do they have the option of which model to use, or do we just show them the multilingual form?

Yes! They can configure the language agnostic using the same form that they would use for multilingual.

  • What will happen on wikis currently using language-agnostic when this rolls out? Will their implementation still work, and then they can switch?

Once this rolls out, it will use the defaults that are in the multilingual form until they're updated via community configuration. We'll definitely need to communicate that to the wikis.
Another thing that will happen on these wikis is that there will be a leftover AutoModeratorConfig.json page, but it will have no effect on the behavior as the app will be looking at the multilingual config form.

Katy helpfully ran me through how this works and I have some thoughts and questions:

  • On multilingual wikis the form is at Special:CommunityConfiguration/MultilingualConfig, whereas it's at /AutoModerator for language-agnostic wikis. Is there any way we could have this at /AutoModerator in both cases?
  • For the model selectors we should change "is turned on" to something that doesn't match the "Automoderator is turned on" text at the top, to avoid confusion with selecting a model but not having it on overall. Perhaps we could use something like "select(ed)". I forget what the full current text is now or I'd suggest something more specific.
  • When entering an invalid multilingual threshold the error message says "The value is outside the range" which is confusing, because it's not clear what value this is referring to. We could change this to "The Multilingual model threshold value is outside the allowable range".
  • I filed a separate ticket for T404880: Automoderator config form error message should clarify that error message is an error message (not blocking for this task)
  • For wikis using language-agnostic, when we deploy this patch, will Automoderator continue running on those wikis without intervention (if so with which model?) or will it stop until they set up & enable the new form?

Other notes:

  • We need to write a message/guide on how to migrate to multilingual for wikis currently using language-agnostic. Users can't just copy the .json config over, so they'll need to set it up again. The old form will be gone, but the .json will still be there, to cross-reference their old config. We should not merge this patch until we have prepared this comms.

Katy helpfully ran me through how this works and I have some thoughts and questions:

  • On multilingual wikis the form is at Special:CommunityConfiguration/MultilingualConfig, whereas it's at /AutoModerator for language-agnostic wikis. Is there any way we could have this at /AutoModerator in both cases?

The name we call the provider in the extension.json appears to be what the URL uses on Special:CommunityConfiguration.
Because it's not possible to have multiple providers with the same name, having them both be the same URL isn't possible. I can file a feature request to decouple the url from the provider id with the growth team, just let me know!

  • For wikis using language-agnostic, when we deploy this patch, will Automoderator continue running on those wikis without intervention (if so with which model?) or will it stop until they set up & enable the new form?

I tested this locally and it will set the multilingual config to what is in the extension.json. The default value there is that the model is disabled, so we'll need to setup the new form and enable it as part of this rollout.

Katy helpfully ran me through how this works and I have some thoughts and questions:

  • On multilingual wikis the form is at Special:CommunityConfiguration/MultilingualConfig, whereas it's at /AutoModerator for language-agnostic wikis. Is there any way we could have this at /AutoModerator in both cases?

The name we call the provider in the extension.json appears to be what the URL uses on Special:CommunityConfiguration.
Because it's not possible to have multiple providers with the same name, having them both be the same URL isn't possible. I can file a feature request to decouple the url from the provider id with the growth team, just let me know!

Let's file it and see what they think!

  • For wikis using language-agnostic, when we deploy this patch, will Automoderator continue running on those wikis without intervention (if so with which model?) or will it stop until they set up & enable the new form?

I tested this locally and it will set the multilingual config to what is in the extension.json. The default value there is that the model is disabled, so we'll need to setup the new form and enable it as part of this rollout.

OK - we definitely need to notify wikis in advance in this case.

At RTL today we discussed renaming the provider from MultilingualConfig to AutomoderatorMultilingual to clarify the scope of the config.

Change #1181219 abandoned by Scardenasmolinar:

[mediawiki/extensions/AutoModerator@master] Add all compatible wikis to AutoModeratorMultilingualRevertRisk

Reason:

Abandoned in favor of I546832e50c6bf276d126de59a3bc8ff79ceecbbe

https://gerrit.wikimedia.org/r/1181219

Kgraessle changed the task status from In Progress to Open.Sep 29 2025, 4:56 PM

This is ready for review, except for the db list which will be moved to config. TBD on the process for doing that.

Change #1192907 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[operations/mediawiki-config@master] set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1192907

Change #1192907 abandoned by Kgraessle:

[operations/mediawiki-config@master] set AutoModeratorMultiLingualRevertRisk with available wikis

Reason:

refactor

https://gerrit.wikimedia.org/r/1192907

Change #1192956 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[operations/mediawiki-config@master] Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1192956

Change #1192956 merged by jenkins-bot:

[operations/mediawiki-config@master] Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1192956

Mentioned in SAL (#wikimedia-operations) [2025-10-23T20:16:28Z] <jsn@deploy2002> Started scap sync-world: Backport for [[gerrit:1192956|Set AutoModeratorMultiLingualRevertRisk with available wikis (T400727)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-23T20:20:37Z] <jsn@deploy2002> jsn, kgraessle: Backport for [[gerrit:1192956|Set AutoModeratorMultiLingualRevertRisk with available wikis (T400727)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Change #1188447 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1188447

Samwalton9-WMF changed the task status from Open to Stalled.Oct 28 2025, 5:11 PM

Moving this to waiting for changes in order to get the rebased patch going.

Noting that we're aiming for Wednesday November 19th. I'll aim to post comms about the change by the end of this week.

Change #1203498 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[operations/mediawiki-config@master] Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1203498

Kgraessle changed the task status from Stalled to Open.Nov 17 2025, 4:22 PM

Okay, this change did not roll out as planned last week; the issue is that we were including large wikis as part of the initial rollout. We've been directed to split it up into stages and do large wikis after the rest. We'll need to regroup and make a new plan, get back on the schedule, and let the impacted communities know.

Punting this to January to avoid December deployment freezes/time out.

Samwalton9-WMF changed the task status from Open to Stalled.Dec 9 2025, 11:10 AM
Samwalton9-WMF moved this task from Inbox to Estimated on the Moderator-Tools-Team board.
Samwalton9-WMF changed the task status from Stalled to Open.Feb 10 2026, 5:12 PM

Change #1247639 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[operations/mediawiki-config@master] Enable rr-ml AutoModerator CC Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1247639

@Ladsgroup

Hi, just wanted to check in with you and make sure the updated patch which enables only wikis where AutoModerator is already deployed works for you? We were wanting to deploy this next Wednesday if possible.
Thanks!

Kgraessle changed the task status from Open to Stalled.Mar 6 2026, 1:08 PM

Change #1247639 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable rr-ml AutoModerator CC Set AutoModeratorMultiLingualRevertRisk with available wikis

https://gerrit.wikimedia.org/r/1247639

Mentioned in SAL (#wikimedia-operations) [2026-03-11T07:09:48Z] <kgraessle@deploy2002> Started scap sync-world: Backport for [[gerrit:rGTWN1247639ed402|Enable rr-ml AutoModerator CC Set AutoModeratorMultiLingualRevertRisk with available wikis (T400727)]]

Mentioned in SAL (#wikimedia-operations) [2026-03-11T07:12:01Z] <kgraessle@deploy2002> kgraessle: Backport for [[gerrit:rGTWN1247639ed402|Enable rr-ml AutoModerator CC Set AutoModeratorMultiLingualRevertRisk with available wikis (T400727)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-03-11T07:22:12Z] <kgraessle@deploy2002> Finished scap sync-world: Backport for [[gerrit:rGTWN1247639ed402|Enable rr-ml AutoModerator CC Set AutoModeratorMultiLingualRevertRisk with available wikis (T400727)]] (duration: 12m 24s)

Kgraessle changed the task status from Stalled to Open.Mar 11 2026, 7:33 AM
Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.

Change #1203498 abandoned by Kgraessle:

[operations/mediawiki-config@master] Enable rr-ml AutoModerator CC form on !large wikis Set AutoModeratorMultiLingualRevertRisk with available wikis

Reason:

Abandoned in favor of different approach

https://gerrit.wikimedia.org/r/1203498

Wikis supporting multilingual now have their multilingual config page and options as expected. bn.wiki is the only wiki to have switched over to multilingual so far, though note that per T419835, this is currently broken.

Scardenasmolinar changed the task status from Open to Stalled.Tue, Apr 21, 4:06 PM