Page MenuHomePhabricator
Create Task
Maniphest T400765

email update process for recurring PayPal donors: issue + question
Closed, ResolvedPublic
Actions

Description

Yamini found a recurring PayPal donor CID 8163224 whose donations continued to reach Civi under their old email address, even after they changed their email address at PayPal. The June and July donations, 9X837550BY874902E and 40F59210D9592642T, show a different email address at PayPal than the one in the CID.

This is different than what we expect to happen, which is that Civi will pick up the new email address when it is changed by the donor at their PayPal account. At the meeting today, @Ejegg confirmed that PayPal is sending the new email address, and also cautioned that the process of moving off of Drupal may expose some unusual effects from old custom code.

This Task is to request that Civi ingest the newly updated email addresses from PayPal, but also to raise the question of what the list of rules is for for email changes for recurring donations.

Email changes source from:

  • the email preference center T401006
  • donors at their Paypal account
  • staff agents in Civi

Can we make sure that the same rules apply to email address updates regardless of the source of the change? Will the rules be agnostic across payment methods?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update wording to indicate the external_identifier used for venmo and paypal payer idmediawiki/extensions/DonationInterfacemaster+1 -2
map paypal payer id from gravy to civiwikimedia/fundraising/SmashPigmaster+4 -1
Add payer id to message queue as external_identifiermediawiki/extensions/DonationInterfacemaster+11 -0
Add paypal payer id if paypal from queue to civiwikimedia/fundraising/crmmaster+2 -1
add paypay payer id for gravy paypalwikimedia/fundraising/crmmaster+7 -0
add paypal payer id in external identifier table for paypalwikimedia/fundraising/crmmaster+10 -0
Customize query in gerrit

Related Objects

Event Timeline

MBeat33 created this task.Jul 29 2025, 10:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2025, 10:19 PM
AnnWF updated the task description. (Show Details)Aug 4 2025, 8:16 PM
greg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Aug 4 2025, 8:28 PM
Damilare added a project: Fundraising Sprint: Pirate's Booty.Aug 12 2025, 7:50 PM
AKanji-WMF mentioned this in T402571: Fundraising Sprint Q - Priorities.Aug 26 2025, 6:45 PM
AKanji-WMF edited projects, added Fundraising Sprint: Queuesadilla; removed Fundraising Sprint: Pirate's Booty.Aug 26 2025, 6:52 PM
AKanji-WMF added a project: fr-current-sprint.Sep 4 2025, 1:41 PM
AKanji-WMF edited projects, added Fundraising Sprint: rich, the; removed Fundraising Sprint: Queuesadilla.Sep 9 2025, 8:59 PM
AnnWF claimed this task.Sep 11 2025, 4:09 PM
AnnWF moved this task from Backlog to Doing on the Fundraising Sprint: rich, the board.
MBeat33 added a comment.Sep 23 2025, 2:13 PM

Seilo and Kris found another, cid=8804442 has a recurring created on October 10th, 2021 and the email addresses don’t match between PayPal and Civi - Civi is not pulling in the updated email.

AKanji-WMF edited projects, added Fundraising Sprint: Spaghetti code and makefiles; removed Fundraising Sprint: rich, the.Sep 23 2025, 7:58 PM
AnnWF moved this task from Backlog to Ready for Review on the Fundraising Sprint: Spaghetti code and makefiles board.Sep 23 2025, 10:04 PM
AnnWF moved this task from Ready for Review to Doing on the Fundraising Sprint: Spaghetti code and makefiles board.
AnnWF added a comment.EditedOct 1 2025, 3:52 PM

The solution for avoid creating new email for paypal donor:

  • We disable the update primary email from email preference center if donor have active recurring paypal T401006
  • Update the logic for consume new donation that if any home address of email matched paypal, do not create a new contact but use the oldest cid T404154
  • Add a logic for recurring donation with third-party ( paypal ec in this case ) if payer_email not match the contrition add to cid as secondary email address (add new email type like paypal email venmo email google email apple email and so on)
  • Check if we have way to add payer_id as external id and map them
gerritbot added a comment.Oct 3 2025, 12:47 AM

Change #1193274 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] add paypal payer id in external identifier table for paypal

https://gerrit.wikimedia.org/r/1193274

gerritbot added a project: Patch-For-Review.Oct 3 2025, 12:47 AM
AKanji-WMF edited projects, added Fundraising Sprint: Temp file pura; removed Fundraising Sprint: Spaghetti code and makefiles.Oct 7 2025, 8:13 PM
AKanji-WMF moved this task from Backlog to Doing on the Fundraising Sprint: Temp file pura board.
gerritbot added a comment.Oct 9 2025, 1:45 PM

Change #1193274 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] add paypal payer id in external identifier table for paypal

https://gerrit.wikimedia.org/r/1193274

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2025, 2:31 PM
Lars mentioned this in T407261: Send double opt-in confirmation message whenever a contact's email is changed.Oct 16 2025, 5:58 PM
AKanji-WMF edited projects, added Fundraising Sprint: UTM_key lime pie; removed Fundraising Sprint: Temp file pura.Oct 21 2025, 8:19 PM
AKanji-WMF moved this task from Backlog to Doing on the Fundraising Sprint: UTM_key lime pie board.
AKanji-WMF edited projects, added Fundraising Sprint: Vixen; removed Fundraising Sprint: UTM_key lime pie.Nov 4 2025, 9:21 PM
AKanji-WMF moved this task from Backlog to Doing on the Fundraising Sprint: Vixen board.
XenoRyet added a project: Fundraising Sprint WWaally hoo.Nov 18 2025, 8:50 PM
AnnWF moved this task from Backlog to Doing on the Fundraising Sprint WWaally hoo board.Nov 18 2025, 10:22 PM
AnnWF added a comment.EditedNov 19 2025, 6:31 PM

Gravy need time to estimate when they will post payerid for us, so blocked as non fr-tech.
https://docs.google.com/spreadsheets/d/117qd1q2wEGjjP1FtkOkO4RHGu6cYN_Eh9l0kVtAC2qo/edit?pli=1&gid=2057873236#gid=2057873236 line 9

AnnWF moved this task from Doing to Blocked in Sprint (not fr-tech) on the Fundraising Sprint WWaally hoo board.Nov 19 2025, 6:31 PM
AKanji-WMF edited projects, added Fundraising Sprint: Xiaolongbao; removed Fundraising Sprint WWaally hoo.Dec 2 2025, 8:59 PM
AnnWF moved this task from Backlog to Blocked in Sprint (not fr-tech) on the Fundraising Sprint: Xiaolongbao board.Dec 2 2025, 9:19 PM
AnnWF moved this task from Blocked in Sprint (not fr-tech) to Doing on the Fundraising Sprint: Xiaolongbao board.Dec 5 2025, 7:47 PM
AnnWF moved this task from Doing to Blocked in Sprint (not fr-tech) on the Fundraising Sprint: Xiaolongbao board.Dec 5 2025, 11:31 PM

ask if gravy can add payer[‘payer_id’] from auth response add to capture response?
"payment_method": {

  "type": "payment-method",
  "approval_url": null,
  "country": "US",
  "currency": "USD",
  "details": null,
  "expiration_date": null,
  "fingerprint": null,
  "label": "xxx@xxx.com",
  "last_replaced_at": null,
  "method": "paypal",
  "mode": "redirect",
  "scheme": null,
  "id": null,
  "approval_target": null,
  "external_identifier": <PAYPAL PAYERID>,
  "payment_account_reference": null
}
AKanji-WMF edited projects, added Fundraising Sprint: Yabba Dabba Stew; removed Fundraising Sprint: Xiaolongbao.Dec 16 2025, 8:33 PM
AKanji-WMF moved this task from Backlog to Blocked in Sprint (not fr-tech) on the Fundraising Sprint: Yabba Dabba Stew board.
gerritbot added a comment.Jan 1 2026, 3:23 AM

Change #1222299 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] add paypay payer id for gravy paypal

https://gerrit.wikimedia.org/r/1222299

gerritbot added a project: Patch-For-Review.Jan 1 2026, 3:23 AM
gerritbot added a comment.Jan 1 2026, 3:32 AM

Change #1222300 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] WIP: map paypal payer id from gravy to civi

https://gerrit.wikimedia.org/r/1222300

gerritbot added a comment.Jan 2 2026, 12:05 AM

Change #1222299 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] add paypay payer id for gravy paypal

https://gerrit.wikimedia.org/r/1222299

AnnWF moved this task from Blocked in Sprint (not fr-tech) to Doing on the Fundraising Sprint: Yabba Dabba Stew board.Jan 6 2026, 6:52 PM
gerritbot added a comment.Jan 7 2026, 11:49 PM

Change #1224231 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Add payer id to message queue as external_identifier

https://gerrit.wikimedia.org/r/1224231

gerritbot added a comment.Jan 8 2026, 12:51 AM

Change #1224248 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Add paypal payer id if paypal from queue to civi

https://gerrit.wikimedia.org/r/1224248

gerritbot added a comment.Jan 8 2026, 2:11 AM

Change #1224248 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add paypal payer id if paypal from queue to civi

https://gerrit.wikimedia.org/r/1224248

AnnWF moved this task from Doing to Ready for Review on the Fundraising Sprint: Yabba Dabba Stew board.Jan 8 2026, 6:53 PM
AKanji-WMF edited projects, added Fundraising Sprint: ARMchair; removed Fundraising Sprint: Yabba Dabba Stew.Jan 13 2026, 9:35 PM
AnnWF moved this task from Backlog to Ready for Review on the Fundraising Sprint: ARMchair board.Jan 13 2026, 9:46 PM
AnnWF added a comment.Tue, Jan 20, 9:19 PM
In T400765#11437846, @AnnWF wrote:

ask if gravy can add payer[‘payer_id’] from auth response add to capture response?
"payment_method": {

  "type": "payment-method",
  "approval_url": null,
  "country": "US",
  "currency": "USD",
  "details": null,
  "expiration_date": null,
  "fingerprint": null,
  "label": "xxx@xxx.com",
  "last_replaced_at": null,
  "method": "paypal",
  "mode": "redirect",
  "scheme": null,
  "id": null,
  "approval_target": null,
  "external_identifier": <PAYPAL PAYERID>,
  "payment_account_reference": null
}

On Jan19th, gravy released the payer id added to additional_identifiers as payer_id in both auth and capture

gerritbot added a comment.Mon, Jan 26, 6:50 PM

Change #1224231 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add payer id to message queue as external_identifier

https://gerrit.wikimedia.org/r/1224231

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.13; 2026-01-27).Mon, Jan 26, 7:00 PM
gerritbot added a comment.Mon, Jan 26, 7:28 PM

Change #1233252 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Update wording to indicate the external_identifier used for venmo and paypal payer id

https://gerrit.wikimedia.org/r/1233252

AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint: ARMchair board.Mon, Jan 26, 8:49 PM
gerritbot added a comment.Tue, Jan 27, 1:54 AM

Change #1222300 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] map paypal payer id from gravy to civi

https://gerrit.wikimedia.org/r/1222300

AnnWF moved this task from Being Reviewed to Pending Deployment on the Fundraising Sprint: ARMchair board.Tue, Jan 27, 2:19 AM
Damilare added a project: Fundraising Sprint: Ball pit.Tue, Jan 27, 9:10 PM
Damilare removed a project: Fundraising Sprint: ARMchair.Tue, Jan 27, 9:13 PM
AnnWF moved this task from Backlog to Doing on the Fundraising Sprint: Ball pit board.Tue, Jan 27, 10:58 PM
AnnWF moved this task from Doing to Pending Deployment on the Fundraising Sprint: Ball pit board.
AnnWF moved this task from Pending Deployment to Done on the Fundraising Sprint: Ball pit board.Fri, Jan 30, 12:56 AM
Lars moved this task from Backlog to Bug Reports on the FR-donorrelations board.Tue, Feb 3, 6:58 PM
XenoRyet closed this task as Resolved.Mon, Feb 9, 8:59 PM
XenoRyet set Final Story Points to 8.
gerritbot added a comment.Mon, Feb 9, 10:00 PM

Change #1233252 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Update wording to indicate the external_identifier used for venmo and paypal payer id

https://gerrit.wikimedia.org/r/1233252

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.15; 2026-02-10); removed MW-1.46-notes (1.46.0-wmf.13; 2026-01-27).Mon, Feb 9, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, Feb 9, 10:31 PM
Damilare mentioned this in T415719: Fundraising Sprint B Priorities.Tue, Feb 10, 3:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits