Page MenuHomePhabricator
Create Task
Maniphest T400905

Refactor EditCheck gutter markers into SelectionManager
Closed, ResolvedPublic
Actions

Description

#drawGutter is doing a bunch of work we already do in SelectionManager:

  • measuring selection rectangles
  • appending them to the selection overlay
  • updating when the browser resizes

SelectionManager#drawSelections now has various options (showRects/showBounding/showCursor) to which we could add showGutter.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Edit check: selectionmanager/gutter merge follow-upsmediawiki/extensions/VisualEditorwmf/1.45.0-wmf.14+13 -6
Edit check: selectionmanager/gutter merge follow-upsmediawiki/extensions/VisualEditormaster+13 -6
EditCheck: Use core support for gutter highlightsmediawiki/extensions/VisualEditormaster+117 -150
Update VE core submodule to master (21ae6b49e)mediawiki/extensions/VisualEditormaster+1 -1
SelectionManager: Add a showGutter optionVisualEditor/VisualEditormaster+23 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 31 2025, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2025, 2:49 PM
gerritbot added a comment.Jul 31 2025, 4:45 PM

Change #1174764 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] SelectionManager: Add a showGutter option

https://gerrit.wikimedia.org/r/1174764

gerritbot added a project: Patch-For-Review.Jul 31 2025, 4:45 PM
gerritbot added a comment.Jul 31 2025, 5:10 PM

Change #1174771 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Use core support for gutter highlights

https://gerrit.wikimedia.org/r/1174771

Esanders claimed this task.Jul 31 2025, 5:10 PM
Esanders added a project: Editing-team (Kanban Board).
gerritbot added a comment.Aug 1 2025, 9:58 AM

Change #1174764 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] SelectionManager: Add a showGutter option

https://gerrit.wikimedia.org/r/1174764

gerritbot added a comment.Aug 1 2025, 11:53 AM

Change #1175082 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (21ae6b49e)

https://gerrit.wikimedia.org/r/1175082

gerritbot added a comment.Aug 1 2025, 12:14 PM

Change #1175082 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (21ae6b49e)

https://gerrit.wikimedia.org/r/1175082

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Aug 1 2025, 1:00 PM
gerritbot added a comment.Aug 7 2025, 4:40 AM

Change #1174771 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Use core support for gutter highlights

https://gerrit.wikimedia.org/r/1174771

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.14; 2025-08-12); removed MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Aug 7 2025, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 7 2025, 5:30 AM
gerritbot added a comment.Aug 13 2025, 5:11 AM

Change #1178168 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: clear final selection

https://gerrit.wikimedia.org/r/1178168

gerritbot added a project: Patch-For-Review.Aug 13 2025, 5:11 AM
gerritbot added a comment.Aug 13 2025, 7:10 AM

Change #1178168 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: selectionmanager/gutter merge follow-ups

https://gerrit.wikimedia.org/r/1178168

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2025, 7:30 AM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.15; 2025-08-19); removed MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 13 2025, 8:00 AM
gerritbot added a comment.Aug 13 2025, 2:37 PM

Change #1178558 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.14] Edit check: selectionmanager/gutter merge follow-ups

https://gerrit.wikimedia.org/r/1178558

gerritbot added a project: Patch-For-Review.Aug 13 2025, 2:37 PM
Esanders moved this task from Inbox to QA on the Editing-team (Kanban Board) board.Aug 13 2025, 6:08 PM
Esanders added a project: Editing QA.

The expected behaviour is just that EditCheck highlights continue to work as before.

Esanders moved this task from Inbox to Low Priority on the Editing QA board.Aug 13 2025, 6:08 PM
gerritbot added a comment.Aug 13 2025, 8:03 PM

Change #1178558 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.14] Edit check: selectionmanager/gutter merge follow-ups

https://gerrit.wikimedia.org/r/1178558

Stashbot added a comment.Aug 13 2025, 8:03 PM

Mentioned in SAL (#wikimedia-operations) [2025-08-13T20:03:46Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1178558|Edit check: selectionmanager/gutter merge follow-ups (T400905)]]

Stashbot added a comment.Aug 13 2025, 8:05 PM

Mentioned in SAL (#wikimedia-operations) [2025-08-13T20:05:51Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1178558|Edit check: selectionmanager/gutter merge follow-ups (T400905)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Aug 13 2025, 8:13 PM

Mentioned in SAL (#wikimedia-operations) [2025-08-13T20:13:03Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1178558|Edit check: selectionmanager/gutter merge follow-ups (T400905)]] (duration: 09m 17s)

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2025, 8:30 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.14; 2025-08-12); removed MW-1.45-notes (1.45.0-wmf.15; 2025-08-19).Aug 13 2025, 9:01 PM
Esanders moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 17 2025, 1:48 PM
Esanders added a project: Skipped QA.

I think we are happy the gutters are still working as before.

Ryasmeen removed projects: Skipped QA, Editing QA.Sep 30 2025, 10:50 PM
ppelberg closed this task as Resolved.Oct 13 2025, 9:31 PM
VPuffetMichel added a project: OKR-Work.Dec 8 2025, 10:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits