Page MenuHomePhabricator
Create Task
Maniphest T400933

Insert menu in wrong place on mobile, on wikis using $wgVisualEditorMobileInsertMenu
Closed, ResolvedPublic
Actions

Description

image.png (445×1 px, 79 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix placement of toolbar insert group on mobilemediawiki/extensions/VisualEditorwmf/1.45.0-wmf.12+16 -12
Fix placement of toolbar insert group on mobilemediawiki/extensions/VisualEditormaster+16 -12
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 31 2025, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2025, 6:07 PM
Esanders updated the task description. (Show Details)Jul 31 2025, 6:07 PM
Esanders added a subscriber: DLynch.
gerritbot added a comment.Jul 31 2025, 6:08 PM

Change #1174785 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Fix placement of toolbar insert group on mobile

https://gerrit.wikimedia.org/r/1174785

gerritbot added a project: Patch-For-Review.Jul 31 2025, 6:08 PM
Esanders triaged this task as High priority.Jul 31 2025, 6:08 PM
ppelberg moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Jul 31 2025, 6:17 PM
gerritbot added a comment.Jul 31 2025, 6:50 PM

Change #1174795 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.12] Fix placement of toolbar insert group on mobile

https://gerrit.wikimedia.org/r/1174795

DLynch added a comment.Jul 31 2025, 7:02 PM

Follow-up to the work done in T397948, specifically https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1164258

gerritbot added a comment.Jul 31 2025, 7:12 PM

Change #1174785 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix placement of toolbar insert group on mobile

https://gerrit.wikimedia.org/r/1174785

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Jul 31 2025, 8:00 PM
gerritbot added a comment.Jul 31 2025, 8:20 PM

Change #1174795 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.12] Fix placement of toolbar insert group on mobile

https://gerrit.wikimedia.org/r/1174795

Stashbot added a comment.Jul 31 2025, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T20:21:22Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]]

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2025, 8:30 PM
Stashbot added a comment.Jul 31 2025, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T20:35:11Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jul 31 2025, 8:40 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T20:40:41Z] <dancy@deploy1003> Started scap sync-world: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]]

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.12; 2025-07-29); removed MW-1.45-notes (1.45.0-wmf.13; 2025-08-05).Jul 31 2025, 9:00 PM
Stashbot added a comment.Jul 31 2025, 9:01 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T21:01:14Z] <dancy@deploy1003> kemayo, dancy: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 31 2025, 9:12 PM
DLynch added a project: Editing QA.

Needs to be tested on a wiki with the insert menu turned on, e.g. kowiki here: https://ko.m.wikipedia.org/wiki/%EA%B0%80%EB%8B%88%EB%A9%94%EB%8D%B0_(%EC%9C%84%EC%84%B1)#/editor/0

Stashbot added a comment.Jul 31 2025, 9:14 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T21:14:35Z] <dancy@deploy1003> Finished scap sync-world: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]] (duration: 33m 54s)

Stashbot added a comment.Jul 31 2025, 9:24 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T21:24:16Z] <dancy@deploy1003> Started scap sync-world: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]]

Stashbot added a comment.Jul 31 2025, 9:29 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T21:29:44Z] <dancy@deploy1003> dancy, kemayo: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jul 31 2025, 9:38 PM

Mentioned in SAL (#wikimedia-operations) [2025-07-31T21:38:10Z] <dancy@deploy1003> Finished scap sync-world: Backport for [[gerrit:1174795|Fix placement of toolbar insert group on mobile (T400933)]] (duration: 13m 54s)

EAkinloose closed this task as Resolved.Aug 11 2025, 10:07 PM
EAkinloose edited projects, added Verified; removed Editing QA.
VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits