Page MenuHomePhabricator
Create Task
Maniphest T400964

Request to enable XFF headers for test XTools hostnames
Closed, InvalidPublic
Actions

Description

Project Name:

xtools

Request:

Enable XFF headers for xtools2.wmcloud.org

Also, I think the old xtools.wmflabs.org can be removed. There's no web proxy in Horizon for it anymore, nor do we have it defined in the Apache config.

Rationale:

I am setting up a new pair of VMs for deploying Anubis as well as upgrading to Debian Bookworm and PHP 8.2. Anubis requires the IP to function. I could spoof it, but it'd be nice to have another hostname for this very purpose of testing new VMs, which happens every other year or so.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedMusikAnimalT400229 Add Anubis to XTools
 InvalidNoneT400964 Request to enable XFF headers for test XTools hostnames

Event Timeline

MusikAnimal created this task.Aug 1 2025, 5:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2025, 5:29 AM
MusikAnimal added a comment.Aug 1 2025, 5:31 AM

I was interested to write a patch for this, but it seems the instance-puppet repo is hosted on Gerrit but not committed to on Gerrit (?)

MusikAnimal mentioned this in T400229: Add Anubis to XTools.Aug 1 2025, 5:35 AM
MusikAnimal added a parent task: T400229: Add Anubis to XTools.
Novem_Linguae subscribed.Aug 1 2025, 5:37 AM
taavi added a project: Cloud-VPS.Aug 1 2025, 7:08 AM
Alien333 subscribed.Aug 1 2025, 9:21 AM
bd808 subscribed.Aug 1 2025, 10:28 PM
In T400964#11052821, @MusikAnimal wrote:

I was interested to write a patch for this, but it seems the instance-puppet repo is hosted on Gerrit but not committed to on Gerrit (?)

That git repo is an audit log of the changes made via the Puppet screens in horizon.wikimedia.org. The actual Puppet ENC backend itself does not read data from the git repo.

taavi moved this task from Inbox to Clinic Duty on the cloud-services-team board.Aug 4 2025, 9:39 AM
taavi subscribed.

Is the new proxy meant to be temporary or will it exist permanently?

MusikAnimal added a comment.EditedAug 4 2025, 5:00 PM
In T400964#11056874, @taavi wrote:

Is the new proxy meant to be temporary or will it exist permanently?

I'm asking to keep it permanently, if that's okay. It'd be nice to have XFF headers enabled on a test installation for whenever I need to upgrade the VMs again. Before this wasn't an issue as I didn't need to test with XFF headers, but we do now that we use Anubis.

MusikAnimal added a comment.EditedAug 5 2025, 5:11 PM

I was expecting this to be an uncontroversial request that would be actioned quickly. If there's any hesitation, we can just decline this. I put a lot of effort into uptime so this was just in the spirit of that. Realistically things should be okay… what makes the prod setup different though is there's an API server. I can make xtools-dev have an API server to accurately replicate that (xtools-dev.wmcloud.org has the XFF headers), but I'm already out of quota on instances! So I guess I can delete the old xtools-dev VM and use that quota for the new API dev server. Then there's no need for xtools2.wmcloud.org.

MusikAnimal closed this task as Invalid.Aug 13 2025, 7:20 PM

Finally got back to working on this, and realized I can simply temporarily point xtools-dev.wmcoud.org to the new prod servers and that will allow me to fully replicate the prod setup. Closing as invalid. Apologies for the noise.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits