Page MenuHomePhabricator

Cite Converter tests fail on runGetModelFromDomTest with stored HTML on CI
Open, Needs TriagePublic

Description

Context:

For the Cite extension we create some new Converter tests also using storeItems in some cases to test the behavior of that mechanism. In one of the test cases we saw the runGetModelFromDomTest execution failing because the store seems not to be set up correctly.

See https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81/22668/console from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1173443/10

In there

List defined references with stored original HTML: store item h65f63aa988b013a3 found

triggers an error because instead of the expected content of the store there was an empty set retrieved.

Note that we only saw that happening in the CI. Locally it was fine.

Test:

Un-commenting

https://gerrit.wikimedia.org/g/mediawiki/extensions/Cite/+/e3ff818afc4498b58aca1b072075f8f5d8e7a1c9/tests/qunit/ve-cite/ve.dm.Converter.test.js#57

can be used to trigger the issue.