Page MenuHomePhabricator

Highlighted text while rechecking in "Revise" Tone Check
Closed, ResolvedPublic

Description

Background goal

This task is to specify how the highlighted text should behave while rechecking is happening after selecting "Revise" Tone Check being implemented in T397984.

Proposed solution

Captura de pantalla 2025-08-01 a las 13.05.43.png (824×2 px, 776 KB)

While Rechecking (loading), any highlighted text will temporarily disappear because the system is verifying whether the issue has been fixed.

Why no highlights during rechecking?

  • Gray highlight indicates an issue that is inactive.
  • Yellow highlight indicates an issue that is selected and active.
  • Blue borders indicate the issue currently being revised by the user.

During the rechecking process, none of these visual indicators should be shown, as the system is still determining whether the issue has been resolved. Once rechecking is complete, the text will be highlighted again just if the system detects there are still issues to fix.

Event Timeline

This work should be live on beta and is ready for QA.

I don't think this should happen, because it loses the connection between the check card and the text it relates to -- we won't even be indicating what we're rechecking. It will also cause a strange flicker in the case where the tone issue wasn't resolved, as the state goes from "blue borders" => "0 - 5 seconds of nothing" => "yellow highlight".

I don't think this should happen, because it loses the connection between the check card and the text it relates to -- we won't even be indicating what we're rechecking. It will also cause a strange flicker in the case where the tone issue wasn't resolved, as the state goes from "blue borders" => "0 - 5 seconds of nothing" => "yellow highlight".

Have we decided on this? From my end, I see that when a tone check is presented there is the yellow highlight, then the blue borders appear as the paragraph is being reviewed, and the blue border now stays during the "Recheck" process instead of nothing/no highlight and then it goes back to yellow highlight when the tone issue is not resolved.

I am also not noticing the flicker much..

@DLynch: Can you confirm that behavior you described is not happening here.

https://drive.google.com/file/d/1bm0uGijtsHKAcrhxy9kR6fhfIp4q0BMy/view?usp=sharing

I don't think this should happen, because it loses the connection between the check card and the text it relates to -- we won't even be indicating what we're rechecking. It will also cause a strange flicker in the case where the tone issue wasn't resolved, as the state goes from "blue borders" => "0 - 5 seconds of nothing" => "yellow highlight".

DLynch claimed this task.

@Ryasmeen That shows what I'm expecting. It's returning to the normal yellow highlight immediately, rather than having three possible states.