Page MenuHomePhabricator
Create Task
Maniphest T400996

Setup fallback default currency logic on Gravy PayPal
Closed, ResolvedPublic
Actions

Description

On the PayPal Direct connection we have specified currencies supported by the PayPal Payment method. As such, when a currency that is not on this list is provided, the Payments form falls back to the default currency "USD", with a message "Your currency was unsupported. Processing will take place using USD, if you decide to continue." (example link).

The currencies configuration on DonationInterface consists of all the currencies supported by all the payment methods each Payment Processor integrates with. We can do either of 2 approaches:

  1. Manually setup a list of supported currencies for each payment method in the DI-Gravy config. Downside to this is we have to manually update this whenever a country is added on the Gravy region details configuration.
  2. Use the Gravy API to look up support for the country/currency combination and use the fallback when the combination is not supported.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check for validation errors on gravy paypal before redirectingmediawiki/extensions/DonationInterfacemaster+2 -2
Validate PayPal currency support using the list from Gravy Payment Service definition and Fallback to default currencymediawiki/extensions/DonationInterfacemaster+14 -1
Fetch payment service definition for a payment service payment method on Gravywikimedia/fundraising/SmashPigmaster+704 -2
Customize query in gerrit

Event Timeline

Damilare created this task.Aug 1 2025, 12:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2025, 12:53 PM
Damilare added a project: payments-orchestration.Aug 1 2025, 12:53 PM
gerritbot added a comment.Aug 1 2025, 4:09 PM

Change #1175142 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[wikimedia/fundraising/SmashPig@master] Fetch payment service definition for a payment service payment method on Gravy

https://gerrit.wikimedia.org/r/1175142

gerritbot added a project: Patch-For-Review.Aug 1 2025, 4:09 PM
gerritbot added a comment.Aug 1 2025, 5:28 PM

Change #1175154 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Validate PayPal currency support using the list from Gravy Payment Service definition and Fallback to default currency

https://gerrit.wikimedia.org/r/1175154

greg added a project: Fundraising Sprint: Omakase.Aug 4 2025, 8:21 PM
greg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
Damilare claimed this task.Aug 5 2025, 3:18 PM
Damilare moved this task from Backlog to Ready for Review on the Fundraising Sprint: Omakase board.
Damilare edited projects, added Fundraising Sprint: Pirate's Booty; removed Fundraising Sprint: Omakase.Aug 12 2025, 7:50 PM
XenoRyet moved this task from Backlog to Ready for Review on the Fundraising Sprint: Pirate's Booty board.Aug 14 2025, 8:24 PM
gerritbot added a comment.Aug 18 2025, 5:10 PM

Change #1175142 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Fetch payment service definition for a payment service payment method on Gravy

https://gerrit.wikimedia.org/r/1175142

gerritbot added a comment.Aug 19 2025, 7:11 PM

Change #1175154 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Validate PayPal currency support using the list from Gravy Payment Service definition and Fallback to default currency

https://gerrit.wikimedia.org/r/1175154

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2025, 7:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 19 2025, 8:00 PM
Damilare moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: Pirate's Booty board.Aug 20 2025, 11:13 AM
XenoRyet closed this task as Resolved.Aug 25 2025, 7:23 PM
XenoRyet moved this task from Pending Deployment to Done on the Fundraising Sprint: Pirate's Booty board.
XenoRyet set Final Story Points to 4.
gerritbot added a comment.Aug 29 2025, 11:26 AM

Change #1183094 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Check for validation errors on gravy paypal before redirecting

https://gerrit.wikimedia.org/r/1183094

gerritbot added a project: Patch-For-Review.Aug 29 2025, 11:26 AM
gerritbot added a comment.Sep 8 2025, 5:21 PM

Change #1183094 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Check for validation errors on gravy paypal before redirecting

https://gerrit.wikimedia.org/r/1183094

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2025, 5:32 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.18; 2025-09-09); removed MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Sep 8 2025, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits