Create a minimal implementation for the Revise Tone Suggested Edits task type
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Michael
	Aug 5 2025, 1:32 PM

Project Tags

Referenced Files

	F66753675: screenshot 266.png
	Oct 16 2025, 3:22 AM

	F66753673: screenshot 265.png
	Oct 16 2025, 3:22 AM

	F66753671: screenshot 264.png
	Oct 16 2025, 3:22 AM

	F66753669: screenshot 263.png
	Oct 16 2025, 3:22 AM

	F66753667: screenshot 262.png
	Oct 16 2025, 3:22 AM

	F66753665: screenshot 261.png
	Oct 16 2025, 3:22 AM

	F66753663: screenshot 260.png
	Oct 16 2025, 3:22 AM

	F66753661: screenshot 259.png
	Oct 16 2025, 3:22 AM

Subscribers

Description

Feature flagged behind T401192: Create a Feature Flag for Improve Tone Suggested Edits, we want to get started with a bare-bones implementation of the new task type.

Acceptance criteria:

all copy should be drafts and not final (no translations yet)
- take the dedicated (medium) task type variant from https://docs.google.com/document/d/1Mfw-WbwZwuImhUKF40ShP9yN4LjiV_bMMB0rCav6AG8/edit?tab=t.9n0swk719ar3 as a basis for the copy for now
for now, it should search for a short list of (hard-coded?) templates in that TaskTypeHandler, similar to TemplateBasedTaskTypeHandler::getSearchTerm
- this should have a FIXME comment to change it for a weighted tag
it should be Easy difficulty, and enabled by default
After clicking on a task, VE should load directly into a full-page edit-session
for now: no onboarding (will be investigated in a different task)
once VE opened, if T400335 and T401185 are not done yet, just alert the payload, otherwise trigger the Tone Edit Check

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
tests: add Cypress test for ReviseTone and showing the ToneCheck	Michael Große	mediawiki/extensions/GrowthExperiments	master	+92 -0
feat(ReviseTone): Show Tone Check	Michael Große	mediawiki/extensions/GrowthExperiments	master	+58 -36
feat: minimal Improve Tone task type	Michael Große	mediawiki/extensions/GrowthExperiments	master	+506 -19

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	ppelberg	T392954 [FY25-26] WE 1.1: Increase constructive edits
Open	KStoller-WMF	T396162 [EPIC] Revise Tone: Structured Task (WE1.1.2, FY25-26)
Resolved	KStoller-WMF	T407034 Revise Tone: Core Experience (with mock data)
Resolved	Michael	T401195 Create a minimal implementation for the Revise Tone Suggested Edits task type

Event Timeline

Michael created this task.Aug 5 2025, 1:32 PM

Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptAug 5 2025, 1:32 PM

Michael moved this task from Inbox to Backlog on the Growth-Team board.Aug 5 2025, 2:07 PM

ldelench_wmf added a project: OKR-Work.Aug 12 2025, 7:46 PM

KStoller-WMF moved this task from Backlog to Estimated tasks backlog on the Growth-Team board.Aug 14 2025, 10:55 PM

KStoller-WMF subscribed.

KStoller-WMF triaged this task as High priority.Aug 14 2025, 11:26 PM

Change #1181721 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] [WIP/POC]: minimal Improve Tone task type

https://gerrit.wikimedia.org/r/1181721

gerritbot added a project: Patch-For-Review.Aug 25 2025, 2:25 PM

KStoller-WMF set the point value for this task to 5.Aug 25 2025, 4:14 PM

KStoller-WMF moved this task from Estimated tasks backlog to Current Sprint on the Growth-Team board.Aug 26 2025, 4:47 PM

KStoller-WMF edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team.

Michael claimed this task.Aug 27 2025, 2:57 PM

Michael moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.

Restricted Application added a project: User-Michael. · View Herald TranscriptAug 27 2025, 2:57 PM

There is now a patch-demo for this available: https://0f3c3297c9.catalyst.wmcloud.org

Obviously, much still needs doing, but the skeleton stands, I think. High-level feedback for my change welcome: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1181721

Michael removed a subtask: T403984: Revise Tone: create quiz-style onboarding for Revise Tone Structured Task.Sep 9 2025, 1:32 PM

Change #1181721 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] feat: minimal Improve Tone task type

https://gerrit.wikimedia.org/r/1181721

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2025, 10:32 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 26 2025, 11:00 AM

Next steps:

finish work / add tests for WIP: Show Tone Check
finish work / add tests (browser and unit) for WIP: Show post-edit dialog
figure out why mobile experience is so bumpy

Change #1191710 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] feat(ReviseTone): Show Tone Check

https://gerrit.wikimedia.org/r/1191710

Change #1184506 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] tests: add Cypress test for ReviseTone and showing the ToneCheck

https://gerrit.wikimedia.org/r/1184506

Michael moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Oct 1 2025, 1:23 PM

Change #1191710 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] feat(ReviseTone): Show Tone Check

https://gerrit.wikimedia.org/r/1191710

Change #1184506 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: add Cypress test for ReviseTone and showing the ToneCheck

https://gerrit.wikimedia.org/r/1184506

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14); removed: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Oct 7 2025, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2025, 4:31 PM

Michael moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Oct 7 2025, 5:00 PM

Urbanecm_WMF edited projects, added: Growth-Team (FY2025-26 Q2 Sprint 1); removed: Growth-Team (Current Sprint).Oct 7 2025, 5:00 PM

Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (FY2025-26 Q2 Sprint 1) board.

NOTE: This hasn't been tested yet. The details below may change and be updated during test execution.

Requirement

Implement a minimal “Improve Tone / Revise Tone” Structured Task within the Suggested Edits framework. The task should:

Be feature-flagged behind the “Improve Tone Suggested Edits” flag
Present a UI interface in Suggested Edits / VE for selecting a sentence with non-neutral tone
Show guidance / templates (hard-coded or minimal) for improving tone
Launch VE editing on the selected sentence
Allow the user to apply the edited version, and reflect updates in UI
Support the “Movement Communications / Improve Tone” variant (T399982) under the same flow

Note: This QA includes testing for T399982 (Movement Communications: Improve Tone Structured Task).

BDD

Feature: Revise Tone / Improve Tone Structured Task  

Scenario: Basic flow of Improve Tone suggestion  
  Given the Improve Tone feature flag is enabled  
  And a user opens a Suggested Edits task with a non-neutral sentence  
  When the user clicks the “Improve Tone” task  
  Then they should see highlighting / guidance on non-neutral wording  
  And clicking “Edit” opens VE with that sentence in focus  
  And after editing, the revised text is applied and UI updates  

Scenario: Guidance templates display  
  Given the user is on the Improve Tone UI  
  When suggestions are shown  
  Then the user should see a small list of hard-coded templates / guidance  

Scenario: Movement Communications variant  
  Given the task is triggered under the “Movement Communications / Improve Tone” context  
  When the user runs the flow  
  Then the behavior should mirror the general Improve Tone flow

Test Result

Status: ✅ PASS / ❓ Need More Info / ❌ FAIL
Environment: beta/testwiki
OS: macOS Sequoia 15.5
Browser: Chrome Canary / Safari / Firefox (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Basic Improve Tone flow

Enable the Improve Tone feature flag
Create or open content with non-neutral wording
Trigger the Improve Tone task
Verify the UI highlights non-neutral wording and shows guidance
Click “Edit” → confirm VE loads the sentence
Apply a revision → submit
Confirm the change is reflected
✅ ⬜ ❌ ❓ AC1: Edit flow works

Test Case 2: Guidance / template display

In the Improve Tone UI, view guidance section
Confirm templates / suggestions are shown
✅ ⬜ ❌ ❓ AC2: Guidance templates appear

Test Case 3: Movement Communications variant

Trigger the variant under the Movement Communications context
Walk through the same flow (highlight, edit, submit)
Confirm behavior matches general case
✅ ⬜ ❌ ❓ AC3: Movement Communications variant is supported

Edtadros mentioned this in T399982: Movement Communications: Improve Tone Structured Task.Oct 8 2025, 1:57 AM

Thanks for the draft of a test plan! I slightly adapted the first BDD

Scenario: Basic flow of Revise Tone suggestion  
  Given the Revise Tone feature flag is enabled  
  And a user opens a Suggested Edits task with a non-neutral sentence  
  When the user clicks the “Revise Tone” task  
  Then VE opens with a sentence with non-neutral wording in focus  
  And they should see a dialog / guidance on non-neutral wording  
  And after editing, the revised text is applied and UI updates

I created a patch-demo wiki based on the master branch where that works correctly: https://d7773a52b4.catalyst.wmcloud.org/wiki/Main_Page
(unfortunately, a plain new patch-demo still needs some tweaks before this task can actually be tried.)

Michael renamed this task from Create a minimal implementation for the Improve Tone Suggested Edits task type to Create a minimal implementation for the Revise Tone Suggested Edits task type.Oct 10 2025, 7:13 PM

Michael added a parent task: T407034: Revise Tone: Core Experience (with mock data).Oct 10 2025, 7:41 PM

Michael removed a parent task: T397731: Create PoC for how to create a backlog of tasks for 🎭 Improve Tone Suggested Edits.

Requirement

All copy for the Revise Tone task may remain as drafts / non-translated.
Use the “medium” task variant’s copy temporarily (from the documented drafts) for now.
The TaskTypeHandler should use a short, hard-coded list of tone templates (no weighting yet).
The task’s difficulty should be “Easy” and the feature should be enabled by default.
Clicking a Revise Tone task should open VE directly (full page / in focus) at the sentence needing tone revision.
Once VE is open, guidance or dialog should show highlighting or annotations on non-neutral wording.
After editing and saving, the revised text should be applied and the UI must update to reflect the change.

BDD

Feature: Revise Tone / Improve Tone Structured Task  

Scenario: Basic flow of Revise Tone suggestion  
  Given the Revise Tone feature flag is enabled  
  And a user opens a Suggested Edits task with a non-neutral sentence  
  When the user clicks the “Revise Tone” task  
  Then VE opens with a sentence with non-neutral wording in focus  
  And they should see a dialog / guidance on non-neutral wording  
  And after editing, the revised text is applied and UI updates

Test Result

Status: ✅ PASS
Environment: patchdemo
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Basic flow of Revise Tone suggestion

Enable the Revise Tone feature flag
Identify or create a Suggested Edits task containing a non-neutral sentence
Click “Revise Tone”
Confirm that VE opens, with the non-neutral sentence in focus / highlighted
In the UI/dialog, check that guidance or annotation is shown around the non-neutral wording
Edit that sentence → save / apply
Return to article / preview and confirm the revised text appears
✅ AC1: The revised text is applied and UI updates

Test Case 2: Guidance templates visible