Page MenuHomePhabricator

Tone check forcing itself selected interferes with other checks
Closed, ResolvedPublic

Description

Tone check is implemented as triggering when the cursor focus leaves a branch node (generally a paragraph). It runs itself async, and then if a tone check is returned it shows itself and forces itself into being the selected check. (This is the only way to have a check selected without your cursor being contained within its matched text range.)

This is okay in the simple case, but it causes confusion if there's any other checks in the document. E.g. if you left the place you were typing by clicking another check and starting to interact with it, you'd be forcibly evicted from that check.

It also interfered with suggestion-mode (T399612) because the initial run of synchronous checks came in and were displayed, and then were overridden 2-5 seconds later by the full document's worth of tone checks getting dropped on top of them. This is worse than the above, because doing 30 tone checks at once is a bit slower.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedEsanders
Openbmartinezcalvo
OpenNone
OpenNone
OpenNone
OpenBUG REPORTNone
OpenNone
Resolveddchan
OpenNone
ResolvedEsanders
OpenNone
OpenNone
ResolvedRyasmeen
Openppelberg
InvalidNone
ResolvedDLynch
Openppelberg
Opennayoub
OpenNone
Declinedppelberg
In ProgressNone
Resolvedbmartinezcalvo
Resolvedbmartinezcalvo
OpenNone
OpenNone
OpenEsanders
OpenNone
OpenNone
OpenQuiddity
Resolvedppelberg
Resolvedppelberg
Resolvedppelberg
Resolvedppelberg
ResolvedDLynch
ResolvedDLynch
Resolvedbmartinezcalvo
ResolvedDLynch
ResolvedEsanders
OpenNone
OpenNone
OpenNone
Openmedelius
OpenNone
OpenNone
OpenNone

Event Timeline

Change #1178052 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: don't focus new checks automatically

https://gerrit.wikimedia.org/r/1178052

Change #1178590 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: stop deselecting checks when the selection leaves them

https://gerrit.wikimedia.org/r/1178590

Change #1178615 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: fix check focus issues

https://gerrit.wikimedia.org/r/1178615

Test wiki created on Patch demo by DLynch (WMF) using patch(es) linked to this task:
https://2c43ba9338.catalyst.wmcloud.org/w/

Change #1178590 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: stop deselecting checks when the selection leaves them

https://gerrit.wikimedia.org/r/1178590

Change #1178052 abandoned by DLynch:

[mediawiki/extensions/VisualEditor@master] Edit check: don't focus new checks automatically

Reason:

We're going with the stack ending in Iaf3a52babf639d3f9bc47f3c1c958df374b15fb7 instead.

https://gerrit.wikimedia.org/r/1178052

Change #1178615 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: fix check focus issues

https://gerrit.wikimedia.org/r/1178615

DLynch claimed this task.
DLynch added a project: Skipped QA.

We've changed how the selection-state works, so this shouldn't be so much of an issue now. The QA should wind up happening against the tone ticket.

Test wiki on Patch demo by DLynch (WMF) using patch(es) linked to this task was deleted:

https://2c43ba9338.catalyst.wmcloud.org/w/