Parent task/goal: T398480: [Epic] Update instruments configuration for xLab
mw.xLab = { getInstrument: metricsClient.newInstrument.bind( metricsClient ) };
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| [JS] Allow an event to be redirected to another stream | repos/data-engineering/metrics-platform!100 | phuedx | work/phuedx/T401380-2 | main | |
| [JS] Add Instrument#setSchemaID() method | repos/data-engineering/metrics-platform!99 | phuedx | work/phuedx/T401380 | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JVanderhoop-WMF | T397337 [Epic] Verification of Experimentation Lab Closed Beta capabilities | |||
| Resolved | cjming | T397363 Verify instrument configuration with xLab | |||
| Resolved | JVanderhoop-WMF | T398480 [Epic] Update instruments configuration for xLab | |||
| Resolved | phuedx | T401380 MetricsPlatform: Initialize MetricsClient with instrument configs fetched from xLab |
Change #1183672 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/MetricsPlatform@master] ext.xLab: Add mw.xLab.getInstrument()
I struggled with making this all work and have thought a lot about how all of these pieces fit together.
The sticking point was trying to get mw.eventLog.submit() and mw.eventLog.newInstrument() to work with the instrument config returned by xLab whilst not further complecting the EventLogging and MetricsPlatform extensions. Simply put, this is impossible. At least, the not further complecting the two extensions bit is impossible.
If we drop the constraint the mw.eventLog.submit() and mw.eventLog.newInstrument() should work with the instrument config returned by xLab, then this becomes quite routine. We:
With this approach, there is a clear line between older-style (but not legacy) instruments using the mw.eventLog.* methods and instruments powered by Experiment Platform using the mw.xLab.* methods. There will be no confusion about where the config is coming from – indeed, we can safely remove the GetStreamConfigs hook without deprecation. Finally, since the two are decoupled, changes to one won't affect the other, which allows the Experiment Platform team to iterate on the Experimentation Lab without impacting ongoing data collection activities.
phuedx opened https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/99
[JS] Add Instrument#setSchemaID() method
milimetric merged https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/99
[JS] Add Instrument#setSchemaID() method
phuedx opened https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/100
Draft: [JS] Allow an event to be redirected to another stream
sfaci merged https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/100
[JS] Allow an event to be redirected to another stream
Change #1189818 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/EventLogging@master] lib: Update metrics-platform to f1a185532d15
Change #1189818 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] lib: Update metrics-platform to fc7678c10a1f
Change #1183672 merged by jenkins-bot:
[mediawiki/extensions/MetricsPlatform@master] ext.xLab: Add mw.xLab.getInstrument()
Change #1190647 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/MetricsPlatform@wmf/1.45.0-wmf.19] ext.xLab: Add mw.xLab.getInstrument()
Change #1190648 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/MetricsPlatform@wmf/1.45.0-wmf.20] ext.xLab: Add mw.xLab.getInstrument()
Change #1190679 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Phuedx):
[mediawiki/extensions/EventLogging@wmf/1.45.0-wmf.19] lib: Update metrics-platform to fc7678c10a1f
Change #1190679 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@wmf/1.45.0-wmf.19] lib: Update metrics-platform to fc7678c10a1f
Change #1190647 merged by jenkins-bot:
[mediawiki/extensions/MetricsPlatform@wmf/1.45.0-wmf.19] ext.xLab: Add mw.xLab.getInstrument()
Mentioned in SAL (#wikimedia-operations) [2025-09-23T14:03:20Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1190667|lib: Update lib/metrics-platform to f1a18553 (T385180)]], [[gerrit:1190679|lib: Update metrics-platform to fc7678c10a1f (T401380)]], [[gerrit:1190647|ext.xLab: Add mw.xLab.getInstrument() (T401380 T404851)]]
Mentioned in SAL (#wikimedia-operations) [2025-09-23T14:09:06Z] <lucaswerkmeister-wmde@deploy1003> phuedx, lucaswerkmeister-wmde: Backport for [[gerrit:1190667|lib: Update lib/metrics-platform to f1a18553 (T385180)]], [[gerrit:1190679|lib: Update metrics-platform to fc7678c10a1f (T401380)]], [[gerrit:1190647|ext.xLab: Add mw.xLab.getInstrument() (T401380 T404851)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2025-09-23T14:22:14Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1190667|lib: Update lib/metrics-platform to f1a18553 (T385180)]], [[gerrit:1190679|lib: Update metrics-platform to fc7678c10a1f (T401380)]], [[gerrit:1190647|ext.xLab: Add mw.xLab.getInstrument() (T401380 T404851)]] (duration: 18m 54s)
Change #1191683 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/EventLogging@wmf/1.45.0-wmf.20] lib: Update metrics-platform to fc7678c10a1f
Change #1191683 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@wmf/1.45.0-wmf.20] lib: Update metrics-platform to fc7678c10a1f
Change #1190648 merged by jenkins-bot:
[mediawiki/extensions/MetricsPlatform@wmf/1.45.0-wmf.20] ext.xLab: Add mw.xLab.getInstrument()
Mentioned in SAL (#wikimedia-operations) [2025-09-26T13:06:39Z] <phuedx@deploy2002> Started scap sync-world: Backport for [[gerrit:1190648|ext.xLab: Add mw.xLab.getInstrument() (T401380 T404851)]], [[gerrit:1191683|lib: Update metrics-platform to fc7678c10a1f (T401380)]]
Mentioned in SAL (#wikimedia-operations) [2025-09-26T13:12:57Z] <phuedx@deploy2002> phuedx: Backport for [[gerrit:1190648|ext.xLab: Add mw.xLab.getInstrument() (T401380 T404851)]], [[gerrit:1191683|lib: Update metrics-platform to fc7678c10a1f (T401380)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2025-09-26T13:30:34Z] <phuedx@deploy2002> Finished scap sync-world: Backport for [[gerrit:1190648|ext.xLab: Add mw.xLab.getInstrument() (T401380 T404851)]], [[gerrit:1191683|lib: Update metrics-platform to fc7678c10a1f (T401380)]] (duration: 23m 55s)