Page MenuHomePhabricator

[MEX] M3 - add property selector
Closed, ResolvedPublic

Description

After the button from T401401 has been clicked, open a property selector. Selecting a property won’t do anything yet (except maybe log it to the console or something).

image.png (912×477 px, 82 KB)

Event Timeline

Change #1179147 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Add wbui2025 property selector

https://gerrit.wikimedia.org/r/1179147

Change #1180118 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Load Codex more efficiently

https://gerrit.wikimedia.org/r/1180118

Change #1180118 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Load Codex more efficiently

https://gerrit.wikimedia.org/r/1180118

The appearance of the property selector isn’t finalized yet, but I think we can start reviewing the Gerrit change.

Open questions include:

  • generally, what does the dev-ready version of the property selector look like?
  • more specifically, should the buttons be above the lookup or below?
  • how many search results should be shown at a time? (currently 3)

Also, this usage of Codex’ Lookup component is affected by T342507: Lookup: Update to support menu items with URLs without triggering navigation on click. We can’t set a url on the menu items, because that would prevent tapping a menu item to select it; this means it’s impossible for users to look at the property before selecting it (e.g. to inspect its usage instructions or property examples to check whether it’s the right property or not).

Change #1179147 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add wbui2025 property selector

https://gerrit.wikimedia.org/r/1179147

aaaaand now its loading. I'll assume a hiccup in my internet connection