Page MenuHomePhabricator
Create Task
Maniphest T401403

[MEX] M3 - add dialog to edit empty statement
Closed, ResolvedPublic
Actions

Description

After a string property has been selected in T401402, show an initially empty form for editing a new statement:

Screenshot 2025-08-28 at 17.39.41.png (1×2 px, 188 KB)

Figma file here: https://www.figma.com/design/RtMDwH7sMF5IPRJvyyZPv4/Mobile-editing-experience?node-id=2134-27544&t=C9HTDU2XkF8Mdz6A-1

Acceptance Criteria

  • An empty form for a string datatype is created
  • The add statement form matches the figma design but is not pixel perfect
  • Once the user arrives to the form, the initial input form - codex component Lookup - is already active, but the suggestiondropdown only opens once the user starts typing (as in desktop)
  • Once the user selects or types in a valid entry, the second field appears and is already active, but once again the dropdown only opens when the user starts typing
  • both lookups can show up to 4 suggestions
  • the lookups dropdown type is "initial suggestions" (component option) and the menu items include a description (also component option)
  • once both values are inserted correctly the publish button becomes active
  • behavior for what happesn when user clicks publish is defined at [MEX] M3.1.2 - Add publish functionality to edit forms T402620
  • the back arrow on top takes user to previous page

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add 'edit statement' view to wbui2025mediawiki/extensions/Wikibasemaster+729 -3
[DNM] Made edit view visible in statement viewmediawiki/extensions/Wikibasemaster+21 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 7 2025, 2:58 PM
Lucas_Werkmeister_WMDE mentioned this in T401405: [MEX] M3.1.2 - form can be published (save new/edited statements).Aug 7 2025, 3:03 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready for Task Time (Story Writing) on the Wikidata-Omega board.
karapayneWMDE removed a parent task: T400129: [MEX] M3.1 edit function for a simple text input.Aug 12 2025, 3:29 PM
karapayneWMDE added a parent task: T401700: [MEX] M3.1.1 First Pass - Edit Functionality Simple text input (string) .
Lucas_Werkmeister_WMDE moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Aug 14 2025, 10:07 AM
ArthurTaylor claimed this task.Aug 18 2025, 8:02 AM
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Aug 19 2025, 6:53 AM

Change #1179973 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Add 'edit statement' view to wbui2025

https://gerrit.wikimedia.org/r/1179973

gerritbot added a project: Patch-For-Review.Aug 19 2025, 6:53 AM

Change #1179974 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] [DNM] Made edit view visible in statement view

https://gerrit.wikimedia.org/r/1179974

Arian_Bozorg updated the task description. (Show Details)Aug 19 2025, 4:08 PM
Arian_Bozorg updated the task description. (Show Details)Aug 19 2025, 4:13 PM
karapayneWMDE mentioned this in T401700: [MEX] M3.1.1 First Pass - Edit Functionality Simple text input (string) .Aug 20 2025, 7:57 PM
gerritbot added a comment.Aug 21 2025, 8:06 AM

Change #1179974 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] [DNM] Made edit view visible in statement view

Reason:

Now included in I6a6a696442383

https://gerrit.wikimedia.org/r/1179974

karapayneWMDE mentioned this in T402428: [MEX] M3.1.1 - update edit button on existing statements for simple text inputs to open the edit functionality page.Aug 21 2025, 12:25 PM
karapayneWMDE mentioned this in T402439: [MEX] M3.1.1 - add sticky header to edit form for simple text inputs .Aug 21 2025, 12:35 PM
karapayneWMDE mentioned this in T402443: [MEX] M3.1.1 - add sticky footer to edit form for simple text inputs .
karapayneWMDE mentioned this in T402447: [MEX] M3.1.1 - create basic edit statement form for simple text inputs.Aug 22 2025, 7:39 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Aug 22 2025, 11:55 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
HasanAkgun_WMDE claimed this task.Aug 22 2025, 2:43 PM
HasanAkgun_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
HasanAkgun_WMDE removed HasanAkgun_WMDE as the assignee of this task.Aug 22 2025, 3:01 PM
HasanAkgun_WMDE moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor assigned this task to HasanAkgun_WMDE.Aug 25 2025, 7:59 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
HasanAkgun_WMDE removed HasanAkgun_WMDE as the assignee of this task.Aug 26 2025, 12:37 PM
HasanAkgun_WMDE moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
HasanAkgun_WMDE moved this task from Ready for Peer Review to Ready for Development on the Wikidata-Omega (The Board) board.
HasanAkgun_WMDE moved this task from Ready for Development to In Peer Review on the Wikidata-Omega (The Board) board.Aug 26 2025, 12:54 PM
HasanAkgun_WMDE moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.Aug 26 2025, 12:57 PM
gerritbot added a comment.Aug 26 2025, 1:46 PM

Change #1179973 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add 'edit statement' view to wbui2025

https://gerrit.wikimedia.org/r/1179973

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02).Aug 26 2025, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 26 2025, 2:30 PM
karapayneWMDE mentioned this in T402620: [MEX] M3.1.2 - Add publish functionality to edit forms.Aug 27 2025, 10:25 AM
karapayneWMDE added a comment.EditedAug 27 2025, 10:35 AM

Note: there are two different designs when opening the edit statement screen

  • When adding a new statement, the property is changeable and listed outside of the header
  • When editing an existing statement, the property cannot be changed and is listed inside the header
Alice.moutinho updated the task description. (Show Details)Aug 28 2025, 3:48 PM
karapayneWMDE moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata-Omega (The Board) board.Aug 29 2025, 7:16 AM
karapayneWMDE added a comment.Aug 29 2025, 7:19 AM
  • The "add statement" and "add identifier" buttons open on the main screen
  • Property suggester does not load

I'm assuming these will be addressed in T402447: [MEX] M3.1.1 - create basic edit statement form for simple text inputs so I'll leave this here for now

karapayneWMDE mentioned this in T403595: [MEX] M3.1.2 - successful/unsuccessful message components.Sep 3 2025, 9:47 AM
karapayneWMDE closed this task as Resolved.Sep 5 2025, 8:14 AM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from In Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2025 Q3 on the Wikidata-Omega (Completed Tasks) board.Sep 8 2025, 8:01 AM
ArthurTaylor mentioned this in T404696: [MEX] M3.1.2 display error / success messages after 'publish' button is clicked.Sep 16 2025, 10:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits