Page MenuHomePhabricator

Design exploration: Private registrant support
Closed, ResolvedPublic

Description

Background: A good question got brought up in T400722 about how we handle private registrants. I think the main question is: Do we add their contributions to the aggregate data? If we do, then I guess someone could maybe try to guess who was a private registrant for the event. But the aggregate data would be accurate and comprehensive. If we do not, we would protect the user, but some people would see different aggregate numbers, depending on how they are viewing (for example, organizers and admins would see different final numbers than regular editors, which could create confusion).

Perhaps, for the MVP, we want something simple and protective, so we can hide all private registrant data from people who cannot see the info, but maybe we can have some help/more info indicator that can say that final numbers may vary, depending on whether they have permission to see private registrant data.

Then, for post-MVP, we can explore how we improve the data experience.

Event Timeline

design proposal:

  1. exclude private participant contributions from the aggregate stats and granular data for users who do not have permission to see them
  2. add a Message component at the top of the page (type: Notice) with copy:

for 'regular' viewers: The statistics and contributions listed on this page do not include data from private participants.

for private participants: The statistics and contributions listed on this page do not include data from other private participants.

contributions_table (7).png (2×2 px, 241 KB)

  1. add a Message component at the top of the page (type: Notice) with copy:

for 'regular' viewers: The statistics and contributions listed on this page do not include data from private participants.

for private participants: The statistics and contributions listed on this page do not include data from other private participants.

SGTM! I think it might've been implicit, but I'd add: these messages would only be shown if there are [other] private participants whose data isn't being shown.

Thanks @JFernandez-WMF, LGTM!
I just have one question, which is:
On the organizer side, are we showing private participant data?
I think we should, because organizer can see private participants.
And if the answer is yes, then for organizer we should not show the message.

@cmelo: Yes, we show private participant data to those who are permitted to see it, which will be: the person who made the edit, the organizers, and the wiki admins (or whichever groups are configured to see such data on the wikis).

So, yes, we should not show the message to organizers of the event or wiki admins (or whichever groups are configured to see such data on the wikis).

@JFernandez-WMF, do you think we're ready to create an engineering ticket for this work? I think it seems ready to me.

Thank you so much, @JFernandez-WMF! Yes, this ticket is now done. Thank you for working on this!