In T390019: Add favorite button next to watch star on template pages we added a tab next to the watch star on templates pages, with which to toggle the templates' favorite state.
The tab's button is loaded by the ext.templateData.templateDiscovery module, and so doesn't load until JS loads, thus causing a layout jump. Instead of that, the full HTML and required styles should be output when the page loads. Initially disabled, the RL module would then infuse the button and enable it.
Seems like this should be declined given the discussion around this icon conflicting with the reading lists feature. Is there a ticket for removing the favorite template bookmark icon I can track?
i don't see what the button has to do with the icon included in the button ? If someone wants to change an icon again, go ahead, that doesn't mean the rendering of the button is magically fixed.
i don't see what the button has to do with the icon included in the button ? If someone wants to change an icon again, go ahead, that doesn't mean the rendering of the button is magically fixed.
Jdlrobson-WMF means removing the whole button, rather than just the icon. There's also currently discussion about changing the favoriting icon, but it seems that even if it's changed no one really wants it on the template pages.
Declined in favour of T403126: Remove favorite button from template pages