Page MenuHomePhabricator

Deal with literal   strings in xtools translations
Open, MediumPublic

Description

ru:В русскоязычной версии xtools.wmcloud.org есть ошибка в таблице.

en: There is an mistake in a table in the Russian version of xtools.wmcloud.org.

screenshot: https://i.postimg.cc/tT4Xxh7J/Screenshot-2025-08-10-at-14-05-00-Siberian-Snake-XTools.png

link: https://xtools.wmcloud.org/pages/ru.wikipedia.org/Siberian%20Snake?uselang=ru

XTools version: 3.21.1-711e4cd5

Event Timeline

Mitte27 updated the task description. (Show Details)
Alien333 changed the task status from Open to In Progress.Aug 10 2025, 5:37 PM
Alien333 moved this task from Backlog to General / other on the XTools board.
Alien333 subscribed.

Thanks for reporting! I'm quite surprised that this has only now turned up; all of the code in question was unchanged for at least three years. On check, I found some others in various languages. Complete list (this is a grep result, not a proper json file):

{
ksh.json:	"size-gigabytes": "$1 GB",
ksh.json:	"size-kilobytes": "$1 KB",
ksh.json:	"size-megabytes": "$1 MB",
ksh.json:	"size-terabytes": "$1 TB",
sl.json:	"size-kilobytes": "$1 KB",
pl.json:	"size-gigabytes": "$1 GB",
pl.json:	"size-kilobytes": "$1 KB",
pl.json:	"size-megabytes": "$1 MB",
ru.json:	"average-edit-size": "Среднее значение размер правки",
ru.json:	"average-page-size": "Среднее значение размера страницы",
ru.json:	"edit-summaries": "Правок с описаниями",
ru.json:	"latest-action": "Самое последнее зажурналированное действие",
cs.json:	"size-over-time": "Velikost článku v průběhu času",
de.json:	"auto-edits-counts-desc": "Einige Werkzeugnutzungen überlappen sich (z. B. zählt das Zurücksetzen auf eine Version, die eine Weiterleitung ist, sowohl als Zurücksetzung als auch als Weiterleitung), so dass die Gesamtzahl der mit jedem Werkzeug durchgeführten Bearbeitungen vom $1 abweichen kann.",
br.json:	"size-terabytes": "$1 Tio",
}
Alien333 triaged this task as Medium priority.Aug 10 2025, 5:37 PM

Ah! found cause of trouble (noticed something was off when the de auto-edits-counts-desc didn't escape the nbsp). That header (and possibly others) were taken through ucfirst; a home-made filter, which, unlike the msg function, did not have ['is_safe' => ['html']] and so escaped the html characters.

We could add that to ucfirst and allow nbsps; question is do we want to?

Alien333 changed the task status from In Progress to Open.Aug 24 2025, 5:11 PM

Well, removed them in the translations, but there's still the issue of deciding whether we want them to be allowed.

Reedy renamed this task from Mistake in XTools in Russian to Mistake in XTools in Russian.Dec 26 2025, 7:19 PM
Pppery renamed this task from Mistake in XTools in Russian to Deal with literal   strings in xtools translations.Jan 6 2026, 4:01 AM